Re: [Django] #23759: Storage.get_available_name should preserve all file extensions, not just the first one

[Django]

#23759: Storage.get_available_name should preserve all file extensions, not just
the first one
-+-
 Reporter:  thenewguy|Owner:  Adam
 |  Zapletal
 Type:  New feature  |   Status:  closed
Component:  File |  Version:  dev
  uploads/storage|
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * resolution:   => fixed
 * status:  assigned => closed

Comment:

 In [changeset:"eb2d49b73408f1e60b8e1fa7fee822816945e1cd" eb2d49b]:
 {{{#!CommitTicketReference repository=""
 revision="eb2d49b73408f1e60b8e1fa7fee822816945e1cd"
 Fixed #23759 -- Preserved all file extensions in
 Storage.get_available_name().
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dc85dafde-a23fbc06-daaa-44e4-9f42-d563b93e2e7d-00%40eu-central-1.amazonses.com.

Re: [Django] #23759: Storage.get_available_name should preserve all file extensions, not just the first one

[Django]

#23759: Storage.get_available_name should preserve all file extensions, not just
the first one
-+-
 Reporter:  thenewguy|Owner:  Adam
 |  Zapletal
 Type:  New feature  |   Status:  assigned
Component:  File |  Version:  dev
  uploads/storage|
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Accepted => Ready for checkin

Comment:

 [https://github.com/django/django/pull/17881 PR]
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dc8241d0a-cdfd9225-d06f-4ab4-a637-6d7443c64ac2-00%40eu-central-1.amazonses.com.

Re: [Django] #23759: Storage.get_available_name should preserve all file extensions, not just the first one

[Django]

#23759: Storage.get_available_name should preserve all file extensions, not just
the first one
-+-
 Reporter:  thenewguy|Owner:  Adam
 |  Zapletal
 Type:  New feature  |   Status:  assigned
Component:  File |  Version:  dev
  uploads/storage|
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Adam Zapletal):

 * has_patch:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dc2cf1221-e3d24351-7ee3-4eb6-b2e3-ca95ee8cdf49-00%40eu-central-1.amazonses.com.

Re: [Django] #23759: Storage.get_available_name should preserve all file extensions, not just the first one

[Django]

#23759: Storage.get_available_name should preserve all file extensions, not just
the first one
-+-
 Reporter:  thenewguy|Owner:  Adam
 |  Zapletal
 Type:  New feature  |   Status:  assigned
Component:  File |  Version:  dev
  uploads/storage|
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Adam Zapletal):

 * owner:  (none) => Adam Zapletal
 * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dbab5989a-4bb920ec-60e7-4c7a-8463-c3ec389e672c-00%40eu-central-1.amazonses.com.

Re: [Django] #23759: Storage.get_available_name should preserve all file extensions, not just the first one

[Django]

#23759: Storage.get_available_name should preserve all file extensions, not just
the first one
--+
 Reporter:  thenewguy |Owner:  (none)
 Type:  New feature   |   Status:  new
Component:  File uploads/storage  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by felixxm):

 * owner:  thenewguy => (none)
 * status:  assigned => new


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.2da8a8864783662a8557f9bed66a01de%40djangoproject.com.

Re: [Django] #23759: Storage.get_available_name should preserve all file extensions, not just the first one

[Django]

#23759: Storage.get_available_name should preserve all file extensions, not just
the first one
-+-
 Reporter:  thenewguy|Owner:  thenewguy
 Type:  New feature  |   Status:  assigned
Component:  File |  Version:  master
  uploads/storage|   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by timgraham):

 * version:  1.7 => master
 * type:  Uncategorized => New feature
 * easy:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.e80755e2a68e44c832bc73fc29463608%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23759: Storage.get_available_name should preserve all file extensions, not just the first one

[Django]

#23759: Storage.get_available_name should preserve all file extensions, not just
the first one
-+-
 Reporter:  thenewguy|Owner:  thenewguy
 Type:  Uncategorized|   Status:  assigned
Component:  File |  Version:  1.7
  uploads/storage|   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  1|
-+-
Changes (by thenewguy):

 * owner:  nobody => thenewguy
 * status:  new => assigned
 * stage:  Unreviewed => Accepted


Comment:

 assigned and marked accepted per
 https://code.djangoproject.com/ticket/23759#comment:3

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.70ac58d9ebc85d0d5b2130f987369481%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23759: Storage.get_available_name should preserve all file extensions, not just the first one

[Django]

#23759: Storage.get_available_name should preserve all file extensions, not just
the first one
-+-
 Reporter:  thenewguy|Owner:  nobody
 Type:  Uncategorized|   Status:  new
Component:  File |  Version:  1.7
  uploads/storage|   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by claudep):

 I think that if we can do it without introducing too much complexity, we
 should do it. Could you provide a patch with tests?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.1c3cda08a9643a9ecd1f371741f731b8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23759: Storage.get_available_name should preserve all file extensions, not just the first one

[Django]

#23759: Storage.get_available_name should preserve all file extensions, not just
the first one
-+-
 Reporter:  thenewguy|Owner:  nobody
 Type:  Uncategorized|   Status:  new
Component:  File |  Version:  1.7
  uploads/storage|   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by thenewguy):

 Sorry for the delay.  I just found out status updates on tickets I am
 watching have been going to spam.  I guess that is why I never get
 updates.

 In this case, I do not think it is an issue if a valid part of the
 filename is assumed to be an extension because `get_available_name` does
 not promise to return the same filename, and it doesn't matter where the
 random string is in the name to be "available".

 However, the mimetypes module could be used to determine if an extension
 was actually an extension.  If mimetypes returns a type or an encoding,
 add the extension to the extensions list, otherwise break and assume there
 are no more extensions.

 Also, this only happens if the submitted filename already exists.

 I think it would be very nice to be able to maintain reliable file
 extensions out of the box.  This is important for many cases, including
 when a user downloads the file.

 Here is a sample mixin I've used in the past (keep in mind it does not
 query mimetypes, but that is trivial)


 {{{
 class GetUUIDAvailableNameStorageMixin(object):
 def get_available_name(self, name):
 """
 Returns a hex encoded uuid filename, using the extensions provided
 by the
 input filename, that's suitable for use in the target storage
 system.
 """
 exts = []
 root = ext = name
 while ext:
 root, ext = splitext(root)
 exts.insert(0, ext)
 name = "%s%s" % (uuid4().hex, "".join(exts))
 return super(GetUUIDAvailableNameStorageMixin,
 self).get_available_name(name)
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.ec678b92e2c3c584c591d801e2c9afd9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23759: Storage.get_available_name should preserve all file extensions, not just the first one

[Django]

#23759: Storage.get_available_name should preserve all file extensions, not just
the first one
-+-
 Reporter:  thenewguy|Owner:  nobody
 Type:  Uncategorized|   Status:  new
Component:  File |  Version:  1.7
  uploads/storage|   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by timgraham):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 In general, I think a period is a valid character in a filename, so we
 cannot simply assume everything to the right of the first period is the
 file extension. Some different strategies for the issue are detailed on
 [http://stackoverflow.com/questions/6525334/getting-file-extension-using-
 pattern-matching-in-python stackoverflow]. I am not sure its up to Django
 to pick one, but we could at least document the caveat and link how to
 write your own storage subclass so someone can implement the behavior they
 desire. Thoughts?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.db45e9534bde8dcba952538ceabebc9c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #23759: Storage.get_available_name should preserve all file extensions, not just the first one

[Django]

#23759: Storage.get_available_name should preserve all file extensions, not just
the first one
--+
 Reporter:  thenewguy |  Owner:  nobody
 Type:  Uncategorized | Status:  new
Component:  File uploads/storage  |Version:  1.7
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  1 |  UI/UX:  0
--+
 `get_available_name` only preserves the first file extension.  If the file
 is `foo.tar.gz` then `get_available_name` will return `foo.tar_RANDOM.gz`
 instead of `foo_RANDOM.tar.gz`

 https://github.com/django/django/blob/master/django/core/files/storage.py#L71


 {{{
 def get_available_name(self, name):
 """
 Returns a filename that's free on the target storage system, and
 available for new content to be written to.
 """
 dir_name, file_name = os.path.split(name)
 file_root, file_ext = os.path.splitext(file_name)
 # If the filename already exists, add an underscore and a random 7
 # character alphanumeric string (before the file extension, if one
 # exists) to the filename until the generated filename doesn't
 exist.
 while self.exists(name):
 # file_ext includes the dot.
 name = os.path.join(dir_name, "%s_%s%s" % (file_root,
 get_random_string(7), file_ext))

 return name
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.71f09b10df776ae66b226116448ae948%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.