Re: [Django] #23926: Misleading error message provided when custom permission names are too long

[Django]

#23926: Misleading error message provided when custom permission names are too 
long
-+-
 Reporter:  Greatlemer   |Owner:  joeri
 Type:  Bug  |   Status:  closed
Component:  contrib.auth |  Version:  1.7
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"0ed20d5cc4bf94646ffd4e4fcbd963b9916039cd" 0ed20d5]:
 {{{
 #!CommitTicketReference repository=""
 revision="0ed20d5cc4bf94646ffd4e4fcbd963b9916039cd"
 Fixed #23926 -- Improved validation error for custom permissions that are
 too long.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.259588b06c891ccb3e05bbfe636c9cb9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23926: Misleading error message provided when custom permission names are too long

[Django]

#23926: Misleading error message provided when custom permission names are too 
long
-+-
 Reporter:  Greatlemer   |Owner:  joeri
 Type:  Bug  |   Status:  assigned
Component:  contrib.auth |  Version:  1.7
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by erikr):

 * has_patch:  0 => 1
 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.c1baf11fe1b0a43372d29c4c7c51999a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23926: Misleading error message provided when custom permission names are too long

[Django]

#23926: Misleading error message provided when custom permission names are too 
long
--+
 Reporter:  Greatlemer|Owner:  joeri
 Type:  Bug   |   Status:  assigned
Component:  contrib.auth  |  Version:  1.7
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by joeri):

 Added PR https://github.com/django/django/pull/4274

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.ee1ef8fe7a6a5c664278dfe85f887ab8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23926: Misleading error message provided when custom permission names are too long

[Django]

#23926: Misleading error message provided when custom permission names are too 
long
--+
 Reporter:  Greatlemer|Owner:  joeri
 Type:  Bug   |   Status:  assigned
Component:  contrib.auth  |  Version:  1.7
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by joeri):

 The error is technically correct but in some cases doesn't point people to
 the most obvious cause. The cryptic database error mentioned in #18866
 was replaced with the current message. It was an improvement but with
 custom permissions, the error is still cryptic.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.b432fd544111c07b9888391f45b34b1f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23926: Misleading error message provided when custom permission names are too long

[Django]

#23926: Misleading error message provided when custom permission names are too 
long
--+
 Reporter:  Greatlemer|Owner:  joeri
 Type:  Bug   |   Status:  assigned
Component:  contrib.auth  |  Version:  1.7
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by joeri):

 * status:  new => assigned
 * owner:  nobody => joeri


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.7b0d823376e79c5b60aeb44787392c06%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23926: Misleading error message provided when custom permission names are too long

[Django]

#23926: Misleading error message provided when custom permission names are too 
long
--+
 Reporter:  Greatlemer|Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  contrib.auth  |  Version:  1.7
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by shaib):

 I'd thought for a second that the fix for #8162 fixed that too, because
 the test code included there uses permissions on permissions. I enjoy
 ironic recursion like anyone else, but it might be clearer to change that.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.d156b2de987a0eba78a3c97e01183640%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23926: Misleading error message provided when custom permission names are too long

[Django]

#23926: Misleading error message provided when custom permission names are too 
long
--+
 Reporter:  Greatlemer|Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  contrib.auth  |  Version:  1.7
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by timgraham):

 The message is still misleading in that it references `verbose_name` even
 for custom permissions.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.1ec9f3e996126b7f7642a97f77bff42a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23926: Misleading error message provided when custom permission names are too long

[Django]

#23926: Misleading error message provided when custom permission names are too 
long
--+
 Reporter:  Greatlemer|Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  contrib.auth  |  Version:  1.7
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by shaib):

 * cc: shaib (added)


Comment:

 This is actually fixed by #8162 which was fixed (only on master) by
 cf252dbea. I'm not sure if we should backport.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.1ba76baee859b003bbaed8acc9b64175%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23926: Misleading error message provided when custom permission names are too long

[Django]

#23926: Misleading error message provided when custom permission names are too 
long
--+
 Reporter:  Greatlemer|Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  contrib.auth  |  Version:  1.7
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * needs_better_patch:   => 0
 * stage:  Unreviewed => Accepted
 * needs_tests:   => 0
 * needs_docs:   => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.f5796d84d6e7a5fd845b437b7c77ccae%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #23926: Misleading error message provided when custom permission names are too long

[Django]

#23926: Misleading error message provided when custom permission names are too 
long
--+
 Reporter:  Greatlemer|  Owner:  nobody
 Type:  Bug   | Status:  new
Component:  contrib.auth  |Version:  1.7
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  0 |  UI/UX:  0
--+
 Whilst adding a new custom permission to a model, I accidentally created
 one that was too long and instead of being informed the problem was an
 overly long name field, the validation error raised complained about the
 verbose name of my model being too long.

 This was observed in Django 1.7.1 under python 2.7.

 I was able to reproduce it by putting the following code in the models.py
 of an application listed in INSTALLED_APPS:
 {{{
 from django.db.models import Model

 class Tmp(Model):
 class Meta:
 permissions = (
 (
 'can_do_something_long',
 'A custom permission name with greater than 50 chars',
 ),
 )
 }}}


 Then when I ran ./manage.py migrate I got the following error:
 {{{
 (env)blah> python ./manage.py migrate
 Operations to perform:
   Synchronize unmigrated apps: blah
   Apply all migrations: admin, contenttypes, auth, sessions
 Synchronizing apps without migrations:
   Creating tables...
 Creating table blah_tmp
   Installing custom SQL...
   Installing indexes...
 Running migrations:
   Applying contenttypes.0001_initial... OK
   Applying auth.0001_initial... OK
   Applying admin.0001_initial... OK
   Applying sessions.0001_initial... OK
 Traceback (most recent call last):
   File "./manage.py", line 10, in 
 execute_from_command_line(sys.argv)
   File "/data/home/ar/tmp/perm_issue/env/lib/python2.7/site-
 packages/django/core/management/__init__.py", line 385, in
 execute_from_command_line
 utility.execute()
   File "/data/home/ar/tmp/perm_issue/env/lib/python2.7/site-
 packages/django/core/management/__init__.py", line 377, in execute
 self.fetch_command(subcommand).run_from_argv(self.argv)
   File "/data/home/ar/tmp/perm_issue/env/lib/python2.7/site-
 packages/django/core/management/base.py", line 288, in run_from_argv
 self.execute(*args, **options.__dict__)
   File "/data/home/ar/tmp/perm_issue/env/lib/python2.7/site-
 packages/django/core/management/base.py", line 338, in execute
 output = self.handle(*args, **options)
   File "/data/home/ar/tmp/perm_issue/env/lib/python2.7/site-
 packages/django/core/management/commands/migrate.py", line 164, in handle
 emit_post_migrate_signal(created_models, self.verbosity,
 self.interactive, connection.alias)
   File "/data/home/ar/tmp/perm_issue/env/lib/python2.7/site-
 packages/django/core/management/sql.py", line 268, in
 emit_post_migrate_signal
 using=db)
   File "/data/home/ar/tmp/perm_issue/env/lib/python2.7/site-
 packages/django/dispatch/dispatcher.py", line 198, in send
 response = receiver(signal=self, sender=sender, **named)
   File "/data/home/ar/tmp/perm_issue/env/lib/python2.7/site-
 packages/django/contrib/auth/management/__init__.py", line 111, in
 create_permissions
 verbose_name_max_length,
 django.core.exceptions.ValidationError: [u'The verbose_name of tmp is
 longer than 39 characters']
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/053.7d507d5e1f0d6dd22f76f3a959c51ea8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.