Re: [Django] #24036: Ignore deprecation warnings in tests depending on the Django version
#24036: Ignore deprecation warnings in tests depending on the Django version
-+-
Reporter: aaugustin|Owner: nobody
Type: New feature | Status: closed
Component: Testing framework| Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1| Needs documentation: 0
Needs tests: 0| Patch needs improvement: 0
Easy pickings: 0|UI/UX: 0
-+-
Changes (by claudep):
* status: new => closed
* resolution: => fixed
Comment:
{{{
commit 51890ce8898f821d28f2f6fb6071c936e9bd88f0
Author: Claude Paroz <cla...@2xlibre.net>
Date: Sun Dec 21 21:19:05 2014 +0100
Applied ignore_warnings to Django tests
commit 66f9a74b4514bd259976ce8ee3a4e78288358a5f
Author: Claude Paroz <cla...@2xlibre.net>
Date: Sun Dec 21 21:13:06 2014 +0100
Added ignore_warnings decorator
And removed Ignore*DeprecationWarningsMixin, now obsolete.
Thanks Berker Peksag and Tim Graham for the review.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24036#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.6dcf225c92c9ab6d33850db2a431a334%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Re: [Django] #24036: Ignore deprecation warnings in tests depending on the Django version
#24036: Ignore deprecation warnings in tests depending on the Django version -+- Reporter: aaugustin|Owner: nobody Type: New feature | Status: new Component: Testing framework| Version: master Severity: Normal | Resolution: Keywords: | Triage Stage: Ready for | checkin Has patch: 1| Needs documentation: 0 Needs tests: 0| Patch needs improvement: 0 Easy pickings: 0|UI/UX: 0 -+- Changes (by timgraham): * stage: Accepted => Ready for checkin -- Ticket URL: <https://code.djangoproject.com/ticket/24036#comment:4> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+unsubscr...@googlegroups.com. To post to this group, send email to django-updates@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.a868df19d5b544df95d97d9f8ea53d95%40djangoproject.com. For more options, visit https://groups.google.com/d/optout.
Re: [Django] #24036: Ignore deprecation warnings in tests depending on the Django version
#24036: Ignore deprecation warnings in tests depending on the Django version ---+ Reporter: aaugustin |Owner: nobody Type: New feature| Status: new Component: Testing framework | Version: master Severity: Normal | Resolution: Keywords: | Triage Stage: Accepted Has patch: 1 | Needs documentation: 0 Needs tests: 0 | Patch needs improvement: 0 Easy pickings: 0 |UI/UX: 0 ---+ Comment (by timgraham): On the one hand, I like that the current scheme is very explicit in that we put only the code which raises the warning in a `catch_warnings()` block. On the other hand it's very verbose, error-prone, and sometimes confusing to new contributors. The decorator syntax seems very nice and it seems great to standardize the method used on classes and methods so +1 from me if there are no other objections. -- Ticket URL: <https://code.djangoproject.com/ticket/24036#comment:3> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+unsubscr...@googlegroups.com. To post to this group, send email to django-updates@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.736ceb62c1cdc50cb82683dfc999d3d0%40djangoproject.com. For more options, visit https://groups.google.com/d/optout.
Re: [Django] #24036: Ignore deprecation warnings in tests depending on the Django version
#24036: Ignore deprecation warnings in tests depending on the Django version ---+ Reporter: aaugustin |Owner: nobody Type: New feature| Status: new Component: Testing framework | Version: master Severity: Normal | Resolution: Keywords: | Triage Stage: Accepted Has patch: 1 | Needs documentation: 0 Needs tests: 0 | Patch needs improvement: 0 Easy pickings: 0 |UI/UX: 0 ---+ Changes (by claudep): * has_patch: 0 => 1 Comment: See https://github.com/django/django/pull/3771, does that look like what you had in mind? -- Ticket URL: <https://code.djangoproject.com/ticket/24036#comment:2> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+unsubscr...@googlegroups.com. To post to this group, send email to django-updates@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.ae5f1d44fe86ed93e144dd964c36ff6b%40djangoproject.com. For more options, visit https://groups.google.com/d/optout.
Re: [Django] #24036: Ignore deprecation warnings in tests depending on the Django version
#24036: Ignore deprecation warnings in tests depending on the Django version ---+ Reporter: aaugustin |Owner: nobody Type: New feature| Status: new Component: Testing framework | Version: master Severity: Normal | Resolution: Keywords: | Triage Stage: Accepted Has patch: 0 | Needs documentation: 0 Needs tests: 0 | Patch needs improvement: 0 Easy pickings: 0 |UI/UX: 0 ---+ Changes (by claudep): * stage: Unreviewed => Accepted Comment: I'll try to have a look at it. -- Ticket URL: <https://code.djangoproject.com/ticket/24036#comment:1> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+unsubscr...@googlegroups.com. To post to this group, send email to django-updates@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.143aad25d3d24e95956232ed28b66b38%40djangoproject.com. For more options, visit https://groups.google.com/d/optout.
[Django] #24036: Ignore deprecation warnings in tests depending on the Django version
#24036: Ignore deprecation warnings in tests depending on the Django version -+ Reporter: aaugustin | Owner: nobody Type: New feature| Status: new Component: Testing framework |Version: master Severity: Normal | Keywords: Triage Stage: Unreviewed | Has patch: 0 Needs documentation: 0 |Needs tests: 0 Patch needs improvement: 0 | Easy pickings: 0 UI/UX: 0 | -+ We used to replace all `PendingDeprecationWarning` with `DeprecationWarning` after each release. We introduced `RemovedInDjangoXYWarning` to solve this problem. We're still replacing `IgnorePendingDeprecationWarningsMixin` with `IgnoreDeprecationWarningsMixin`. We should introduce a similar solution. -- Ticket URL: <https://code.djangoproject.com/ticket/24036> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+unsubscr...@googlegroups.com. To post to this group, send email to django-updates@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/052.a4a9a2472f34c8926d18da9855307122%40djangoproject.com. For more options, visit https://groups.google.com/d/optout.
