Re: [Django] #24064: Spatialite tests could use or create real database

[Django]

#24064: Spatialite tests could use or create real database
-+-
 Reporter:  coldmind |Owner:  coldmind
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"839f431ef5b927c8b07ce33483b3a7b0dd17b761"]:
 {{{
 #!CommitTicketReference repository=""
 revision="839f431ef5b927c8b07ce33483b3a7b0dd17b761"
 Fixed #24064 -- Prevented database access at compile time in spatialite
 models.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.b1c031371868372db11f8e32a802cb7d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24064: Spatialite tests could use or create real database

[Django]

#24064: Spatialite tests could use or create real database
-+-
 Reporter:  coldmind |Owner:  coldmind
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by coldmind):

 * needs_better_patch:  1 => 0


Comment:

 Tests are passing now, please review

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.1baff9d7600e182513bd684194446e51%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24064: Spatialite tests could use or create real database

[Django]

#24064: Spatialite tests could use or create real database
-+-
 Reporter:  coldmind |Owner:  coldmind
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * needs_better_patch:  0 => 1


Comment:

 Tests don't pass on Jenkins.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.8d6802f9d3698ea3da7d3e8b37b83196%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24064: Spatialite tests could use or create real database

[Django]

#24064: Spatialite tests could use or create real database
-+-
 Reporter:  coldmind |Owner:  coldmind
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by coldmind):

 * owner:  nobody => coldmind
 * status:  new => assigned
 * has_patch:  0 => 1
 * cc: coldmind (added)


Comment:

 https://github.com/django/django/pull/3821

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.56014621e18fd24c41937720fc47c33b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24064: Spatialite tests could use or create real database

[Django]

#24064: Spatialite tests could use or create real database
-+-
 Reporter:  coldmind |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * severity:  Normal => Release blocker


Comment:

 This is a release blocker as it causes the test from #12118 to fail on
 [http://djangoci.com/job/django-master-trusty/ django-master-trusty].

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.630d3d0a7d6aec7d9af817096970543a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24064: Spatialite tests could use or create real database

[Django]

#24064: Spatialite tests could use or create real database
-+-
 Reporter:  coldmind |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by coldmind):

 An idea how this could be resolved.
 https://gist.github.com/coldmind/be61c330c7e56974bb51

 This looks more good than creating meta magic on classes to make these
 fields to be dynamic

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.384939bf9dc58dc762b215b78d46ecaa%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24064: Spatialite tests could use or create real database

[Django]

#24064: Spatialite tests could use or create real database
-+-
 Reporter:  coldmind |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by claudep):

 * stage:  Unreviewed => Accepted


Comment:

 Basically, the problem is the `type` field of the
 `SpatialiteGeometryColumns` model depends on the Spatialite version. And
 as this happens at import time, the test machinery has not yet done its
 job.
 See
 
https://github.com/django/django/blob/51890ce8898f821d28f2f6fb6071c936e9bd88f0/django/contrib/gis/db/backends/spatialite/models.py#L16-L19

 It's not the only location in Django where we could take advantage of a
 lazy model field instanciation, but I'm not aware of any such method
 currently. Ideas?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.436860942463e867a12c82ff08144b1f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24064: Spatialite tests could use or create real database

[Django]

#24064: Spatialite tests could use or create real database
-+-
 Reporter:  coldmind |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by coldmind):

 * needs_better_patch:   => 0
 * component:  Uncategorized => Database layer (models, ORM)
 * needs_tests:   => 0
 * needs_docs:   => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.b6a0d45328f5c434459aa73fb4eddec7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #24064: Spatialite tests could use or create real database

[Django]

#24064: Spatialite tests could use or create real database
---+
 Reporter:  coldmind   |  Owner:  nobody
 Type:  Bug| Status:  new
Component:  Uncategorized  |Version:  master
 Severity:  Normal |   Keywords:
 Triage Stage:  Unreviewed |  Has patch:  0
Easy pickings:  0  |  UI/UX:  0
---+
 Modify your test config to be like this:
 {{{
 DATABASES = {
 'default': {
 'ENGINE': 'django.contrib.gis.db.backends.spatialite',
 'NAME': 'nonmemory',
 'TEST_NAME': ':memory:',
 },
 'other': {
 'ENGINE': 'django.contrib.gis.db.backends.spatialite',
 'NAME': 'nonmemory2',
 'TEST_NAME': ':memory:',
 }
 }
 }}}

 Then run `python runtests.py django.contrib.gis.tests.test_geoforms`.
 File with name `nonmemory` will be created, it is not correct.

 More details about investigation:

 Issue was found here:
 https://github.com/django/django/pull/3677#issuecomment-68381272

 Some investigation logs:
 {{{
  timograham, It is strange. Look at
 
https://github.com/django/django/blob/51890ce8898f821d28f2f6fb6071c936e9bd88f0/django/contrib/gis/tests/utils.py#L39
  This import causing problems.
  For example if it is imported, python runtests.py backends
 django.contrib.gis.tests.test_geoforms will fail, but when I removed it
 (this import is not used in test_geoforms), tests passing correctly. Any
 ideas what it could be?
 ...
  timograham, in this file connection.ops.spatial_version[0]
 used, which is performing some database operation. I will try to figure
 out what is the problem
  without this call all is okay
  timograham, calling cursor in
 
https://github.com/django/django/blob/51890ce8898f821d28f2f6fb6071c936e9bd88f0/django/contrib/gis/db/backends/spatialite/operations.py#L211
 causing problems. Does cursor close connection or something else?
 ...

 timograham, when running tests, call to get spatialite version is calling
 cursor, which creates new connection, which is not a test database
 connection. I printed connection params, and saw that database name was
 ":memory:" instead of string which should be for new in-memory databases.
 It is telling us that test database was not used. You can check it in
 another way: sqlite allows to not specify database name, and if it will be
 not specified, and you will try to run `python runtests.py
 django.contrib.gis.tests.test_geoforms`, it will raise an exception
 "Please supply the NAME value.".
 If I am right, this should be considered as another issue.
 (:memory: was printed because it was specified in my settings as NAME)
 Or, if running test_geoforms with NAME as some string, and TEST_NAME as
 :memory:, database file will be created. This is not correct, doesn't it?
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.4027ceede3195faee6fcc9113be0bb5c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.