Re: [Django] #24116: Refactor AdminSite.check_dependencies with the checks framework

[Django]

#24116: Refactor AdminSite.check_dependencies with the checks framework
-+-
 Reporter:  aaugustin|Owner:
 Type:   |  vincepandolfo
  Cleanup/optimization   |   Status:  closed
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"0490d72f2a309ee2c6d73cdc5aa5cc381e14ae98" 0490d72]:
 {{{
 #!CommitTicketReference repository=""
 revision="0490d72f2a309ee2c6d73cdc5aa5cc381e14ae98"
 Fixed #24116 -- Moved AdminSite.check_dependencies() to system checks.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.817d623992f16a4598fc27ae03210301%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24116: Refactor AdminSite.check_dependencies with the checks framework

[Django]

#24116: Refactor AdminSite.check_dependencies with the checks framework
-+-
 Reporter:  aaugustin|Owner:
 Type:   |  vincepandolfo
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by vincepandolfo):

 * needs_better_patch:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.74a9b1213d2cc3b2fa7d59011f700e4e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24116: Refactor AdminSite.check_dependencies with the checks framework

[Django]

#24116: Refactor AdminSite.check_dependencies with the checks framework
-+-
 Reporter:  aaugustin|Owner:
 Type:   |  vincepandolfo
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-
Changes (by timgraham):

 * needs_better_patch:  0 => 1


Comment:

 Left a round of review comments. Please uncheck "Patch needs improvement"
 after it's updated.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.1eb05b5bc5351b7aebb155eaee073462%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24116: Refactor AdminSite.check_dependencies with the checks framework

[Django]

#24116: Refactor AdminSite.check_dependencies with the checks framework
-+-
 Reporter:  aaugustin|Owner:
 Type:   |  vincepandolfo
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by timgraham):

 * needs_docs:  1 => 0
 * needs_tests:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.91227bdf912338e41fa326b6293a80be%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24116: Refactor AdminSite.check_dependencies with the checks framework

[Django]

#24116: Refactor AdminSite.check_dependencies with the checks framework
-+-
 Reporter:  aaugustin|Owner:
 Type:   |  vincepandolfo
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by vincepandolfo):

 New commit diff:
 
[https://github.com/vincepandolfo/django/commit/99ac598e903c18dadca8dcc55a5d28aa6c95b47c]

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.b92b40843c6b94aaa4e26a7c440e9939%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24116: Refactor AdminSite.check_dependencies with the checks framework

[Django]

#24116: Refactor AdminSite.check_dependencies with the checks framework
-+-
 Reporter:  aaugustin|Owner:
 Type:   |  vincepandolfo
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by timgraham):

 * needs_docs:  0 => 1
 * has_patch:  0 => 1
 * needs_tests:  0 => 1


Comment:

 Ideally we could also add some tests for this and documentation in
 `docs/ref/checks.txt`.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.15ad24ff1f0e10a1a92f79a3d61a1e68%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24116: Refactor AdminSite.check_dependencies with the checks framework

[Django]

#24116: Refactor AdminSite.check_dependencies with the checks framework
-+-
 Reporter:  aaugustin|Owner:
 Type:   |  vincepandolfo
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by vincepandolfo):

 I was reading the docs for the admin site and it lists some dependencies
 that are not checked by the check_dependencies() method. Should I add
 checks for those other dependencies or are the docs outdated?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.d3f356567f0019d786cef9929a39198f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24116: Refactor AdminSite.check_dependencies with the checks framework

[Django]

#24116: Refactor AdminSite.check_dependencies with the checks framework
-+-
 Reporter:  aaugustin|Owner:
 Type:   |  vincepandolfo
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by vincepandolfo):

 * owner:  nobody => vincepandolfo
 * status:  new => assigned


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.cc0fb4c7e9ac84e3d96ef78042cc85bb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24116: Refactor AdminSite.check_dependencies with the checks framework

[Django]

#24116: Refactor AdminSite.check_dependencies with the checks framework
--+
 Reporter:  aaugustin |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  contrib.admin |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by timgraham):

 * easy:  0 => 1


Comment:

 Another problem from duplicate ticket #25877, "It runs as a side effect of
 loading the admin URLs. If it must run when Django starts it should be
 called from `AdminAppConfig.ready()` instead."

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.4a3c550c489e8fd147dab93b7e760ab9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24116: Refactor AdminSite.check_dependencies with the checks framework

[Django]

#24116: Refactor AdminSite.check_dependencies with the checks framework
--+
 Reporter:  aaugustin |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  contrib.admin |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * stage:  Unreviewed => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.ebc87023ffceae367879370f0638f444%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24116: Refactor AdminSite.check_dependencies with the checks framework

[Django]

#24116: Refactor AdminSite.check_dependencies with the checks framework
-+-
 Reporter:  aaugustin|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Description changed by aaugustin:

Old description:

> The title says it all.

New description:

 The title says it all.

 This ticket should also consider improving or dropping the check for the
 `auth` context processor. Currently it's skipped when there isn't exactly
 one Django templates engine configured in `TEMPLATES`. This could be
 improved. It doesn't account for the possibility that a developer will
 provide their own customized version. This is intractable.

--

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.10912bb7fe7be80f11ed974ef9271d23%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #24116: Refactor AdminSite.check_dependencies with the checks framework

[Django]

#24116: Refactor AdminSite.check_dependencies with the checks framework
+
   Reporter:  aaugustin |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  contrib.admin |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 The title says it all.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.90bb80592ebcb84495a9449ef18b5834%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.