Re: [Django] #24502: Using non model fields in an admin ModelForm does not work if the field is listed in fieldsets (and fields I think)

[Django]

#24502: Using non model fields in an admin ModelForm does not work if the field 
is
listed in fieldsets (and fields I think)
---+--
 Reporter:  bdauvergne |Owner:  nobody
 Type:  Uncategorized  |   Status:  closed
Component:  Uncategorized  |  Version:  1.7
 Severity:  Normal |   Resolution:  needsinfo
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by timgraham):

 * status:  new => closed
 * resolution:   => needsinfo


Comment:

 Your example is too complicated for me to debug and reproduce (for example
 `attribute.contribute_to_form` isn't part of Django), and there's evidence
 that referring to non-model fields does work, see
 
https://github.com/django/django/commit/dc3d2ac98c1bcfad74d3e9523caf07e7e9fb15aa
 for tests. Please reopen if you can simplify your example so it can be
 reproduced (ideally, as a test for Django's test suite that passes on 1.5
 and fails in 1.7). If you can
 [https://docs.djangoproject.com/en/dev/internals/contributing/triaging-
 tickets/#bisecting-a-regression bisect the regression] all the better.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.5fc3d95f32358c8ccbf1d810b2308735%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24502: Using non model fields in an admin ModelForm does not work if the field is listed in fieldsets (and fields I think)

[Django]

#24502: Using non model fields in an admin ModelForm does not work if the field 
is
listed in fieldsets (and fields I think)
---+--
 Reporter:  bdauvergne |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  Uncategorized  |  Version:  1.7
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by bdauvergne):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 I worked around the problem with this hack in my code:

 {{{

 @@ -188,16 +189,30 @@ class AuthenticUserAdmin(UserAdmin):
  qs = models.Attribute.objects.filter(required=True)
  insertion_idx = 1
  if qs.exists():
  fieldsets = list(fieldsets)
  fieldsets.insert(insertion_idx,
  (_('Attributes'), {'fields': [at.name for at in
 qs]}))
  return fieldsets

 +def get_form(self, request, obj=None, **kwargs):
 +if 'fields' in kwargs:
 +fields = kwargs.pop('fields')
 +else:
 +fields = flatten_fieldsets(self.get_fieldsets(request, obj))
 +if obj:
 +qs = models.Attribute.objects.all()
 +else:
 +qs = models.Attribute.objects.filter(required=True)
 +non_model_fields = [a.name for a in qs]
 +fields = list(set(fields) - set(non_model_fields))
 +kwargs['fields'] = fields
 +return super(AuthenticUserAdmin, self).get_form(request, obj=obj,
 **kwargs)
 +
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.c11ccf225f9cbf3c06f49f7439bf10a6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #24502: Using non model fields in an admin ModelForm does not work if the field is listed in fieldsets (and fields I think)

[Django]

#24502: Using non model fields in an admin ModelForm does not work if the field 
is
listed in fieldsets (and fields I think)
---+
 Reporter:  bdauvergne |  Owner:  nobody
 Type:  Uncategorized  | Status:  new
Component:  Uncategorized  |Version:  1.7
 Severity:  Normal |   Keywords:
 Triage Stage:  Unreviewed |  Has patch:  0
Easy pickings:  0  |  UI/UX:  0
---+
 I have such change form:

 {{{
  19 class UserAttributeFormMixin(object):
  20 def __init__(self, *args, **kwargs):
  21 super(UserAttributeFormMixin, self).__init__(*args, **kwargs)
  22 self.attributes = self.get_attributes()
  23 initial = {}
  24 if 'instance' in kwargs:
  25 content_type =
 ContentType.objects.get_for_model(self.instance)
  26 for av in models.AttributeValue.objects.filter(
  27 content_type=content_type,
  28 object_id=self.instance.pk):
  29 initial[av.attribute.name] = av.to_python()
  30 for attribute in self.attributes:
  31 iv = initial.get(attribute.name)
  32 attribute.contribute_to_form(self, initial=iv)
  33

 class UserChangeForm(forms.UserAttributeFormMixin,
  11 AuthUserChangeForm):
  12
  13 class Meta(AuthUserChangeForm.Meta):
  14 model = get_user_model()
  15 fields = '__all__'
  16
 }}}

 Use by the following ModelAdmin:

 {{{
 161 class AuthenticUserAdmin(UserAdmin):
 162 fieldsets = (
 163 (None, {'fields': ('username', 'password')}),
 164 (_('Personal info'), {'fields': ('first_name', 'last_name',
 'email')}),
 165 (_('Permissions'), {'fields': ('is_active', 'is_staff',
 'is_superuser',
 166'groups')}),
 167 (_('Important dates'), {'fields': ('last_login',
 'date_joined')}),
 168 )
 169 form = admin_forms.UserChangeForm
 170 add_form = admin_forms.UserCreationForm
 171 add_fieldsets = (
 172 (None, {
 173 'classes': ('wide',),
 174 'fields': ('username', 'first_name', 'last_name',
 'email', 'password1', 'password2')}
 175 ),
 176 )
 177 list_filter = UserAdmin.list_filter +
 (UserRealmListFilter,ExternalUserListFilter)
 178
 179 def get_fieldsets(self, request, obj=None):
 180 fieldsets = deepcopy(super(AuthenticUserAdmin,
 self).get_fieldsets(request, obj))
 181 if obj:
 182 if not request.user.is_superuser:
 183 fieldsets[2][1]['fields'] = filter(lambda x: x !=
 184 'is_superuser', fieldsets[2][1]['fields'])
 185 qs = models.Attribute.objects.all()
 186 insertion_idx = 2
 187 else:
 188 qs = models.Attribute.objects.filter(required=True)
 189 insertion_idx = 1
 190 if qs.exists():
 191 fieldsets = list(fieldsets)
 192 fieldsets.insert(insertion_idx,·
 193 (_('Attributes'), {'fields': [at.name for at in
 qs]}))
 194 return fieldsets
 }}}

 I get the following traceback I did not get with Django 1.5 (I cannot say
 if it was already the case with Django 1.6 we skiped it):

 {{{

 /home/bdauvergne/.virtualenvs/authentic/local/lib/python2.7/site-
 packages/django/contrib/admin/options.py in changeform_view

 'name': force_text(opts.verbose_name), 'key':
 escape(object_id)})

 if request.method == 'POST' and "_saveasnew" in
 request.POST:

 return self.add_view(request,
 form_url=reverse('admin:%s_%s_add' % (

 opts.app_label, opts.model_name),

 current_app=self.admin_site.name))

 ModelForm = self.get_form(request, obj)

 ...

 if request.method == 'POST':

 form = ModelForm(request.POST, request.FILES,
 instance=obj)

 if form.is_valid():

 form_validated = True

 new_object = self.save_form(request, form, change=not
 add)

 else:

 ▶ Local vars
 /home/bdauvergne/.virtualenvs/authentic/local/lib/python2.7/site-
 packages/django/contrib/auth/admin.py in get_form

 """

 Use special form during user creation

 """

 defaults = {}

 if obj is None:

 defaults['form'] = self.add_form

 defaults.update(kwargs)

 return super(UserAdmin, self).get_form(request, obj,
 **defaults)

 ...

 def get_urls(self):

 from django.conf.urls import patterns

 return patterns('',

 (r'^(\d+)/password/$',

  self.admin_site.admin_view(self.user_change_password))

 ▶ Local