Re: [Django] #24510: FileField.upload_to documentation misleading

[Django]

#24510: FileField.upload_to documentation misleading
-+-
 Reporter:  mbertheau|Owner:
 Type:   |  mattseymour
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"98c5370ef673bc83deaf24c197e0bb22a75071e3" 98c5370]:
 {{{
 #!CommitTicketReference repository=""
 revision="98c5370ef673bc83deaf24c197e0bb22a75071e3"
 Fixed #24510 -- Clarified FileField.upload_to docs.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.4bf4e92de14e8ca0aa0f77e309c25ae7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24510: FileField.upload_to documentation misleading

[Django]

#24510: FileField.upload_to documentation misleading
-+-
 Reporter:  mbertheau|Owner:
 Type:   |  mattseymour
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by mattseymour):

 * has_patch:  0 => 1
 * easy:  0 => 1


Comment:

 Pull request added at github https://github.com/django/django/pull/4396

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.5b2b8951af4188a131a77130c47344aa%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24510: FileField.upload_to documentation misleading

[Django]

#24510: FileField.upload_to documentation misleading
-+-
 Reporter:  mbertheau|Owner:
 Type:   |  mattseymour
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by mattseymour):

 * status:  new => assigned
 * owner:  nobody => mattseymour


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.26e34373a350e29af8e5668aa8c9918a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24510: FileField.upload_to documentation misleading

[Django]

#24510: FileField.upload_to documentation misleading
--+
 Reporter:  mbertheau |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * stage:  Unreviewed => Accepted


Comment:

 If you'd like to draft a patch, I'll be happy to review it.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.55d1ec92d67165636ea42c5c6c4c621a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24510: FileField.upload_to documentation misleading

[Django]

#24510: FileField.upload_to documentation misleading
-+-
 Reporter:  mbertheau|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by mbertheau):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 Also, if what's in the first sentence is really the main purpose and way
 of functioning for `upload_to`, then `upload_to` is a misnomer.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.334c7e7b39051dbd2cb19e5bbe88892c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #24510: FileField.upload_to documentation misleading

[Django]

#24510: FileField.upload_to documentation misleading
--+
 Reporter:  mbertheau |  Owner:  nobody
 Type:  Cleanup/optimization  | Status:  new
Component:  Documentation |Version:  master
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  0 |  UI/UX:  0
--+
 In
 
https://docs.djangoproject.com/en/dev/ref/models/fields/#django.db.models.FileField.upload_to
 it says:

 > A local filesystem path that will be appended to your MEDIA_ROOT setting
 to determine the value of the url attribute.

 While this may be true with the default storage, it's misleading because
 it suggests that this behaviour (append to MEDIA_ROOT to get the URL)
 can't be changed. It's also the first sentence and main explanation for
 `upload_to`, which increases the severity of the misleading.

 In particular, you might want to make uploaded files not available to the
 general public, i.e. use a storage with `base_url` set to `None`. The
 first sentence sounds like you have to hack around django to implement
 that.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.57a99ef603c6647af45c7a0ce88ca281%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.