Re: [Django] #24591: Copy ModelState.fields and ModelState.managers instead of cloning.

2015-10-22 Thread Django 
#24591: Copy ModelState.fields and ModelState.managers instead of cloning.
-+-
 Reporter:  knbk |Owner:  knbk
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Migrations   |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by timgraham):

 It's an ongoing project to improve the speed of migrations. Django 1.9 has
 more improvements, please test it if you are able. Feel free to create a
 ticket with details and profiling output to help us out. Unfortunately, I
 don't think Django 1.8 is likely to get more improvements at this point.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.40c120b53e171876bd799c4e67c312ed%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24591: Copy ModelState.fields and ModelState.managers instead of cloning.

2015-10-22 Thread Django 
#24591: Copy ModelState.fields and ModelState.managers instead of cloning.
-+-
 Reporter:  knbk |Owner:  knbk
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Migrations   |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by dalore):

 I know this has been marked fixed but how is this fixed? I followed
 another ticket to here in which was about the migrations being slow, well
 this is what I get after upgrading Django from 1.6 to 1.8 when running
 test (To see if everything works):

   Running migrations:
   Rendering model states...
   DONE (1410.571s)

 Then it goes on and runs each migration taking 1 - 60 per migrations. How
 is 20+ minutes acceptable? This is the time it takes before it even starts
 applying the new initial migrations.

 This is an old project that started in the early django days, even Andrew
 Godwin himself worked on this project for a bit.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.417ae6ae980eff3edb6b57dfe36e948b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24591: Copy ModelState.fields and ModelState.managers instead of cloning.

2015-04-20 Thread Django 
#24591: Copy ModelState.fields and ModelState.managers instead of cloning.
-+-
 Reporter:  knbk |Owner:  knbk
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Migrations   |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"1a1f16d67da7080241ad9f6b4325f22364ac57ba" 1a1f16d6]:
 {{{
 #!CommitTicketReference repository=""
 revision="1a1f16d67da7080241ad9f6b4325f22364ac57ba"
 Fixed #24591 -- Optimized cloning of ModelState objects.

 Changed ModelState.clone() to create a shallow copy of self.fields
 and self.managers.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.6766caa92077b5b6960e96ebe9547fd8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24591: Copy ModelState.fields and ModelState.managers instead of cloning.

2015-04-20 Thread Django 
#24591: Copy ModelState.fields and ModelState.managers instead of cloning.
-+-
 Reporter:  knbk |Owner:  knbk
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Migrations   |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"516907540b81c009b74d29b2fa36319b47528b49" 51690754]:
 {{{
 #!CommitTicketReference repository=""
 revision="516907540b81c009b74d29b2fa36319b47528b49"
 [1.8.x] Refs #24591 -- Optimized cloning of ModelState objects.

 Changed ModelState.clone() to create a deepcopy of self.fields.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.48eb6e766bc106ef2c52231c91898afb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24591: Copy ModelState.fields and ModelState.managers instead of cloning.

2015-04-19 Thread Django 
#24591: Copy ModelState.fields and ModelState.managers instead of cloning.
-+-
 Reporter:  knbk |Owner:  knbk
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Migrations   |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by MarkusH):

 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.053fb64dc073a3591bc1164ad840ba80%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24591: Copy ModelState.fields and ModelState.managers instead of cloning.

2015-04-19 Thread Django 
#24591: Copy ModelState.fields and ModelState.managers instead of cloning.
--+
 Reporter:  knbk  |Owner:  knbk
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Migrations|  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by knbk):

 * needs_better_patch:  1 => 0
 * needs_docs:  1 => 0


Comment:

 A more conservative backport for 1.8:
 https://github.com/django/django/pull/4533

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.d876aeffd9c8f600018125d17d64ecd3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24591: Copy ModelState.fields and ModelState.managers instead of cloning.

2015-04-17 Thread Django 
#24591: Copy ModelState.fields and ModelState.managers instead of cloning.
--+
 Reporter:  knbk  |Owner:  knbk
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Migrations|  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  1
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by MarkusH):

 * needs_docs:  0 => 1


Comment:

 Checking "Needs documentation" because the operations documentation needs
 a warning about not modifying fields and possible breaking change for 3rd
 party operations in the release notes.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.dbe907709ee8eca09fce9ab3a0b5ad7e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24591: Copy ModelState.fields and ModelState.managers instead of cloning.

2015-04-16 Thread Django 
#24591: Copy ModelState.fields and ModelState.managers instead of cloning.
--+
 Reporter:  knbk  |Owner:  knbk
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Migrations|  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by charettes):

 * needs_better_patch:  0 => 1
 * stage:  Ready for checkin => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.71935f6b57678c52ddd5efb9b31ec84d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24591: Copy ModelState.fields and ModelState.managers instead of cloning.

2015-04-16 Thread Django 
#24591: Copy ModelState.fields and ModelState.managers instead of cloning.
-+-
 Reporter:  knbk |Owner:  knbk
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Migrations   |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.39d6865541891d2c9497cdf9c7add71a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24591: Copy ModelState.fields and ModelState.managers instead of cloning.

2015-04-11 Thread Django 
#24591: Copy ModelState.fields and ModelState.managers instead of cloning.
--+
 Reporter:  knbk  |Owner:  knbk
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Migrations|  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by knbk):

 * status:  new => assigned


Comment:

 The last commit in !4460 stores the deconstructed state when initializing
 the wrapper. I think that's the most comprehensive protection we can
 offer, without a noticeable performance cost. We might issue a warning
 instead of raising an exception in `__setattr__`: it is no longer an error
 to change the field, it is simply useless.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.44d133d50cfc3cb9054e5bacdd090c7a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24591: Copy ModelState.fields and ModelState.managers instead of cloning.

2015-04-06 Thread Django 
#24591: Copy ModelState.fields and ModelState.managers instead of cloning.
--+
 Reporter:  knbk  |Owner:  knbk
 Type:  Cleanup/optimization  |   Status:  new
Component:  Migrations|  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by MarkusH):

 * stage:  Unreviewed => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.a581a40ba0d11a4428ffd44f233bf9fa%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24591: Copy ModelState.fields and ModelState.managers instead of cloning. (was: Copy ModelState.fields and ModelState.managers instead of clone)

2015-04-06 Thread Django 
#24591: Copy ModelState.fields and ModelState.managers instead of cloning.
-+-
 Reporter:  knbk |Owner:  knbk
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Migrations   |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by knbk):

 * needs_docs:   => 0
 * needs_better_patch:   => 0
 * needs_tests:   => 0


Comment:

 PR: https://github.com/django/django/pull/4460

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.030e9461a03a0e0d1704be1a53c97649%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.