Re: [Django] #24652: SimpleTestCase should prevent execution of database queries

2015-05-25 Thread Django
#24652: SimpleTestCase should prevent execution of database queries
-+-
 Reporter:  charettes|Owner:  charettes
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Simon Charette ):

 In [changeset:"4ccfc4439a7add24f8db4ef3960d02ef8ae09887" 4ccfc44]:
 {{{
 #!CommitTicketReference repository=""
 revision="4ccfc4439a7add24f8db4ef3960d02ef8ae09887"
 Refs #24652 -- Fixed a test failure in file_uploads tests on Windows.

 Thanks to Tim Graham for the report.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.a903e76e9d05db7de6004f9c6a30be2e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #24652: SimpleTestCase should prevent execution of database queries

2015-05-20 Thread Django
#24652: SimpleTestCase should prevent execution of database queries
-+-
 Reporter:  charettes|Owner:  charettes
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Simon Charette ):

 In [changeset:"be67400b477c1b0e7e81766f41bbceed0de74bdc" be67400b]:
 {{{
 #!CommitTicketReference repository=""
 revision="be67400b477c1b0e7e81766f41bbceed0de74bdc"
 Refs #24652 -- Used SimpleTestCase where appropriate.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.7288f247d540e8ee16a9f1dc39c06635%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #24652: SimpleTestCase should prevent execution of database queries

2015-05-20 Thread Django
#24652: SimpleTestCase should prevent execution of database queries
-+-
 Reporter:  charettes|Owner:  charettes
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Simon Charette ):

 In [changeset:"e846ea0649b29df4dc1ecbac3b79769099e61a9c" e846ea06]:
 {{{
 #!CommitTicketReference repository=""
 revision="e846ea0649b29df4dc1ecbac3b79769099e61a9c"
 [1.8.x] Refs #24652 -- Enforced test isolation in file_storage tests.

 Backport of 3db21c351b9b1108954c388799d35c8dad7dfc19 from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.bd1e7742c7d665bd97d17aeba5c6cdcb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #24652: SimpleTestCase should prevent execution of database queries

2015-05-20 Thread Django
#24652: SimpleTestCase should prevent execution of database queries
-+-
 Reporter:  charettes|Owner:  charettes
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Simon Charette ):

 In [changeset:"3ab3be4b5d9dca8d278f261c4c7d124275bbf3bd" 3ab3be4b]:
 {{{
 #!CommitTicketReference repository=""
 revision="3ab3be4b5d9dca8d278f261c4c7d124275bbf3bd"
 [1.8.x] Refs #24652 -- Converted a template test to avoid executing
 queries.

 Backport of 8bf1449edb4139451643e3823b194b4c02ca7633 from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.2c0f45a0002b08540258770a37c8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #24652: SimpleTestCase should prevent execution of database queries

2015-05-20 Thread Django
#24652: SimpleTestCase should prevent execution of database queries
-+-
 Reporter:  charettes|Owner:  charettes
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Simon Charette ):

 In [changeset:"2b2a2157d0f4f1c7c4244374a460953846c65dd4" 2b2a2157]:
 {{{
 #!CommitTicketReference repository=""
 revision="2b2a2157d0f4f1c7c4244374a460953846c65dd4"
 [1.8.x] Refs #24652 -- Made sure template backend tests call their super
 setUpClass.

 Backport of ead36e8a471389a6032d825c8245245ebb89ea5d from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.bf01654a2ac9c2f889fd918daa7dd581%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #24652: SimpleTestCase should prevent execution of database queries

2015-05-20 Thread Django
#24652: SimpleTestCase should prevent execution of database queries
-+-
 Reporter:  charettes|Owner:  charettes
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Simon Charette ):

 In [changeset:"8bf1449edb4139451643e3823b194b4c02ca7633" 8bf1449]:
 {{{
 #!CommitTicketReference repository=""
 revision="8bf1449edb4139451643e3823b194b4c02ca7633"
 Refs #24652 -- Converted a template test to avoid executing queries.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.9a117d4ec6ec41416a312e162af2480f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #24652: SimpleTestCase should prevent execution of database queries

2015-05-20 Thread Django
#24652: SimpleTestCase should prevent execution of database queries
-+-
 Reporter:  charettes|Owner:  charettes
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Simon Charette ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"c15b0c27927afd141d311dd9bfe68540cf44a8d6" c15b0c2]:
 {{{
 #!CommitTicketReference repository=""
 revision="c15b0c27927afd141d311dd9bfe68540cf44a8d6"
 Fixed #24652 -- Disallowed query execution in SimpleTestCase subclasses.

 Thanks to Tim and Anssi for the review.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.42b4013a8842b2d88a7f9f6d24e2f8b5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #24652: SimpleTestCase should prevent execution of database queries

2015-05-20 Thread Django
#24652: SimpleTestCase should prevent execution of database queries
-+-
 Reporter:  charettes|Owner:  charettes
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Simon Charette ):

 In [changeset:"ead36e8a471389a6032d825c8245245ebb89ea5d" ead36e8]:
 {{{
 #!CommitTicketReference repository=""
 revision="ead36e8a471389a6032d825c8245245ebb89ea5d"
 Refs #24652 -- Made sure template backend tests call their super
 setUpClass.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.4767e61b481b5a122bcc6aabf63c1c99%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #24652: SimpleTestCase should prevent execution of database queries

2015-05-20 Thread Django
#24652: SimpleTestCase should prevent execution of database queries
-+-
 Reporter:  charettes|Owner:  charettes
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Simon Charette ):

 In [changeset:"3db21c351b9b1108954c388799d35c8dad7dfc19" 3db21c35]:
 {{{
 #!CommitTicketReference repository=""
 revision="3db21c351b9b1108954c388799d35c8dad7dfc19"
 Refs #24652 -- Enforced test isolation in file_storage tests.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.dadaac998ccc7a93f44e789ca2994572%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #24652: SimpleTestCase should prevent execution of database queries

2015-05-20 Thread Django
#24652: SimpleTestCase should prevent execution of database queries
-+-
 Reporter:  charettes|Owner:  charettes
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.e726c0a59838e0d859d1a730abce1adc%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #24652: SimpleTestCase should prevent execution of database queries

2015-05-19 Thread Django
#24652: SimpleTestCase should prevent execution of database queries
-+-
 Reporter:  charettes|Owner:  charettes
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by charettes):

 * needs_better_patch:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.2906c8a9136c339366d2501a31b20a6d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #24652: SimpleTestCase should prevent execution of database queries

2015-04-17 Thread Django
#24652: SimpleTestCase should prevent execution of database queries
-+-
 Reporter:  charettes|Owner:  charettes
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * stage:  Unreviewed => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.6018c0a99867db57aa5f16a5ceee62ab%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #24652: SimpleTestCase should prevent execution of database queries

2015-04-17 Thread Django
#24652: SimpleTestCase should prevent execution of database queries
-+-
 Reporter:  charettes|Owner:  charettes
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by charettes):

 > Maybe we could go with an approach where SimpleTestCase disables
 database queries unless the test class sets attribute
 allow_database_queries to True. Then the exception could tell why it isn't
 a good idea to allow database queries, but also allow users to execute
 queries if they want to do so.

 This is what [https://github.com/django/django/pull/4522 the actual
 implementation does]. I'll alter the message error to suggest setting the
 `allow_database_queries` attribute to `True` with a big warning.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.7bd9e3bcca88b1ee73ed7553f53feb45%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #24652: SimpleTestCase should prevent execution of database queries

2015-04-16 Thread Django
#24652: SimpleTestCase should prevent execution of database queries
-+-
 Reporter:  charettes|Owner:  charettes
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by akaariai):

 I'm not sure full prevention of database queries is a good idea. There are
 cases where you do want to run outside transaction control but prevent
 database flushing. The most important reasons for the latter part are that
 you want to preserve some of your dataset between test runs, and
 performance of database flushing.

 Maybe we could go with an approach where SimpleTestCase disables database
 queries unless the test class sets attribute `allow_database_queries` to
 True. Then the exception could tell why it isn't a good idea to allow
 database queries, but also allow users to execute queries if they want to
 do so.

 Another approach could be to support TransactionTestCase with
 "disable_db_flush" attribute. If you use that class, then your database
 isn't flushed pre or post run. This one is more explicit in opting in to
 the unsafe behavior. The hard part might be that all flushing must be
 disabled until all TransactionTestCases with disable_db_flush set to True
 are ran.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.ef0b9402829d0132d63da08ba6359792%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #24652: SimpleTestCase should prevent execution of database queries

2015-04-16 Thread Django
#24652: SimpleTestCase should prevent execution of database queries
-+-
 Reporter:  charettes|Owner:  charettes
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by charettes):

 * needs_better_patch:  0 => 1
 * has_patch:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.9464695ca0e2837dfc98ea80718c498d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #24652: SimpleTestCase should prevent execution of database queries

2015-04-16 Thread Django
#24652: SimpleTestCase should prevent execution of database queries
-+-
 Reporter:  charettes|Owner:  charettes
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by charettes):

 * status:  new => assigned
 * owner:  nobody => charettes


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.a2f191133511dbac213244bc17b788a2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


[Django] #24652: SimpleTestCase should prevent execution of database queries

2015-04-16 Thread Django
#24652: SimpleTestCase should prevent execution of database queries
+
   Reporter:  charettes |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  Testing framework |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 `SimpleTestCase` is a simple subclass of `unittest.TestCase` with added
 assertion methods to deal with Django related stuff such as the
 `TestClient`.

 While it's
 [https://docs.djangoproject.com/en/dev/topics/testing/tools/#simpletestcase
 documented] that `SimpleTestCase` shouldn't be used to test anything
 related to the ORM, nothing prevent users from doing it in unexpected
 ways. This can result in hard to detect test isolation issues as we have
 experienced with the Django test suite.

 I suggest to prevent the usage of the ORM during the execution of a
 `SimpleTestCase` by raising an exception pointing to the usage of
 `TestCase` (or `TransactionTestCase`) on query execution attempts.

 This will also be a good safenet for our internal usage, we should feel
 confident asking contributors to use `SimpleTestCase` where appropriate to
 avoid useless transaction wrapping.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.704acfe21e54218228e57c087bfbf393%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.