Re: [Django] #24655: Admin RelatedFieldWidgetWrapper does not build static url correctly

[Django]

#24655: Admin RelatedFieldWidgetWrapper does not build static url correctly
-+-
 Reporter:  ewhitmire|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  1.8
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"901de5fbcedf1ad04d3e47a610aa5ed1cc657cb9" 901de5f]:
 {{{
 #!CommitTicketReference repository=""
 revision="901de5fbcedf1ad04d3e47a610aa5ed1cc657cb9"
 [1.8.x] Fixed #24655 -- Fixed JavaScript path of contrib.admin's related
 field widget
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.ca9be9813c4d090f651c514b30cfbac2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24655: Admin RelatedFieldWidgetWrapper does not build static url correctly

[Django]

#24655: Admin RelatedFieldWidgetWrapper does not build static url correctly
-+-
 Reporter:  ewhitmire|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by timgraham):

 * stage:  Accepted => Ready for checkin


Comment:

 Will add release notes and commit.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.70f3eb7d4ee9414e9e762f94f5e2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24655: Admin RelatedFieldWidgetWrapper does not build static url correctly

[Django]

#24655: Admin RelatedFieldWidgetWrapper does not build static url correctly
---+
 Reporter:  ewhitmire  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  1.8
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+
Changes (by charettes):

 * needs_better_patch:  1 => 0
 * version:  master => 1.8


Comment:

 The master branch is not affected.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.61ac315efd235d5f2cf5a2b905f1bc64%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24655: Admin RelatedFieldWidgetWrapper does not build static url correctly

[Django]

#24655: Admin RelatedFieldWidgetWrapper does not build static url correctly
---+
 Reporter:  ewhitmire  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  1  |UI/UX:  0
---+
Changes (by charettes):

 * needs_better_patch:  0 => 1
 * version:  1.8 => master
 * stage:  Unreviewed => Accepted


Comment:

 Please open a new PR against master, we'll take of backporting.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.40db153107b9854bb351cdbc1b961f59%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24655: Admin RelatedFieldWidgetWrapper does not build static url correctly

[Django]

#24655: Admin RelatedFieldWidgetWrapper does not build static url correctly
---+--
 Reporter:  ewhitmire  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  1.8
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+--
Changes (by ewhitmire):

 * needs_better_patch:   => 0
 * has_patch:  0 => 1
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 Proposed fix: https://github.com/django/django/pull/4523

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.47f91f35b986c7a2a256d494784ac3ba%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #24655: Admin RelatedFieldWidgetWrapper does not build static url correctly

[Django]

#24655: Admin RelatedFieldWidgetWrapper does not build static url correctly
---+
 Reporter:  ewhitmire  |  Owner:  nobody
 Type:  Bug| Status:  new
Component:  contrib.admin  |Version:  1.8
 Severity:  Normal |   Keywords:
 Triage Stage:  Unreviewed |  Has patch:  0
Easy pickings:  1  |  UI/UX:  0
---+
 RelatedFieldWidgetWrapper requires 'admin/js/related-widget-wrapper.js'
 but doesn't pass it through the static url builder. As it is,
 django/forms/widgets.py always prepends STATIC_URL. However, this doesn't
 work when using a Storage class like S3BotoStorage that doesn't use
 STATIC_URL and results in a 404 error.

 It looks like the fix is simply to add a call to static before passing the
 url to Media.

 This functionality has changed in master so I think this only exists in
 1.8.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.a74d7dcf53a85d76c15cb77d5be84286%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.