Re: [Django] #24921: No Database objects can be created with set_autocommit(False)

[Django]

#24921: No Database objects can be created with set_autocommit(False)
-+-
 Reporter:  shabda   |Owner:  aaugustin
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Aymeric Augustin ):

 In [changeset:"425c5e40eae90bd3ee3633011ef97edb26858c94" 425c5e4]:
 {{{
 #!CommitTicketReference repository=""
 revision="425c5e40eae90bd3ee3633011ef97edb26858c94"
 [1.8.x] Fixed #24921 -- set_autocommit(False) + ORM queries.

 This commits lifts the restriction that the outermost atomic block must
 be declared with savepoint=False. This restriction was overly cautious.

 The logic that makes it safe not to create savepoints for inner blocks
 also applies to the outermost block when autocommit is disabled and a
 transaction is already active.

 This makes it possible to use the ORM after set_autocommit(False).
 Previously it didn't work because ORM write operations are protected
 with atomic(savepoint=False).

 Backport of 91e9f1c from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.24c021f2639633ea339ce227a46611f0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24921: No Database objects can be created with set_autocommit(False)

[Django]

#24921: No Database objects can be created with set_autocommit(False)
-+-
 Reporter:  shabda   |Owner:  aaugustin
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Aymeric Augustin ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"91e9f1c972842284a94097e252307ce6ed1007a1" 91e9f1c]:
 {{{
 #!CommitTicketReference repository=""
 revision="91e9f1c972842284a94097e252307ce6ed1007a1"
 Fixed #24921 -- set_autocommit(False) + ORM queries.

 This commits lifts the restriction that the outermost atomic block must
 be declared with savepoint=False. This restriction was overly cautious.

 The logic that makes it safe not to create savepoints for inner blocks
 also applies to the outermost block when autocommit is disabled and a
 transaction is already active.

 This makes it possible to use the ORM after set_autocommit(False).
 Previously it didn't work because ORM write operations are protected
 with atomic(savepoint=False).
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.b1a4b9ae41db055ae5721fcb73462913%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24921: No Database objects can be created with set_autocommit(False)

[Django]

#24921: No Database objects can be created with set_autocommit(False)
-+-
 Reporter:  shabda   |Owner:  aaugustin
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.b6f39197cf94d8fcf86cbdff25f7706a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24921: No Database objects can be created with set_autocommit(False)

[Django]

#24921: No Database objects can be created with set_autocommit(False)
-+-
 Reporter:  shabda   |Owner:  aaugustin
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by aaugustin):

 * has_patch:  0 => 1


Comment:

 After further analysis, the check that raises an exception in that case
 can simply be removed. See https://github.com/django/django/pull/5330 for
 details.

 It won't work on SQLite for the usual reason, namely
 http://bugs.python.org/issue10740.

 My original design for transaction was very stringent. Then I relaxed it,
 for instance I introduced `savepoint=False`. This is one more logical step
 in this direction.

 I'm hesitating to backport this patch to 1.8 LTS. It could be considered a
 significant problem in the transaction functionality.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.dfc823ec0c12a3c42ebb33cf4789a880%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24921: No Database objects can be created with set_autocommit(False)

[Django]

#24921: No Database objects can be created with set_autocommit(False)
-+-
 Reporter:  shabda   |Owner:  aaugustin
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by aaugustin):

 Yes that's what I meant... I edited my comment.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.56acfa86e99fc2e9ae06be60f706fc15%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24921: No Database objects can be created with set_autocommit(False)

[Django]

#24921: No Database objects can be created with set_autocommit(False)
-+-
 Reporter:  shabda   |Owner:  aaugustin
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by carljm):

 Replying to [comment:10 aaugustin]:

 > That's backwards incompatible. It just makes Django cope with a
 situation where it would previously rais `TransactionManagementError`.

 Correct me if I'm wrong, Aymeric, but I believe you meant to say "that's
 backwards compatible" here?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.573aa10c02212a643ff0ddd59e5f1a74%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24921: No Database objects can be created with set_autocommit(False)

[Django]

#24921: No Database objects can be created with set_autocommit(False)
-+-
 Reporter:  shabda   |Owner:  aaugustin
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by aaugustin):

 Indeed, some compatibility code added in Django 1.6 to ease the
 introduction of the new transaction management system and immediately
 deprecated was removed in Diango 1.8. That code used to make the scenario
 you're describing not crash.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.0e2228e7a97227d8f99069237cb4baef%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24921: No Database objects can be created with set_autocommit(False)

[Django]

#24921: No Database objects can be created with set_autocommit(False)
-+-
 Reporter:  shabda   |Owner:  aaugustin
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by shabda):

 This looks to be a regression in 1.8

 1.7 https://gist.github.com/shabda/38803b1198172091e976 (Works)
 1.8 https://gist.github.com/shabda/e69bc239cac805a970cd (Fails)

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.92264e53a33298abbab9ca0f536b76e8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24921: No Database objects can be created with set_autocommit(False)

[Django]

#24921: No Database objects can be created with set_autocommit(False)
-+-
 Reporter:  shabda   |Owner:  aaugustin
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by aaugustin):

 * owner:  shabda => aaugustin
 * status:  new => assigned


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.09f85e0b3bbd3b682fb824ad8fd4fb36%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24921: No Database objects can be created with set_autocommit(False)

[Django]

#24921: No Database objects can be created with set_autocommit(False)
-+-
 Reporter:  shabda   |Owner:  shabda
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by aaugustin):

 `Atomic` is a context-manager / decorator in order to enforce proper
 matching between `__enter__` and `__exit__` calls. If the calls aren't
 balanced properly, data loss will happen, and it may be hard to diagnose.
 That's why I've historically rejected the idea of exposing this methods
 through public APIs.

 Django uses the hack carljm suggests in its own test setUp / tearDown
 functions. See `TestCase._enter_atomics` and `_rollback_atomics`. That's
 exactly the OP's use case, so I suggest using that as a stop gap solution.
 Don't forget to call `set_rollback(True)` before exiting, since you want a
 rollback.

 For the ORM to function with autocommit off, we should change the
 `savepoint` parameter of `atomic` to add a third-value, `None` (three-
 valued booleans, grrr), which would mean "automatic" and be implemented as
 follows:

 if self.savepoint is None:
 self.savepoint = not connection.in_atomic_block and not
 connection.get_autocommit()

 In other words, it would mean "no savepoint, unless I'm the outermost
 atomic block in a connection that is already in a transaction, which means
 I can't use a plain transaction"

 That's backwards incompatible. It just makes Django cope with a situation
 where it would previously rais `TransactionManagementError`.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.5d3bef88eef685f809f7c2cc75d73796%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24921: No Database objects can be created with set_autocommit(False)

[Django]

#24921: No Database objects can be created with set_autocommit(False)
-+-
 Reporter:  shabda   |Owner:  shabda
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by shaib):

 * type:  Uncategorized => Bug
 * component:  Uncategorized => Database layer (models, ORM)
 * stage:  Unreviewed => Accepted


Comment:

 Accepting because the original analysis is correct and @carljm's comments
 are spot on.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.6d26171e323064fc1a6fee93ba1eb0fd%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24921: No Database objects can be created with set_autocommit(False)

[Django]

#24921: No Database objects can be created with set_autocommit(False)
---+--
 Reporter:  shabda |Owner:  shabda
 Type:  Uncategorized  |   Status:  new
Component:  Uncategorized  |  Version:  1.8
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by carljm):

 I think you could probably actually use `transaction.atomic`, if lettuce
 gives you a place to stash some state between the hooks. You'd just call
 it, get an `Atomic` object back, and then manually call its `__enter__`
 and `__exit__` methods.

 It seems to me that there is a valid use case here ("manual transaction
 control when the code structure, probably because of some other library,
 won't allow for a context manager or or decorator as the code idiom"), and
 I don't think the workaround I've suggested above is really adequate API
 for that use case.

 Currently our documentation strongly suggests that the right approach for
 this case is `set_autocommit(False)` followed by commit or rollback. If
 the ORM is completely nonfunctional in that scenario (not just "doesn't
 handle transactions for you", but completely unusable), then I do think
 that's a problem that should be fixed.

 I guess it could be that the right fix is a new higher-level API on a
 similar level to `atomic`, but that is usable as separate function calls
 instead of a context manager or decorator.

 But it also seems to me that the ORM _should_ be able to basically
 function with autocommit off (even if it handles transactions
 unpredictably), and that this bug that prevents it from working does not
 look unsolvable. If it turns out that we can't fix it, then I definitely
 think we need _much_ stronger warnings in the docs (along the lines of
 "these APIs documented below are only usable with raw SQL, you cannot use
 the ORM at all"), and I think we probably also should suggest a reasonable
 alternative approach for non-context-manager transaction control with a
 usable ORM.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.af26e1321e39e4e1b5e33a37989b7219%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24921: No Database objects can be created with set_autocommit(False)

[Django]

#24921: No Database objects can be created with set_autocommit(False)
---+--
 Reporter:  shabda |Owner:  shabda
 Type:  Uncategorized  |   Status:  new
Component:  Uncategorized  |  Version:  1.8
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by shabda):

 So here is the use case:

 Lettuce, the BDD lib, doesn't wrap each scenario in transaction. I want to
 keep each scenario independent. lettuce provides two hooks
 before_each_scenario and after_each_scenario

 http://lettuce.it/reference/terrain.html#before-each-scenario

 In before_each_scenario I want to set_autocommit(False) and in
 after_each_scenario I want to do a transaction.rollback. I can't use the
 atomic decorator or context as the step functions are evaluated inside a
 third method.

 I believe this can be achieved by using named savepoints, but based on the
 docs the first way looked more straightforward.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.67d766bab49cc1a1a6d69cfac11555b1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24921: No Database objects can be created with set_autocommit(False)

[Django]

#24921: No Database objects can be created with set_autocommit(False)
---+--
 Reporter:  shabda |Owner:  shabda
 Type:  Uncategorized  |   Status:  new
Component:  Uncategorized  |  Version:  1.8
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by aaugustin):

 I'm not opposed to docs changes clarifying that you really shouldn't mess
 with autocommit.

 I still don't know why you were trying to do this.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.9666ae6c81dc92fe4d52eb86300dccf5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24921: No Database objects can be created with set_autocommit(False)

[Django]

#24921: No Database objects can be created with set_autocommit(False)
---+--
 Reporter:  shabda |Owner:  shabda
 Type:  Uncategorized  |   Status:  new
Component:  Uncategorized  |  Version:  1.8
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by shabda):

 * status:  closed => new
 * resolution:  invalid =>


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.58aa2090ef176ef3bd089d98dbae23f7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24921: No Database objects can be created with set_autocommit(False)

[Django]

#24921: No Database objects can be created with set_autocommit(False)
---+--
 Reporter:  shabda |Owner:  shabda
 Type:  Uncategorized  |   Status:  closed
Component:  Uncategorized  |  Version:  1.8
 Severity:  Normal |   Resolution:  invalid
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by shabda):

 To clarify: If this an expected behaviour, then this warning "Once you
 turn autocommit off, you get the default behavior of your database
 adapter, and Django won't help you." is not strong enough and it should be
 calrified that usual ORM methods will fail.

 As the docs stand now, it seems to imply that , you get the default
 transaction behavior, but can use the ORM. I think a doc or code fix is
 needed, so I am going to reopen the ticket.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.4942f96ec0fd74353c66f5903e1da0cc%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24921: No Database objects can be created with set_autocommit(False)

[Django]

#24921: No Database objects can be created with set_autocommit(False)
---+--
 Reporter:  shabda |Owner:  shabda
 Type:  Uncategorized  |   Status:  closed
Component:  Uncategorized  |  Version:  1.8
 Severity:  Normal |   Resolution:  invalid
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by shabda):

 Things I am doing

 transaction.set_autocommit(False)
 ModelClass.object.create(...)

 I am not sure why this should fail. The PR
 https://github.com/django/django/pull/4755 has a failing minimal test
 case.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.59df52058991df98fe2ee91d352c98e9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24921: No Database objects can be created with set_autocommit(False)

[Django]

#24921: No Database objects can be created with set_autocommit(False)
---+--
 Reporter:  shabda |Owner:  shabda
 Type:  Uncategorized  |   Status:  closed
Component:  Uncategorized  |  Version:  1.8
 Severity:  Normal |   Resolution:  invalid
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by aaugustin):

 * status:  assigned => closed
 * resolution:   => invalid


Comment:

 The ORM assumes that Django has control of the database connection,
 including control of its transactional behavior.

 The docs make it pretty clear that you're on your own in that case:

 > Once you turn autocommit off, you get the default behavior of your
 database adapter, and Django won't help you.

 Other than doing complicated things in `cursor.execute()` calls, I don't
 see a use case for disabling autocommit.

 Can you clarify what you're trying to do?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.c08af44b0016bda7d4c7a3e60d986dc3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24921: No Database objects can be created with set_autocommit(False)

[Django]

#24921: No Database objects can be created with set_autocommit(False)
---+--
 Reporter:  shabda |Owner:  shabda
 Type:  Uncategorized  |   Status:  assigned
Component:  Uncategorized  |  Version:  1.8
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by shabda):

 * owner:  nobody => shabda
 * needs_better_patch:   => 0
 * status:  new => assigned
 * needs_tests:   => 0
 * needs_docs:   => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.d95aeff0993205545e0c863ef39544ac%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #24921: No Database objects can be created with set_autocommit(False)

[Django]

#24921: No Database objects can be created with set_autocommit(False)
---+
 Reporter:  shabda |  Owner:  nobody
 Type:  Uncategorized  | Status:  new
Component:  Uncategorized  |Version:  1.8
 Severity:  Normal |   Keywords:
 Triage Stage:  Unreviewed |  Has patch:  0
Easy pickings:  0  |  UI/UX:  0
---+
 If you call transaction.set_autocommit(False),

 Any further objects creation will fail, because

 
https://github.com/django/django/blob/04e8d890aec8e996d56856164a27a6a76057/django/db/models/base.py#L699

 This line tries an atomic with savepoint=False, which raises an exception
 in no autocommit mode.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/049.34055039b0326b34bef6aba931182e44%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.