Re: [Django] #24941: Add get_exclude() hook to BaseModelAdmin

[Django]

#24941: Add get_exclude() hook to BaseModelAdmin
--+---
 Reporter:  Peter J. Farrell  |Owner:  Zach Borboa
 Type:  New feature   |   Status:  closed
Component:  contrib.admin |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+---
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"bf91be83d56d70181de807a5e8d22679cf63a52f" bf91be83]:
 {{{
 #!CommitTicketReference repository=""
 revision="bf91be83d56d70181de807a5e8d22679cf63a52f"
 Fixed #24941 -- Added ModelAdmin.get_exclude().

 Thanks Ola Sitarska for the initial patch.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.2ea75091f565e01b62f52c140396309a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24941: Add get_exclude() hook to BaseModelAdmin

[Django]

#24941: Add get_exclude() hook to BaseModelAdmin
--+---
 Reporter:  Peter J. Farrell  |Owner:  Zach Borboa
 Type:  New feature   |   Status:  assigned
Component:  contrib.admin |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+---
Changes (by Tim Graham):

 * needs_tests:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.613fc64acd0eb3765c18563567b95e73%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24941: Add get_exclude() hook to BaseModelAdmin

[Django]

#24941: Add get_exclude() hook to BaseModelAdmin
--+---
 Reporter:  Peter J. Farrell  |Owner:  Zach Borboa
 Type:  New feature   |   Status:  assigned
Component:  contrib.admin |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  1 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+---
Changes (by Tim Graham):

 * needs_tests:  0 => 1


Comment:

 As noted on the PR, tests for the `ModelAdmin.get_formsets()` changes are
 missing.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.57648c5925eefcf89beedc145be9dad4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24941: Add get_exclude() hook to BaseModelAdmin

[Django]

#24941: Add get_exclude() hook to BaseModelAdmin
--+---
 Reporter:  Peter J. Farrell  |Owner:  Zach Borboa
 Type:  New feature   |   Status:  assigned
Component:  contrib.admin |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+---
Changes (by Tim Graham):

 * needs_better_patch:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.aba1d75ca7a330a26f97cf4993999e29%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24941: Add get_exclude() hook to BaseModelAdmin

[Django]

#24941: Add get_exclude() hook to BaseModelAdmin
--+---
 Reporter:  Peter J. Farrell  |Owner:  Zach Borboa
 Type:  New feature   |   Status:  assigned
Component:  contrib.admin |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+---
Changes (by Tim Graham):

 * needs_better_patch:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.8bfabb79a0841dd980d1d5d1f6853bbd%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24941: Add get_exclude() hook to BaseModelAdmin

[Django]

#24941: Add get_exclude() hook to BaseModelAdmin
--+---
 Reporter:  Peter J. Farrell  |Owner:  Zach Borboa
 Type:  New feature   |   Status:  assigned
Component:  contrib.admin |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+---
Changes (by Zach Borboa):

 * owner:  Ola Sitarska => Zach Borboa
 * needs_better_patch:  1 => 0


Comment:

 [https://github.com/django/django/pull/7252 PR]

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.bc93fec1f7de3683746e547023f9b133%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24941: Add get_exclude() hook to BaseModelAdmin

[Django]

#24941: Add get_exclude() hook to BaseModelAdmin
---+---
 Reporter:  peterfarrell   |Owner:  olasitarska
 Type:  New feature|   Status:  assigned
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+---
Changes (by zborboa-g):

 * cc: zborboa@… (added)


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.cff14a2ec8846b44f68da06e73f52743%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24941: Add get_exclude() hook to BaseModelAdmin

[Django]

#24941: Add get_exclude() hook to BaseModelAdmin
---+---
 Reporter:  peterfarrell   |Owner:  olasitarska
 Type:  New feature|   Status:  assigned
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+---
Changes (by timgraham):

 * needs_better_patch:  0 => 1


Comment:

 I left comments for improvement on the pull request.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.e2b880a23ac79deb07888ee60455cdf7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24941: Add get_exclude() hook to BaseModelAdmin

[Django]

#24941: Add get_exclude() hook to BaseModelAdmin
---+---
 Reporter:  peterfarrell   |Owner:  olasitarska
 Type:  New feature|   Status:  assigned
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+---
Changes (by olasitarska):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/5214 PR]

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.4830ba47a93f680c557358be24b7e7af%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24941: Add get_exclude() hook to BaseModelAdmin

[Django]

#24941: Add get_exclude() hook to BaseModelAdmin
---+---
 Reporter:  peterfarrell   |Owner:  olasitarska
 Type:  New feature|   Status:  assigned
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+---
Changes (by olasitarska):

 * owner:  SujaySKumar => olasitarska
 * has_patch:  1 => 0
 * needs_tests:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.8151f0660c9c38a0a8a3cd30cbfae5e7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24941: Add get_exclude() hook to BaseModelAdmin

[Django]

#24941: Add get_exclude() hook to BaseModelAdmin
---+---
 Reporter:  peterfarrell   |Owner:  SujaySKumar
 Type:  New feature|   Status:  assigned
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+---
Changes (by SujaySKumar):

 * has_patch:  0 => 1
 * needs_tests:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.841a5541daab6d8f5458a518f66d1a01%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24941: Add get_exclude() hook to BaseModelAdmin

[Django]

#24941: Add get_exclude() hook to BaseModelAdmin
---+---
 Reporter:  peterfarrell   |Owner:  SujaySKumar
 Type:  New feature|   Status:  assigned
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+---
Changes (by SujaySKumar):

 * owner:  nobody => SujaySKumar
 * status:  new => assigned


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.95c4b9db34887e7fefa3b7d48d651c8c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24941: Add get_exclude() hook to BaseModelAdmin

[Django]

#24941: Add get_exclude() hook to BaseModelAdmin
---+
 Reporter:  peterfarrell   |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by timgraham):

 * stage:  Unreviewed => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.2476fa02b6efba6fc88bc072699c824e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24941: Add get_exclude() hook to BaseModelAdmin

[Django]

#24941: Add get_exclude() hook to BaseModelAdmin
---+--
 Reporter:  peterfarrell   |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by timgraham):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 [https://groups.google.com/d/topic/django-
 developers/WrnhmTyLHuY/discussion thread on django-developers].

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.e949709fd7e39219f2742e1b6265d120%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #24941: Add get_exclude() hook to BaseModelAdmin

[Django]

#24941: Add get_exclude() hook to BaseModelAdmin
---+
 Reporter:  peterfarrell   |  Owner:  nobody
 Type:  New feature| Status:  new
Component:  contrib.admin  |Version:  master
 Severity:  Normal |   Keywords:
 Triage Stage:  Unreviewed |  Has patch:  0
Easy pickings:  0  |  UI/UX:  0
---+
 TL;DR: Most attributes in the admin have get_XXX() hooks however exclude
 is missing this functionality. This ticket is to add get_exclude() hook to
 so it matches the same pattern of hooks the rest of the admin has.

 I have a patch in the works if accepted.
 --

 We're building out a custom admin base for CleanerVersion in which we
 subclass ModelAdmin.  We needed to dynamically get the developer's choices
 in exclude and add in our own without overwriting the developer's settings
 in their concrete class.  Just about all other attributes have their own
 hook method in order to get at attribute values, but exclude seems to be
 the only one that is doesn't follow this pattern.

 It is possible to "mock" this without having to override bunch of other
 methods by using a @property descriptor, but this causes the admin checks
 to throw an error when performing the check on exclude.  This is monkey
 patched by subclassing the admin checks class and overriding the check for
 exclude.  Less than ideal.

 Simple solution is add an get_exclude() method to the BaseModelAdmin so it
 offers the same hook methods that are available for list_display, fields,
 etc.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/055.9d4ed966da7da1f9169200d53fbedca1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.