Re: [Django] #24949: Force to_field and probably other fields to unicode during migration deconstruction

[Django]

#24949: Force to_field and probably other fields to unicode during migration
deconstruction
---+
 Reporter:  Markus Holtermann  |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Migrations |  Version:  1.7
 Severity:  Normal |   Resolution:  wontfix
 Keywords:  py2| Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by Tim Graham):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 Closing due to the end of Python 2 support in master in a couple weeks.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.76a3b2721e68b91a8bb24e2a6206234c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24949: Force to_field and probably other fields to unicode during migration deconstruction

[Django]

#24949: Force to_field and probably other fields to unicode during migration
deconstruction
+
 Reporter:  MarkusH |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  Migrations  |  Version:  1.7
 Severity:  Normal  |   Resolution:
 Keywords:  py2 | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+
Changes (by timgraham):

 * keywords:   => py2


Comment:

 If someone doesn't propose a patch for Django 1.11 (last version to
 support Python 2) we can likely close the ticket.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.d0765fca583449c2dea90a278cd31403%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24949: Force to_field and probably other fields to unicode during migration deconstruction

[Django]

#24949: Force to_field and probably other fields to unicode during migration
deconstruction
+
 Reporter:  MarkusH |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  Migrations  |  Version:  1.7
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+

Comment (by patrys):

 It's also the case if your app does not have an `AppConfig` file and your
 `INSTALLED_APPS` is a list of byte strings.

 As I've noted in #25906, I'm not sure working around problems like this at
 Django level is worth it. It will add a lot of seemingly no-op code that
 in edge cases could silently cover entire classes of unrelated problems.

 I think it would be a sane thing for Django to warn about things being the
 wrong type and do nothing about it. Affected apps and projects will
 continue to work in Python 2 and fail in Python 3 but they do that already
 (they may not know or care). A warning should give enough information to
 fix the problem (or file a bug with app's upstream).

 I was affected and it took me a couple of months to find out. Our entire
 test suite passed with flying colours and things only broke when squashing
 migrations. With a proper validator warning it becomes a five minute fix.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.ee243ee3af2642953aa6cdd55beb2b64%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24949: Force to_field and probably other fields to unicode during migration deconstruction

[Django]

#24949: Force to_field and probably other fields to unicode during migration
deconstruction
+
 Reporter:  MarkusH |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  Migrations  |  Version:  1.7
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+

Comment (by timgraham):

 #25906 notes that this can also affect `AppConfig.app_name` when squashing
 migrations.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.8459d947bf584d20cd905f4cac79bf19%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24949: Force to_field and probably other fields to unicode during migration deconstruction

[Django]

#24949: Force to_field and probably other fields to unicode during migration
deconstruction
+
 Reporter:  MarkusH |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  Migrations  |  Version:  1.7
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+

Comment (by claudep):

 As for me, I'd be in favor of Markus proposal.
 @tim, of course, the documented solution works, but in practice, many
 people are bitten by this (as they obviously don't begin by reading the
 docs) and I often find myself manually removing b prefixes from migration
 files.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.2890187df971805b06b0b26a2ef27527%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24949: Force to_field and probably other fields to unicode during migration deconstruction

[Django]

#24949: Force to_field and probably other fields to unicode during migration
deconstruction
+
 Reporter:  MarkusH |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  Migrations  |  Version:  1.7
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+

Comment (by timgraham):

 Did we decide the [https://docs.djangoproject.com/en/1.8/topics/migrations
 /#supporting-python-2-and-3 documented solution] doesn't work or merely
 that it's inconvenient?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.e1b8a2c335b2ae175d7578e6c9d4fc6a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24949: Force to_field and probably other fields to unicode during migration deconstruction

[Django]

#24949: Force to_field and probably other fields to unicode during migration
deconstruction
+
 Reporter:  MarkusH |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  Migrations  |  Version:  1.7
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+
Changes (by MarkusH):

 * stage:  Unreviewed => Accepted


Comment:

 After a brief talk with Andrew we agreed on converting all string
 attributes to unicode (`force_text()`) in the fields' `__init__()`
 methods. That should fix the issue and possibly other issues in the
 future. There are a few things to consider, though:

 * For `BinaryField` we need to keep the byte string, though for
 `CharField` and `TextField` it should be unicode.

 * The `verbose_name` and `help_text` attributes are often used with
 `(u)gettext_lazy()`. Although I'm lacking a real use case for
 `gettext_lazy()` in general, we need to find a way to force these values
 to unicode once they are evaluated.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.02d97379114c69b1d379157ed98cf315%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #24949: Force to_field and probably other fields to unicode during migration deconstruction

[Django]

#24949: Force to_field and probably other fields to unicode during migration
deconstruction
--+
   Reporter:  MarkusH |  Owner:  nobody
   Type:  Bug | Status:  new
  Component:  Migrations  |Version:  1.7
   Severity:  Normal  |   Keywords:
   Triage Stage:  Unreviewed  |  Has patch:  0
Needs documentation:  0   |Needs tests:  0
Patch needs improvement:  0   |  Easy pickings:  0
  UI/UX:  0   |
--+
 `to_field` and likely many other field attributes are not forced to
 unicode during migration creation. This is the same problem as reported in
 #23455.

 We should figure out a way how to fix this issue once and for all.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/050.6ef631f2ad862393b1270388ad9f64f2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.