Re: [Django] #25172: System checks don't respect database routers

[Django]

#25172: System checks don't respect database routers
-+-
 Reporter:  delinhabit   |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Core (System |  Version:  1.7
  checks)|
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  system-checks| Triage Stage:  Ready for
  multi-database |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"0cc059cd104cdb70340bd08e597d403d80dc42a6" 0cc059c]:
 {{{
 #!CommitTicketReference repository=""
 revision="0cc059cd104cdb70340bd08e597d403d80dc42a6"
 Fixed #25172 -- Fixed check framework to work with multiple databases.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.bef2c122c9095410f5f7a3147fb163f0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25172: System checks don't respect database routers

[Django]

#25172: System checks don't respect database routers
-+-
 Reporter:  delinhabit   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (System |  Version:  1.7
  checks)|
 Severity:  Normal   |   Resolution:
 Keywords:  system-checks| Triage Stage:  Ready for
  multi-database |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by delinhabit):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.abf7edc906a9340d87d8798745038a2c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25172: System checks don't respect database routers

[Django]

#25172: System checks don't respect database routers
-+-
 Reporter:  delinhabit   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (System |  Version:  1.7
  checks)|
 Severity:  Normal   |   Resolution:
 Keywords:  system-checks| Triage Stage:  Accepted
  multi-database |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * needs_better_patch:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.3176b3683c3a9fdfc361c49a33971cb3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25172: System checks don't respect database routers

[Django]

#25172: System checks don't respect database routers
-+-
 Reporter:  delinhabit   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (System |  Version:  1.7
  checks)|
 Severity:  Normal   |   Resolution:
 Keywords:  system-checks| Triage Stage:  Accepted
  multi-database |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by delinhabit):

 Oh, didn't know that. It's definitely easier to work with pull requests
 instead of patches.

 Thanks!

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.ff964a8a29c0bd333607758ef511292f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25172: System checks don't respect database routers

[Django]

#25172: System checks don't respect database routers
-+-
 Reporter:  delinhabit   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (System |  Version:  1.7
  checks)|
 Severity:  Normal   |   Resolution:
 Keywords:  system-checks| Triage Stage:  Accepted
  multi-database |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * needs_better_patch:  1 => 0


Comment:

 FYI, there's no need to submit a pull request *and* attach the patch to
 the ticket.

 However, please do uncheck "Patch needs improvement" after updating the
 pull request so the ticket appears in the review queue.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.27499babbe358258ca4ab114f4c28cf4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25172: System checks don't respect database routers

[Django]

#25172: System checks don't respect database routers
-+-
 Reporter:  delinhabit   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (System |  Version:  1.7
  checks)|
 Severity:  Normal   |   Resolution:
 Keywords:  system-checks| Triage Stage:  Accepted
  multi-database |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by delinhabit):

 * Attachment "multi_db_checks.diff" added.

 Fix the issue and add regression tests

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.b175e0340be2341eb2103d54adb6f64d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25172: System checks don't respect database routers

[Django]

#25172: System checks don't respect database routers
-+-
 Reporter:  delinhabit   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (System |  Version:  1.7
  checks)|
 Severity:  Normal   |   Resolution:
 Keywords:  system-checks| Triage Stage:  Accepted
  multi-database |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by delinhabit):

 * Attachment "multi_db_checks.diff" added.

 Fix the issue and add regression tests

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.5219cb8101ca1992248ba7b60f3d6aad%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25172: System checks don't respect database routers

[Django]

#25172: System checks don't respect database routers
-+-
 Reporter:  delinhabit   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (System |  Version:  1.7
  checks)|
 Severity:  Normal   |   Resolution:
 Keywords:  system-checks| Triage Stage:  Accepted
  multi-database |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * needs_better_patch:  0 => 1


Comment:

 Some test failures need to be addressed.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.877ab8e8790e140944a790d6f958a771%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25172: System checks don't respect database routers

[Django]

#25172: System checks don't respect database routers
-+-
 Reporter:  delinhabit   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (System |  Version:  1.7
  checks)|
 Severity:  Normal   |   Resolution:
 Keywords:  system-checks| Triage Stage:  Accepted
  multi-database |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * has_patch:  0 => 1


Comment:

 Great. By the way, don't forget to check "Has patch" so the ticket appears
 in the review queue.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.a6fac8831842cec7b86f60a7c7d92d38%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25172: System checks don't respect database routers

[Django]

#25172: System checks don't respect database routers
-+-
 Reporter:  delinhabit   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (System |  Version:  1.7
  checks)|
 Severity:  Normal   |   Resolution:
 Keywords:  system-checks| Triage Stage:  Accepted
  multi-database |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by delinhabit):

 Sure. Here it is: https://github.com/django/django/pull/5084

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.9ef07d1492229c2995f61504fe804487%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25172: System checks don't respect database routers

[Django]

#25172: System checks don't respect database routers
-+-
 Reporter:  delinhabit   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (System |  Version:  1.7
  checks)|
 Severity:  Normal   |   Resolution:
 Keywords:  system-checks| Triage Stage:  Accepted
  multi-database |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by timgraham):

 Are you able to open a pull request? That makes review easier.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.f31c2796b96e5cafe98c51d0bfc1b1b3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25172: System checks don't respect database routers

[Django]

#25172: System checks don't respect database routers
-+-
 Reporter:  delinhabit   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (System |  Version:  1.7
  checks)|
 Severity:  Normal   |   Resolution:
 Keywords:  system-checks| Triage Stage:  Accepted
  multi-database |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by delinhabit):

 The patch was created against master.

 If we decide to also include a fix in the next 1.7.x bugfix release, I
 think it won't work as it is, because of the signature change of the
 `allow_migrate` method.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.172228cdf23aedf11f0b55023ae45f19%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25172: System checks don't respect database routers

[Django]

#25172: System checks don't respect database routers
-+-
 Reporter:  delinhabit   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (System |  Version:  1.7
  checks)|
 Severity:  Normal   |   Resolution:
 Keywords:  system-checks| Triage Stage:  Accepted
  multi-database |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by delinhabit):

 * Attachment "multi_db_checks.diff" added.

 Fix the issue and add regression tests

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.2490f080d728470d3fe143f15414a940%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25172: System checks don't respect database routers

[Django]

#25172: System checks don't respect database routers
-+-
 Reporter:  delinhabit   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (System |  Version:  1.7
  checks)|
 Severity:  Normal   |   Resolution:
 Keywords:  system-checks| Triage Stage:  Accepted
  multi-database |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by timgraham):

 If it works, great! For a test, I would create a new file
 `test/check_framework/test_multi_db.py` and write a custom database router
 based on the default/other databases aliases so that the checks are only
 run on one of the databases and then use mock to verify which connection's
 validation methods are called. Let me know if you run into trouble. Not
 positive that will work, but that would be the direction I'd try.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.5ae6709b79cf97cc625ec9c75ff6b458%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25172: System checks don't respect database routers

[Django]

#25172: System checks don't respect database routers
-+-
 Reporter:  delinhabit   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (System |  Version:  1.7
  checks)|
 Severity:  Normal   |   Resolution:
 Keywords:  system-checks| Triage Stage:  Accepted
  multi-database |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by delinhabit):

 * Attachment "multi_db_checks.diff" added.

 An attempt to fix the issues (patch not complete, requires tests)

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.daf063d85bde05864e80e5a19cd127ed%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25172: System checks don't respect database routers (was: System check is failing on multi-database setup with different backends)

[Django]

#25172: System checks don't respect database routers
-+-
 Reporter:  delinhabit   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (System |  Version:  1.7
  checks)|
 Severity:  Normal   |   Resolution:
 Keywords:  system-checks| Triage Stage:  Accepted
  multi-database |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0
 * type:  Uncategorized => Bug
 * stage:  Unreviewed => Accepted


Comment:

 I think the code for `_check_backend_specific_checks()` would be roughly
 like this:
 {{{
 from django.db import connections
 for db in connections:
if allow_migrate(...):
   db.validation.check_field(self, **kwargs)
 }}}
 Let's get some working code and then we can talk about how to test this. I
 guess it might involve mocking `connections` to have two different
 databases as we don't run the tests against two different databases on CI
 and getting that to work might not be feasible.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.06955cb11a6095167fd0104e8d2dfe9f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.