Re: [Django] #25437: Translation of DEFAULT_FROM_EMAIL not working

[Django]

#25437: Translation of DEFAULT_FROM_EMAIL not working
+-
 Reporter:  maciej-pawlisz  |Owner:
 Type:  Bug |   Status:  closed
Component:  Core (Mail) |  Version:  1.7
 Severity:  Normal  |   Resolution:  duplicate
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+-
Changes (by tam0407):

 * status:  new => closed
 * resolution:   => duplicate


Comment:

 Duplicate with #24416

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.eccf47aad74f9707ce7e0fd6ad065f63%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25437: Translation of DEFAULT_FROM_EMAIL not working

[Django]

#25437: Translation of DEFAULT_FROM_EMAIL not working
+
 Reporter:  maciej-pawlisz  |Owner:
 Type:  Bug |   Status:  new
Component:  Core (Mail) |  Version:  1.7
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+

Comment (by claudep):

 My guess of the use case was that the from email depends on the current
 language, so when the user answers to the email, it is automatically sent
 to the right language-dependent contact point.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.8669cc7964165a2e418c623c0ea6a89c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25437: Translation of DEFAULT_FROM_EMAIL not working

[Django]

#25437: Translation of DEFAULT_FROM_EMAIL not working
+
 Reporter:  maciej-pawlisz  |Owner:
 Type:  Bug |   Status:  new
Component:  Core (Mail) |  Version:  1.7
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+

Comment (by awwester):

 why would the `DEFAULT_FROM_EMAIL` be translated (it's an email address)?
 Is there some other case which is causing this error as well or am I
 missing something?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.b40ab2576b8a6a9cc36a9bf41160c318%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25437: Translation of DEFAULT_FROM_EMAIL not working

[Django]

#25437: Translation of DEFAULT_FROM_EMAIL not working
+
 Reporter:  maciej-pawlisz  |Owner:
 Type:  Bug |   Status:  new
Component:  Core (Mail) |  Version:  1.7
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+
Changes (by andersonresende):

 * owner:  andersonresende =>
 * status:  assigned => new


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.1adafe7bb46487105260098113a89dc4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25437: Translation of DEFAULT_FROM_EMAIL not working

[Django]

#25437: Translation of DEFAULT_FROM_EMAIL not working
-+-
 Reporter:  maciej-pawlisz   |Owner:
 |  andersonresende
 Type:  Bug  |   Status:  assigned
Component:  Core (Mail)  |  Version:  1.7
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by andersonresende):

 * owner:  nobody => andersonresende
 * status:  new => assigned


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.8a3ea80032199036afe70e4e69bbf789%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25437: Translation of DEFAULT_FROM_EMAIL not working

[Django]

#25437: Translation of DEFAULT_FROM_EMAIL not working
+
 Reporter:  maciej-pawlisz  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  Core (Mail) |  Version:  1.7
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+
Changes (by claudep):

 * needs_docs:   => 0
 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


Comment:

 I'ts a bit of a corner case to translate en email address, but this
 shouldn't be so hard to support, so any proposed fix is welcome.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.0dec5abc6b87f368f18bd1c16eb0e7ca%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #25437: Translation of DEFAULT_FROM_EMAIL not working

[Django]

#25437: Translation of DEFAULT_FROM_EMAIL not working
+
 Reporter:  maciej-pawlisz  |  Owner:  nobody
 Type:  Bug | Status:  new
Component:  Core (Mail) |Version:  1.7
 Severity:  Normal  |   Keywords:
 Triage Stage:  Unreviewed  |  Has patch:  0
Easy pickings:  0   |  UI/UX:  0
+
 I tried to translate `DEFAULT_FROM_EMAIL` using `ugettext_lazy`.
 Unfortunately it didn't work resulting in a traceback:
 {{{
   File "C:\Python27\lib\site-packages\django\core\mail\message.py", line
 276, in send
 return self.get_connection(fail_silently).send_messages([self])
   File "C:\Python27\lib\site-packages\django\core\mail\backends\smtp.py",
 line 94, in send_messages
 sent = self._send(message)
   File "C:\Python27\lib\site-packages\django\core\mail\backends\smtp.py",
 line 105, in _send
 from_email = sanitize_address(email_message.from_email,
 email_message.encoding)
   File "C:\Python27\lib\site-packages\django\core\mail\message.py", line
 104, in sanitize_address
 nm, addr = addr
 ValueError: too many values to unpack
 }}}

 I think that there is a bug in `sanitize_address`:

 {{{
 def sanitize_address(addr, encoding):
 if isinstance(addr, six.string_types):
 addr = parseaddr(force_text(addr))
 nm, addr = addr
 }}}
 `parseaddr` is never called because addr is not a `six.string_types`, but
 a `django.utils.functional.__proxy__`. `force_text` should be called
 before that check or if condition should be different, ie:
 {{{
   if not isinstance(addr,(tuple,list)):
 addr = parseaddr(force_text(addr))
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/057.4713c10356c3139a8756746f79826cb0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.