Re: [Django] #25686: Database router without "allow_migrate" method raises exception

[Django]

#25686: Database router without "allow_migrate" method raises exception
-+-
 Reporter:  jcugat   |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  allow_migrate| Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"6858bf758ccf1cd6ce46f3fc0b547f52cd7339db" 6858bf7]:
 {{{
 #!CommitTicketReference repository=""
 revision="6858bf758ccf1cd6ce46f3fc0b547f52cd7339db"
 [1.9.x] Refs #25686 -- Forwardported 1.8.7 release note.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.6ca2fdde686a106eada7de6a00af08d6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25686: Database router without "allow_migrate" method raises exception

[Django]

#25686: Database router without "allow_migrate" method raises exception
-+-
 Reporter:  jcugat   |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  allow_migrate| Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"c6da4b0c687e9a0d1661e9a310f703b30c4a0988" c6da4b0c]:
 {{{
 #!CommitTicketReference repository=""
 revision="c6da4b0c687e9a0d1661e9a310f703b30c4a0988"
 Refs #25686 -- Forwardported 1.8.7 release note.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.983e1b10ca09cda0d7b25ebec3b32743%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25686: Database router without "allow_migrate" method raises exception

[Django]

#25686: Database router without "allow_migrate" method raises exception
-+-
 Reporter:  jcugat   |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  allow_migrate| Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"a42c5376e764712d8ff4a1f9dd3c2d5537722288" a42c537]:
 {{{
 #!CommitTicketReference repository=""
 revision="a42c5376e764712d8ff4a1f9dd3c2d5537722288"
 [1.8.x] Fixed #25686 -- Fixed crash on routers without an allow_migrate()
 method.

 Thanks Simon Charette for review.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.3492adb342c3d12e2d66bdd88cd2ece0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25686: Database router without "allow_migrate" method raises exception

[Django]

#25686: Database router without "allow_migrate" method raises exception
-+-
 Reporter:  jcugat   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:  allow_migrate| Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by charettes):

 * stage:  Accepted => Ready for checkin


Comment:

 Only the release note will need to be backported to stable/1.9.x and the
 master branch since `allow_syncdb`  support has been dropped in 1.9

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.c4c810cebe82fd5996ebc836f46c1b30%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25686: Database router without "allow_migrate" method raises exception

[Django]

#25686: Database router without "allow_migrate" method raises exception
-+-
 Reporter:  jcugat   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:  allow_migrate| Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by jcugat):

 Created a new PR [https://github.com/django/django/pull/5557 #5557]
 because somehow github did not like the rebase...

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.5ae25f343fc1a3b8ce46e83d7d9d8538%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25686: Database router without "allow_migrate" method raises exception

[Django]

#25686: Database router without "allow_migrate" method raises exception
-+-
 Reporter:  jcugat   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:  allow_migrate| Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by charettes):

 * severity:  Normal => Release blocker
 * needs_better_patch:  0 => 1
 * component:  Uncategorized => Database layer (models, ORM)
 * has_patch:  0 => 1
 * type:  Uncategorized => Bug
 * stage:  Unreviewed => Accepted


Comment:

 Hi jcugat, thanks for spotting this issue.

 Please rebase the patch on the `1.9.x` branch (which also have this issue)
 and add a release note for the upcoming 1.8.x release. Commiters will take
 care of the backporting to 1.8.x and the release note forward porting to
 master. I guess a simple regression test wouldn't hurt here.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.fae497d5c9f44539deed4a6b6037c1a0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25686: Database router without "allow_migrate" method raises exception

[Django]

#25686: Database router without "allow_migrate" method raises exception
---+--
 Reporter:  jcugat |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  Uncategorized  |  Version:  1.8
 Severity:  Normal |   Resolution:
 Keywords:  allow_migrate  | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by jcugat):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 Added pull request: https://github.com/django/django/pull/5556

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.6bcf639a5bf264d40f6e1e3d121499fb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #25686: Database router without "allow_migrate" method raises exception

[Django]

#25686: Database router without "allow_migrate" method raises exception
---+---
 Reporter:  jcugat |  Owner:  nobody
 Type:  Uncategorized  | Status:  new
Component:  Uncategorized  |Version:  1.8
 Severity:  Normal |   Keywords:  allow_migrate
 Triage Stage:  Unreviewed |  Has patch:  0
Easy pickings:  0  |  UI/UX:  0
---+---
 It seems Django 1.8.6 has introduced an error when using a database router
 that doesn't have a "allow_migrate" method. The router we are using is
 [https://github.com/jbalogh/django-multidb-
 router/blob/master/multidb/__init__.py#L83 PinningMasterSlaveRouter],
 which has a "allow_syncdb" method but no "allow_migrate". This was working
 with Django 1.8.5 (as seen in #24532), and it seems that the commit which
 introduced this is
 
[https://github.com/django/django/commit/e2ea30c4403fca1b0a2032aae7a783f8705fc08b
 e2ea30c].

 The traceback:

 {{{
 ./manage.py migrate
 Traceback (most recent call last):
   File "./manage.py", line 15, in 
 execute_from_command_line(sys.argv)
   File "/opt/lib/python2.7/site-
 packages/django/core/management/__init__.py", line 354, in
 execute_from_command_line
 utility.execute()
   File "/opt/lib/python2.7/site-
 packages/django/core/management/__init__.py", line 346, in execute
 self.fetch_command(subcommand).run_from_argv(self.argv)
   File "/opt/lib/python2.7/site-packages/django/core/management/base.py",
 line 394, in run_from_argv
 self.execute(*args, **cmd_options)
   File "/opt/lib/python2.7/site-
 packages/raven/contrib/django/management/__init__.py", line 41, in
 new_execute
 return original_func(self, *args, **kwargs)
   File "/opt/lib/python2.7/site-packages/django/core/management/base.py",
 line 444, in execute
 self.check()
   File "/opt/lib/python2.7/site-packages/django/core/management/base.py",
 line 482, in check
 include_deployment_checks=include_deployment_checks,
   File "/opt/lib/python2.7/site-packages/django/core/checks/registry.py",
 line 72, in run_checks
 new_errors = check(app_configs=app_configs)
   File "/opt/lib/python2.7/site-
 packages/django/core/checks/model_checks.py", line 28, in check_all_models
 errors.extend(model.check(**kwargs))
   File "/opt/lib/python2.7/site-packages/django/db/models/base.py", line
 1207, in check
 errors.extend(cls._check_long_column_names())
   File "/opt/lib/python2.7/site-packages/django/db/models/base.py", line
 1610, in _check_long_column_names
 if not router.allow_migrate_model(db, cls):
   File "/opt/lib/python2.7/site-packages/django/db/utils.py", line 367, in
 allow_migrate_model
 model=model,
   File "/opt/lib/python2.7/site-packages/django/db/utils.py", line 343, in
 allow_migrate
 argspec = inspect.getargspec(router.allow_migrate)
 AttributeError: 'PinningMasterSlaveRouter' object has no attribute
 'allow_migrate'
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/049.717548ac939bd7680a2d3dee8c8e7c8d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.