Re: [Django] #25710: Clarify the docs about what INTERNAL_IPS does

[Django]

#25710: Clarify the docs about what INTERNAL_IPS does
-+-
 Reporter:  knbk |Owner:
 Type:   |  alexmorozov
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  1.8
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"361038ee03b3b8513470990fc1851a51f56ecd6c" 361038ee]:
 {{{
 #!CommitTicketReference repository=""
 revision="361038ee03b3b8513470990fc1851a51f56ecd6c"
 [1.9.x] Fixed #25710 -- Clarified the docs about what INTERNAL_IPS does.

 Backport of 5abed864ee1cd31a0b920768b4abe85b26b43a4d from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.8e4ad74d0c5a23fee6f365b609b4f0c9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25710: Clarify the docs about what INTERNAL_IPS does

[Django]

#25710: Clarify the docs about what INTERNAL_IPS does
-+-
 Reporter:  knbk |Owner:
 Type:   |  alexmorozov
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  1.8
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"b4aa38d106e903a21773d3486885fd8d2fa8a660" b4aa38d]:
 {{{
 #!CommitTicketReference repository=""
 revision="b4aa38d106e903a21773d3486885fd8d2fa8a660"
 [1.8.x] Fixed #25710 -- Clarified the docs about what INTERNAL_IPS does.

 Backport of 5abed864ee1cd31a0b920768b4abe85b26b43a4d from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.d6cc60f5f6fb39e8fb8f0240b32b44fa%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25710: Clarify the docs about what INTERNAL_IPS does

[Django]

#25710: Clarify the docs about what INTERNAL_IPS does
-+-
 Reporter:  knbk |Owner:
 Type:   |  alexmorozov
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  1.8
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"5abed864ee1cd31a0b920768b4abe85b26b43a4d" 5abed86]:
 {{{
 #!CommitTicketReference repository=""
 revision="5abed864ee1cd31a0b920768b4abe85b26b43a4d"
 Fixed #25710 -- Clarified the docs about what INTERNAL_IPS does.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.7ec683c8fb9dbe51a5721f02767104ae%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25710: Clarify the docs about what INTERNAL_IPS does

[Django]

#25710: Clarify the docs about what INTERNAL_IPS does
-+-
 Reporter:  knbk |Owner:
 Type:   |  alexmorozov
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by timgraham):

 * has_patch:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.f89941bb459f1361255efa65f9b964de%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25710: Clarify the docs about what INTERNAL_IPS does

[Django]

#25710: Clarify the docs about what INTERNAL_IPS does
-+-
 Reporter:  knbk |Owner:
 Type:   |  alexmorozov
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by alexmorozov):

 Someone, please review my [https://github.com/django/django/pull/5628
 russian English].

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.a79c85019de90c1dcf370fec69e25782%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25710: Clarify the docs about what INTERNAL_IPS does

[Django]

#25710: Clarify the docs about what INTERNAL_IPS does
-+-
 Reporter:  knbk |Owner:
 Type:   |  alexmorozov
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by timgraham):

 Yes, I think so.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.6c644dd01dd3c6c876746c24e83ca854%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25710: Clarify the docs about what INTERNAL_IPS does

[Django]

#25710: Clarify the docs about what INTERNAL_IPS does
-+-
 Reporter:  knbk |Owner:
 Type:   |  alexmorozov
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by alexmorozov):

 @timgraham, thank you. Do I understand correctly that the existing phrase
 "See debug comments, when `DEBUG` is `True`" is about the `debug` context
 processor?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.e7903bdddca1a17fa34722a871fbd796%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25710: Clarify the docs about what INTERNAL_IPS does

[Django]

#25710: Clarify the docs about what INTERNAL_IPS does
-+-
 Reporter:  knbk |Owner:
 Type:   |  alexmorozov
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by timgraham):

 Linking from the [https://docs.djangoproject.com/en/dev/ref/settings
 /#internal-ips INTERNAL_IPS setting] to where each of those features are
 discussed in more detail would be helpful.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.f2f48ec15ab8347f382ade9a392392b0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25710: Clarify the docs about what INTERNAL_IPS does

[Django]

#25710: Clarify the docs about what INTERNAL_IPS does
-+-
 Reporter:  knbk |Owner:
 Type:   |  alexmorozov
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by alexmorozov):

 * owner:  nobody => alexmorozov
 * status:  new => assigned


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.5146554f7f0b4a12cd4ade13931ebc9e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25710: Clarify the docs about what INTERNAL_IPS does

[Django]

#25710: Clarify the docs about what INTERNAL_IPS does
--+
 Reporter:  knbk  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  1.8
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by alexmorozov):

 Guys, could you please elaborate on what specifically must be documented?

 `INTERNAL_IPS` is now used at three places (except tests):

 1. `django.template.context_processors.debug` to add SQL queries to
 context. Its docs mention the setting. Is it enough?
 2. `django.contrib.admindocs.middleware.XViewMiddleware` to add an X-View
 header. Docs mention the setting. Should we refactor documentation? I
 hardly can imagine what to add about the middleware itself.
 3. `django.utils.log.AdminEmailHandler` to prefix an email subject with an
 'internal'/'EXTERNAL' marks. Should we mention the setting
 
[https://docs.djangoproject.com/en/1.8/topics/logging/#django.utils.log.AdminEmailHandler
 here]?

 As for the `DEBUG` documentation, it seems pretty complete to me, since
 this setting has no direct relation to the `INTERNAL_IPS`. Am I wrong?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.a414adb65fee3cf43dee5451f4d834f2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25710: Clarify the docs about what INTERNAL_IPS does (was: Document what INTERNAL_IPS does)

[Django]

#25710: Clarify the docs about what INTERNAL_IPS does
--+
 Reporter:  knbk  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  1.8
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by timgraham):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * easy:  0 => 1
 * needs_docs:   => 0
 * stage:  Unreviewed => Accepted


Comment:

 There's also a usage in `AdminEmailHandler` that could be mentioned.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.2d2350e41eff128662cbea3e1c2a6dda%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.