Re: [Django] #25734: Nodata value not excluded when computing GDALBand min/max values

[Django]

#25734: Nodata value not excluded when computing GDALBand min/max values
-+-
 Reporter:  yellowcap|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  GIS  |  Version:  1.8
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  raster gdal gis  | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * status:  new => closed
 * resolution:   => fixed


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.e0c92b134440bdaeb331cb675fbdd80c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25734: Nodata value not excluded when computing GDALBand min/max values

[Django]

#25734: Nodata value not excluded when computing GDALBand min/max values
-+-
 Reporter:  yellowcap|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  GIS  |  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:  raster gdal gis  | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"0e7d59df3ed6988cd5a45e26414c013ad40c7402" 0e7d59d]:
 {{{
 #!CommitTicketReference repository=""
 revision="0e7d59df3ed6988cd5a45e26414c013ad40c7402"
 Refs #25734 -- Relaxed GDALRaster statistics test to use
 assertAlmostEqual.

 Some versions of GDAL give slightly different results.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.be71872fc83a9eede3c1401a3d07c659%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25734: Nodata value not excluded when computing GDALBand min/max values

[Django]

#25734: Nodata value not excluded when computing GDALBand min/max values
-+-
 Reporter:  yellowcap|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  GIS  |  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:  raster gdal gis  | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by yellowcap):

 No that's fine, its good to go for me as well.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.47328b6c591ebbecd336f953ae620c01%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25734: Nodata value not excluded when computing GDALBand min/max values

[Django]

#25734: Nodata value not excluded when computing GDALBand min/max values
-+-
 Reporter:  yellowcap|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  GIS  |  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:  raster gdal gis  | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * stage:  Accepted => Ready for checkin


Comment:

 I guess this is good to go unless you want to do any further investigate,
 Daniel?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.268f1daa6616e9c6aa50158fadb90416%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25734: Nodata value not excluded when computing GDALBand min/max values

[Django]

#25734: Nodata value not excluded when computing GDALBand min/max values
-+
 Reporter:  yellowcap|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  GIS  |  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:  raster gdal gis  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by bmispelon):

 My version of GDAL is 2.0.1.

 The linked pull request fixes the broken test on my machine.

 Thanks.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.0899ef8a5cb5d8c5465040b1c979bf13%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25734: Nodata value not excluded when computing GDALBand min/max values

[Django]

#25734: Nodata value not excluded when computing GDALBand min/max values
-+
 Reporter:  yellowcap|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  GIS  |  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:  raster gdal gis  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by timgraham):

 * has_patch:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.a9b948b10f35b631cc105e0acd67e9cb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25734: Nodata value not excluded when computing GDALBand min/max values

[Django]

#25734: Nodata value not excluded when computing GDALBand min/max values
-+
 Reporter:  yellowcap|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  GIS  |  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:  raster gdal gis  | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by yellowcap):

 Made a pull request with a patch that hopefully solve the test failure due
 to small numerical differences like the one reported.

 https://github.com/django/django/pull/5763

 I remain curious about the reason for the difference though, so if
 possible I would still be interested to get the GDAL version on the system
 with the failed test.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.fd52c63aaa33b6b0596f859b00e5cbad%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25734: Nodata value not excluded when computing GDALBand min/max values

[Django]

#25734: Nodata value not excluded when computing GDALBand min/max values
-+
 Reporter:  yellowcap|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  GIS  |  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:  raster gdal gis  | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by claudep):

 We might have to resort to variants of `assertAlmostEqual` here (AFAIK,
 the default `assertAlmostEqual` doesn't work on tuples).

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.f9d56b26317f97bfaeb6fc1232bd7f3d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25734: Nodata value not excluded when computing GDALBand min/max values

[Django]

#25734: Nodata value not excluded when computing GDALBand min/max values
-+
 Reporter:  yellowcap|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  GIS  |  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:  raster gdal gis  | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by timgraham):

 * cc: bmispelon (added)
 * has_patch:  1 => 0
 * stage:  Ready for checkin => Accepted


Comment:

 Baptiste, please provide:
 {{{
 >>> from django.contrib.gis.gdal import gdal_version
 >>> gdal_version()
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.572fd21eb78819eb677e208eda8dc93d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25734: Nodata value not excluded when computing GDALBand min/max values

[Django]

#25734: Nodata value not excluded when computing GDALBand min/max values
-+-
 Reporter:  yellowcap|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  GIS  |  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:  raster gdal gis  | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by yellowcap):

 That could also be related to differences in GDAL, could you please also
 post the GDAL version you are using for me to reproduce the failure?
 Thanks.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.78a87110598d812b1bd60a4296e7997c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25734: Nodata value not excluded when computing GDALBand min/max values

[Django]

#25734: Nodata value not excluded when computing GDALBand min/max values
-+-
 Reporter:  yellowcap|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  GIS  |  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:  raster gdal gis  | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by bmispelon):

 * status:  closed => new
 * resolution:  fixed =>


Comment:

 I'm getting a test failure on my local machine (Python 3.5.0, not sure
 what other versions would be relevant):
 {{{
 ==
 FAIL: test_band_data (gis_tests.gdal_tests.test_raster.GDALBandTests)
 --
 Traceback (most recent call last):
   File "./django/tests/gis_tests/gdal_tests/test_raster.py", line 323, in
 test_band_data
 (0.0, 9.0, 2.842331288343558, 2.3965567248965356)
 AssertionError: Tuples differ: (0.0, 9.0, 2.8423312883435643,
 2.396556724896537) != (0.0, 9.0, 2.842331288343558, 2.3965567248965356)

 First differing element 2:
 2.8423312883435643
 2.842331288343558

 - (0.0, 9.0, 2.8423312883435643, 2.396556724896537)
 ?   ^^^  ^

 + (0.0, 9.0, 2.842331288343558, 2.3965567248965356)
 ?   ^^  ^^


 --
 Ran 5 tests in 0.039s
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.f482f9066e57a8e239eea2cd8eae19c1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25734: Nodata value not excluded when computing GDALBand min/max values

[Django]

#25734: Nodata value not excluded when computing GDALBand min/max values
-+-
 Reporter:  yellowcap|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  GIS  |  Version:  1.8
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  raster gdal gis  | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"8f5904560a7ab51d480410ca5228df1a28ec2295" 8f59045]:
 {{{
 #!CommitTicketReference repository=""
 revision="8f5904560a7ab51d480410ca5228df1a28ec2295"
 Fixed #25734 -- Made GDALBand min and max properties use
 GDALComputeRasterStatistics.

 Thanks Sergey Fedoseev and Tim Graham for the review.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.b2d38390763dbc5d4bc9481cb5fc5df2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25734: Nodata value not excluded when computing GDALBand min/max values

[Django]

#25734: Nodata value not excluded when computing GDALBand min/max values
-+-
 Reporter:  yellowcap|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  GIS  |  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:  raster gdal gis  | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by yellowcap):

 That's right, I agree that its probably not critical. An alternative
 simple way of "backporting" this would be to change the 1.8 documentation
 on the min/max attributes. The documentation could state that the methods
 might not return the true value if they are not already stored internally
 in the raster or in a metatdata file. However I am not sure if that would
 be good practice either.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.213e063ffb97318234ecd0438edbcc41%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25734: Nodata value not excluded when computing GDALBand min/max values

[Django]

#25734: Nodata value not excluded when computing GDALBand min/max values
-+-
 Reporter:  yellowcap|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  GIS  |  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:  raster gdal gis  | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * stage:  Accepted => Ready for checkin


Comment:

 I'm not sure it's a critical fix that needs to be backported (however, I'm
 not a GIS user). See our [https://docs.djangoproject.com/en/dev/internals
 /release-process/#supported-versions Supported Versions policy].

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.6241439c9d6ab7ce58e2260a652c408d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25734: Nodata value not excluded when computing GDALBand min/max values

[Django]

#25734: Nodata value not excluded when computing GDALBand min/max values
-+
 Reporter:  yellowcap|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  GIS  |  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:  raster gdal gis  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by timgraham):

 * stage:  Unreviewed => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.bed2d478b4a88c61a1a9c1c39274d18a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25734: Nodata value not excluded when computing GDALBand min/max values

[Django]

#25734: Nodata value not excluded when computing GDALBand min/max values
-+--
 Reporter:  yellowcap|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  GIS  |  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:  raster gdal gis  | Triage Stage:  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--
Changes (by yellowcap):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 I made a pull request that fixes the problem, but I am not sure how this
 can be integrated in earlier versions because it adds one or two
 properties, maybe it has to be done differently.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.ea0f7e0671d3f4d8b0fbe792757060e8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #25734: Nodata value not excluded when computing GDALBand min/max values

[Django]

#25734: Nodata value not excluded when computing GDALBand min/max values
+-
 Reporter:  yellowcap   |  Owner:  nobody
 Type:  Bug | Status:  new
Component:  GIS |Version:  1.8
 Severity:  Normal  |   Keywords:  raster gdal gis
 Triage Stage:  Unreviewed  |  Has patch:  1
Easy pickings:  0   |  UI/UX:  0
+-
 The `min` and `max` properties of `GDALBand` objects only return the
 "true" min or max value when the underlying band has statistics
 calculated, otherwise they return the min/max of the datatype will be
 returned.

 This is expected behavior of the gdal C function but should be different
 for the GDALBand properties. The property should return the true min/max.

 http://www.gdal.org/classGDALRasterBand.html#aaabf419931d0f505428f91cff54085cc

 The propsed solution for this is to add the "GDALComputeRasterStatistics"
 function to the prototypes and use that instead of the
 "GDALGetRasterMinimum/Maximum"  functions.

 http://www.gdal.org/gdal_8h.html#aa93b6b6ea6e71017ce25524e1a9ef1e3

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.cd66d6dfca59c77c9732485043b36c05%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.