Re: [Django] #25782: Discourage usage of cache_page decorator with UpdateCacheMiddleware (or make middleware ignore decorated views)

[Django]

#25782: Discourage usage of cache_page decorator with UpdateCacheMiddleware (or
make middleware ignore decorated views)
-+-
 Reporter:  Serhiy   |Owner:  Wassef
 Type:   |  Ben Ahmed
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Sarah Boyce):

 Although I am now happy with the patch, this might rely on #15855 to be
 fixed and so further investigation is required in that ticket before
 proceeding further here
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701909630ada1-574842c2-7308-43e5-b3fe-28678fdf647b-00%40eu-central-1.amazonses.com.

Re: [Django] #25782: Discourage usage of cache_page decorator with UpdateCacheMiddleware (or make middleware ignore decorated views)

[Django]

#25782: Discourage usage of cache_page decorator with UpdateCacheMiddleware (or
make middleware ignore decorated views)
-+-
 Reporter:  Serhiy   |Owner:  Wassef
 Type:   |  Ben Ahmed
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Sarah Boyce):

 * needs_better_patch:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701905db324a3-bcceeac5-342a-4505-8b83-d5e283bbc0a7-00%40eu-central-1.amazonses.com.

Re: [Django] #25782: Discourage usage of cache_page decorator with UpdateCacheMiddleware (or make middleware ignore decorated views)

[Django]

#25782: Discourage usage of cache_page decorator with UpdateCacheMiddleware (or
make middleware ignore decorated views)
-+-
 Reporter:  Serhiy   |Owner:  Wassef
 Type:   |  Ben Ahmed
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Wassef Ben Ahmed):

 * owner:  nobody => Wassef Ben Ahmed
 * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701905b2644d4-a46fa11a-ed1e-407d-8317-5e80b832354c-00%40eu-central-1.amazonses.com.

Re: [Django] #25782: Discourage usage of cache_page decorator with UpdateCacheMiddleware (or make middleware ignore decorated views)

[Django]

#25782: Discourage usage of cache_page decorator with UpdateCacheMiddleware (or
make middleware ignore decorated views)
--+
 Reporter:  Serhiy|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Wassef Ben Ahmed):

 * has_patch:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701905b2603dc-a9f9df92-777d-4e62-bba1-6e538c15-00%40eu-central-1.amazonses.com.

Re: [Django] #25782: Discourage usage of cache_page decorator with UpdateCacheMiddleware (or make middleware ignore decorated views)

[Django]

#25782: Discourage usage of cache_page decorator with UpdateCacheMiddleware (or
make middleware ignore decorated views)
--+
 Reporter:  Serhiy|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Ülgen Sarıkavak):

 * cc: Ülgen Sarıkavak (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e5070f39b-3c825764-aff4-4e4a-80d5-7660619298c1-00%40eu-central-1.amazonses.com.

Re: [Django] #25782: Discourage usage of cache_page decorator with UpdateCacheMiddleware (or make middleware ignore decorated views)

[Django]

#25782: Discourage usage of cache_page decorator with UpdateCacheMiddleware (or
make middleware ignore decorated views)
--+
 Reporter:  int-ua|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * type:  Uncategorized => Cleanup/optimization
 * stage:  Unreviewed => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.6bacb259257cd2c8b36a25b4fe6842f3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25782: Discourage usage of cache_page decorator with UpdateCacheMiddleware (or make middleware ignore decorated views)

[Django]

#25782: Discourage usage of cache_page decorator with UpdateCacheMiddleware (or
make middleware ignore decorated views)
---+--
 Reporter:  int-ua |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  Documentation  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by carljm):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 Any attempt to fix this should also take into account #15855 -- the
 `cache_page` decorator is already basically broken in terms of Vary
 headers. It shouldn't cache at all, it should mark the response for later
 caching by the middleware, or something.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.c29c48ac291c9fc45a3951470d8ca3ce%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #25782: Discourage usage of cache_page decorator with UpdateCacheMiddleware (or make middleware ignore decorated views)

[Django]

#25782: Discourage usage of cache_page decorator with UpdateCacheMiddleware (or
make middleware ignore decorated views)
---+
 Reporter:  int-ua |  Owner:  nobody
 Type:  Uncategorized  | Status:  new
Component:  Documentation  |Version:  master
 Severity:  Normal |   Keywords:
 Triage Stage:  Unreviewed |  Has patch:  0
Easy pickings:  0  |  UI/UX:  0
---+
 If django.middleware.cache.UpdateCacheMiddleware is active and some view
 is decorated with the cache_page that overrides cache alias, this view
 will be cached in both caches, first time by cache_page and then by the
 middleware. Well, at least it will try. And fail if the default cache is
 memcached and the view response is bigger than its' maximum entry size.
 While filebased cache will work and even create the cache entry. This way
 first user to visit when there are no entry in cache will get error
 instead of data.
 So, I guess there should be some warning about this in the docs.
 Ideally, middleware should ignore views with overridden cache alias, maybe
 by means of checking headers like in case of the cache_control decorator.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/049.9fb04254eadc19b9dbe52311386a33d8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.