Re: [Django] #25812: Cannot use custom formats after security fix in 1.8.7 (regression)

[Django]

#25812: Cannot use custom formats after security fix in 1.8.7 (regression)
-+-
 Reporter:  Gagaro   |Owner:  Gagaro
 Type:  Bug  |   Status:  closed
Component:   |  Version:  1.8
  Internationalization   |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  formats  | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"08e1c79f7ae574ed27a93e97a0a56c3fcba3aa68" 08e1c79f]:
 {{{
 #!CommitTicketReference repository=""
 revision="08e1c79f7ae574ed27a93e97a0a56c3fcba3aa68"
 [1.9.x] Fixed #25812 -- Restored the ability to use custom formats with
 the date template filter.

 Backport of 34d88944f46d3e2734488fd0ca3c2c24c15a0264 from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.97d6eee278eb1e7e3464bb9fe43ffe95%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25812: Cannot use custom formats after security fix in 1.8.7 (regression)

[Django]

#25812: Cannot use custom formats after security fix in 1.8.7 (regression)
-+-
 Reporter:  Gagaro   |Owner:  Gagaro
 Type:  Bug  |   Status:  closed
Component:   |  Version:  1.8
  Internationalization   |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  formats  | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"9582ba51bd486c5785c0e76ed7f7996119bc9650" 9582ba5]:
 {{{
 #!CommitTicketReference repository=""
 revision="9582ba51bd486c5785c0e76ed7f7996119bc9650"
 [1.8.x] Fixed #25812 -- Restored the ability to use custom formats with
 the date template filter.

 Backport of 34d88944f46d3e2734488fd0ca3c2c24c15a0264 from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.a5e4c1b10ab5995605e5477db7b1cd03%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25812: Cannot use custom formats after security fix in 1.8.7 (regression)

[Django]

#25812: Cannot use custom formats after security fix in 1.8.7 (regression)
-+-
 Reporter:  Gagaro   |Owner:  Gagaro
 Type:  Bug  |   Status:  closed
Component:   |  Version:  1.8
  Internationalization   |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  formats  | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"34d88944f46d3e2734488fd0ca3c2c24c15a0264" 34d8894]:
 {{{
 #!CommitTicketReference repository=""
 revision="34d88944f46d3e2734488fd0ca3c2c24c15a0264"
 Fixed #25812 -- Restored the ability to use custom formats with the date
 template filter.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.5cfeff8774a959c9138d990fc22f4a54%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25812: Cannot use custom formats after security fix in 1.8.7 (regression)

[Django]

#25812: Cannot use custom formats after security fix in 1.8.7 (regression)
-+-
 Reporter:  Gagaro   |Owner:  Gagaro
 Type:  Bug  |   Status:  assigned
Component:   |  Version:  1.8
  Internationalization   |
 Severity:  Release blocker  |   Resolution:
 Keywords:  formats  | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * type:  Uncategorized => Bug
 * severity:  Normal => Release blocker
 * stage:  Unreviewed => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.7ca9e8c51f68383228d1c8f637481769%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25812: Cannot use custom formats after security fix in 1.8.7 (regression)

[Django]

#25812: Cannot use custom formats after security fix in 1.8.7 (regression)
-+-
 Reporter:  Gagaro   |Owner:  Gagaro
 Type:  Uncategorized|   Status:  assigned
Component:   |  Version:  1.8
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:  formats  | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Description changed by Gagaro:

Old description:

> Before the security fix in 1.8.7, we could have custom formats in
> formats.py files and used them. For example, if I have the following
> formats.py:
>

> {{{
> CUSTOM_DAY_FORMAT = 'd/m/Y CUSTOM'
> }}}
>
> I could used it:
>
> {{{
> >>> get_format('CUSTOM_DAY_FORMAT')
> 'd/m/Y CUSTOM'
> }}}
>
> But now it returns 'CUSTOM_DAY_FORMAT' instead. I know where the problem
> is and how to fix it, I should have a PR ready in a few hours with a test
> and the fix.

New description:

 Before the security fix in 1.8.7, we could have custom formats in
 formats.py files and used them. For example, if I have the following
 formats.py:


 {{{
 CUSTOM_DAY_FORMAT = 'd/m/Y CUSTOM'
 }}}

 I could used it:

 {{{
 >>> get_format('CUSTOM_DAY_FORMAT')
 'd/m/Y CUSTOM'
 }}}

 But now it returns 'CUSTOM_DAY_FORMAT' instead.

 https://github.com/django/django/pull/5719

--

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.fe10b5aa0fac7062c7f48d028e2c1a36%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25812: Cannot use custom formats after security fix in 1.8.7 (regression)

[Django]

#25812: Cannot use custom formats after security fix in 1.8.7 (regression)
-+-
 Reporter:  Gagaro   |Owner:  Gagaro
 Type:  Uncategorized|   Status:  assigned
Component:   |  Version:  1.8
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:  formats  | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Gagaro):

 * has_patch:  0 => 1


Comment:

 https://github.com/django/django/pull/5719

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.85c73cf87dfc61ef87cbce3cb633909f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25812: Cannot use custom formats after security fix in 1.8.7 (regression)

[Django]

#25812: Cannot use custom formats after security fix in 1.8.7 (regression)
-+-
 Reporter:  Gagaro   |Owner:  Gagaro
 Type:  Uncategorized|   Status:  assigned
Component:   |  Version:  1.8
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:  formats  | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Gagaro):

 * owner:  nobody => Gagaro
 * needs_docs:   => 0
 * status:  new => assigned
 * needs_tests:   => 0
 * needs_better_patch:   => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.7b79b95510f66344b8677d043edb5f43%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #25812: Cannot use custom formats after security fix in 1.8.7 (regression)

[Django]

#25812: Cannot use custom formats after security fix in 1.8.7 (regression)
--+-
 Reporter:  Gagaro|  Owner:  nobody
 Type:  Uncategorized | Status:  new
Component:  Internationalization  |Version:  1.8
 Severity:  Normal|   Keywords:  formats
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  0 |  UI/UX:  0
--+-
 Before the security fix in 1.8.7, we could have custom formats in
 formats.py files and used them. For example, if I have the following
 formats.py:


 {{{
 CUSTOM_DAY_FORMAT = 'd/m/Y CUSTOM'
 }}}

 I could used it:

 {{{
 >>> get_format('CUSTOM_DAY_FORMAT')
 'd/m/Y CUSTOM'
 }}}

 But now it returns 'CUSTOM_DAY_FORMAT' instead. I know where the problem
 is and how to fix it, I should have a PR ready in a few hours with a test
 and the fix.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/049.ae68d3758af3fdaa2909ee9342368997%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.