Re: [Django] #25847: Make User.is_authenticated() and User.is_anonymous() "callable properties"

[Django]

#25847: Make User.is_authenticated() and User.is_anonymous() "callable 
properties"
-+-
 Reporter:  Stavros  |Owner:  Jeremy
  Korokithakis   |  Lainé
 Type:  New feature  |   Status:  closed
Component:  contrib.auth |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  1.10 | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"eba093e8b02989af1857b1915907ca0897f565ff" eba093e]:
 {{{
 #!CommitTicketReference repository=""
 revision="eba093e8b02989af1857b1915907ca0897f565ff"
 Refs #25847 -- Removed support for User.is_(anonymous|authenticated) as
 methods.

 Per deprecation timeline.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.c6d1d5f64561081a7e208f7ca4469ed9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25847: Make User.is_authenticated() and User.is_anonymous() "callable properties"

[Django]

#25847: Make User.is_authenticated() and User.is_anonymous() "callable 
properties"
---+
 Reporter:  skorokithakis  |Owner:  jlaine
 Type:  New feature|   Status:  closed
Component:  contrib.auth   |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords:  1.10   | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by timgraham):

 * status:  new => closed
 * resolution:   => fixed


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.110e868a6f21d98ba5e589715b3f59e4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25847: Make User.is_authenticated() and User.is_anonymous() "callable properties"

[Django]

#25847: Make User.is_authenticated() and User.is_anonymous() "callable 
properties"
---+
 Reporter:  skorokithakis  |Owner:  jlaine
 Type:  New feature|   Status:  new
Component:  contrib.auth   |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  1.10   | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by Tim Graham ):

 In [changeset:"03efa304bce5ef0924948a74ae01cdf817dd416a" 03efa304]:
 {{{
 #!CommitTicketReference repository=""
 revision="03efa304bce5ef0924948a74ae01cdf817dd416a"
 Refs #25847 -- Added system check for
 UserModel.is_anonymous/is_authenticated methods.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.74e36ea5d8f4dffbbef339914fe2c98c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25847: Make User.is_authenticated() and User.is_anonymous() "callable properties"

[Django]

#25847: Make User.is_authenticated() and User.is_anonymous() "callable 
properties"
---+
 Reporter:  skorokithakis  |Owner:  jlaine
 Type:  New feature|   Status:  new
Component:  contrib.auth   |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  1.10   | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by timgraham):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/6562 PR] for the system check to
 detect `is_anonymous`/`is_authenticated` as methods.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.8526af99a0ab31cdd5f8ffd882db7ab9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25847: Make User.is_authenticated() and User.is_anonymous() "callable properties"

[Django]

#25847: Make User.is_authenticated() and User.is_anonymous() "callable 
properties"
---+
 Reporter:  skorokithakis  |Owner:  jlaine
 Type:  New feature|   Status:  new
Component:  contrib.auth   |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  1.10   | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by apollo13):

 * cc: apollo13 (added)


Comment:

 Unless that system check is a hard error I am against it. (Ie it does have
 to be ERROR, so we can ensure that we do not open ourself to security
 issues) -- can we justify the backwards incompatibility?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.7f3f713f8c750b30fa78d4b1a013a608%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25847: Make User.is_authenticated() and User.is_anonymous() "callable properties"

[Django]

#25847: Make User.is_authenticated() and User.is_anonymous() "callable 
properties"
---+
 Reporter:  skorokithakis  |Owner:  jlaine
 Type:  New feature|   Status:  new
Component:  contrib.auth   |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  1.10   | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by timgraham):

 * keywords:   => 1.10
 * needs_better_patch:  1 => 0
 * has_patch:  1 => 0
 * version:  1.9 => master


Comment:

 I was thinking of adding a "compatibility" system check to detect that.
 I'll do it before 1.10 alpha if no one else takes it.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.81ada32096834b0939e08de595f748db%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25847: Make User.is_authenticated() and User.is_anonymous() "callable properties"

[Django]

#25847: Make User.is_authenticated() and User.is_anonymous() "callable 
properties"
---+
 Reporter:  skorokithakis  |Owner:  jlaine
 Type:  New feature|   Status:  new
Component:  contrib.auth   |  Version:  1.9
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+
Changes (by claudep):

 * status:  closed => new
 * resolution:  fixed =>


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.ff979422e52436a0c504bd8291aed340%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25847: Make User.is_authenticated() and User.is_anonymous() "callable properties"

[Django]

#25847: Make User.is_authenticated() and User.is_anonymous() "callable 
properties"
---+
 Reporter:  skorokithakis  |Owner:  jlaine
 Type:  New feature|   Status:  closed
Component:  contrib.auth   |  Version:  1.9
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+

Comment (by apollo13):

 @timgraham: I feel this should get reverted for now. We have to consider
 custom user models which did define this as a method. A warning is not
 enough, either his is a hard error or we ensure that it is backwards
 compatible. Allowing custom user models to have a method is a security
 risk since all checks will now return true…

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.79e0a60d05e0fcec1123c100ef937d1e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25847: Make User.is_authenticated() and User.is_anonymous() "callable properties"

[Django]

#25847: Make User.is_authenticated() and User.is_anonymous() "callable 
properties"
---+
 Reporter:  skorokithakis  |Owner:  jlaine
 Type:  New feature|   Status:  closed
Component:  contrib.auth   |  Version:  1.9
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"c1aec0feda73ede09503192a66f973598aef901d" c1aec0fe]:
 {{{
 #!CommitTicketReference repository=""
 revision="c1aec0feda73ede09503192a66f973598aef901d"
 Fixed #25847 -- Made User.is_(anonymous|authenticated) properties.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.91c75fcbde34c4007878b893d3202c1b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25847: Make User.is_authenticated() and User.is_anonymous() "callable properties"

[Django]

#25847: Make User.is_authenticated() and User.is_anonymous() "callable 
properties"
---+
 Reporter:  skorokithakis  |Owner:  jlaine
 Type:  New feature|   Status:  assigned
Component:  contrib.auth   |  Version:  1.9
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+
Changes (by timgraham):

 * needs_better_patch:  0 => 1


Comment:

 Left comments for improvement.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.69362af18f2806fe90d408048ab16882%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25847: Make User.is_authenticated() and User.is_anonymous() "callable properties"

[Django]

#25847: Make User.is_authenticated() and User.is_anonymous() "callable 
properties"
---+
 Reporter:  skorokithakis  |Owner:  jlaine
 Type:  New feature|   Status:  assigned
Component:  contrib.auth   |  Version:  1.9
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by jlaine):

 * has_patch:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.8ce412939aef75f532298422dd728e7e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25847: Make User.is_authenticated() and User.is_anonymous() "callable properties"

[Django]

#25847: Make User.is_authenticated() and User.is_anonymous() "callable 
properties"
---+
 Reporter:  skorokithakis  |Owner:  jlaine
 Type:  New feature|   Status:  assigned
Component:  contrib.auth   |  Version:  1.9
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by timgraham):

 Alternatively, we could add a system check that raises a warning for an
 incompatible implementation.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.e406513393bc6c8b9c2f405b4403a212%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25847: Make User.is_authenticated() and User.is_anonymous() "callable properties"

[Django]

#25847: Make User.is_authenticated() and User.is_anonymous() "callable 
properties"
---+
 Reporter:  skorokithakis  |Owner:  jlaine
 Type:  New feature|   Status:  assigned
Component:  contrib.auth   |  Version:  1.9
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by jlaine):

 I have put up a pull request here:

 https://github.com/django/django/pull/6376

 @apollo13 mentioned that we might want to support the case where a custom
 user model defines is_anonymous / is_authenticated as methods instead of
 properties. In this case we could do something like this to monkey-patch
 that user model to the new style:

 {{{
 def __new__(cls):
 if not isinstance(cls.is_anonymous, property):
 real_is_anonymous = cls.is_anonymous
 cls.is_anonymous = property(lambda x:
 CallableBool(real_is_anonymous(x)))
 return super(AbstractBaseUser, cls).__new__(cls)
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.d9f24170b52cda69992279435a86cf81%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25847: Make User.is_authenticated() and User.is_anonymous() "callable properties" (was: Make User.is_authenticated() a "callable property")

[Django]

#25847: Make User.is_authenticated() and User.is_anonymous() "callable 
properties"
---+
 Reporter:  skorokithakis  |Owner:  jlaine
 Type:  New feature|   Status:  assigned
Component:  contrib.auth   |  Version:  1.9
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.1802e16bfd05389b1cad1bdb1979a980%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.