Re: [Django] #25850: Migrations ignore inconsistent history silently

[Django]

#25850: Migrations ignore inconsistent history silently
--+
 Reporter:  shaib |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Migrations|  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Tim Graham ):

 In [changeset:"57f7d8968d8443352ce331ad9dd6f433a15d0d93" 57f7d896]:
 {{{
 #!CommitTicketReference repository=""
 revision="57f7d8968d8443352ce331ad9dd6f433a15d0d93"
 [1.10.x] Refs #25850, #27142, #27110 -- Documented migration history
 consistency checks.

 Backport of c93ac9cf42bff259ab71b70a89b693b9c38e4666 from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.c9ff47b9f2d5be82693ce0fa8307db5f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25850: Migrations ignore inconsistent history silently

[Django]

#25850: Migrations ignore inconsistent history silently
--+
 Reporter:  shaib |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Migrations|  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Tim Graham ):

 In [changeset:"c93ac9cf42bff259ab71b70a89b693b9c38e4666" c93ac9cf]:
 {{{
 #!CommitTicketReference repository=""
 revision="c93ac9cf42bff259ab71b70a89b693b9c38e4666"
 Refs #25850, #27142, #27110 -- Documented migration history consistency
 checks.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.297df0010209c5a7fe40b13e9a5e99d7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25850: Migrations ignore inconsistent history silently

[Django]

#25850: Migrations ignore inconsistent history silently
--+
 Reporter:  shaib |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Migrations|  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"02ae5fd31a56ffb42feadb49c1f3870ba0a24869" 02ae5fd]:
 {{{
 #!CommitTicketReference repository=""
 revision="02ae5fd31a56ffb42feadb49c1f3870ba0a24869"
 Fixed #25850 -- Made migrate/makemigrations error on inconsistent history.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.c07c15ab1427322efe61209f6c1d7ee4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25850: Migrations ignore inconsistent history silently

[Django]

#25850: Migrations ignore inconsistent history silently
--+
 Reporter:  shaib |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Migrations|  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Uran198):

 * needs_better_patch:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.57783a792ac56ffc92fb74bd01a73b00%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25850: Migrations ignore inconsistent history silently

[Django]

#25850: Migrations ignore inconsistent history silently
--+
 Reporter:  shaib |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Migrations|  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * needs_better_patch:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.5c2087208a6a0814d95b152f48404f05%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25850: Migrations ignore inconsistent history silently

[Django]

#25850: Migrations ignore inconsistent history silently
--+
 Reporter:  shaib |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Migrations|  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Uran198):

 * needs_better_patch:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.8ed36caf3782410b5bfff091e8a921ec%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25850: Migrations ignore inconsistent history silently

[Django]

#25850: Migrations ignore inconsistent history silently
--+
 Reporter:  shaib |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Migrations|  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * needs_better_patch:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.ca561c0b160eaef827407f65c7764da9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25850: Migrations ignore inconsistent history silently

[Django]

#25850: Migrations ignore inconsistent history silently
--+
 Reporter:  shaib |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Migrations|  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * needs_better_patch:  1 => 0


Comment:

 (Don't forget to uncheck "Patch needs improvement" so the ticket appears
 in the review queue.)

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.779b3a8b5f34365505cfda4c77844f67%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25850: Migrations ignore inconsistent history silently

[Django]

#25850: Migrations ignore inconsistent history silently
--+
 Reporter:  shaib |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Migrations|  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Uran198):

 I completed the previous fix and opened a new
 [https://github.com/django/django/pull/5977 PR]

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.d02b2dbdfcf4f889aaf6467de8e8abff%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25850: Migrations ignore inconsistent history silently

[Django]

#25850: Migrations ignore inconsistent history silently
--+
 Reporter:  shaib |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Migrations|  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Uran198):

 * has_patch:  0 => 1
 * needs_tests:  1 => 0


Comment:

 [https://github.com/django/django/pull/5922 PR]

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.e7c1087aef7be5f934c4bd70785aa8d3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25850: Migrations ignore inconsistent history silently

[Django]

#25850: Migrations ignore inconsistent history silently
--+
 Reporter:  shaib |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Migrations|  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  1 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by MarkusH):

 * type:  Bug => Cleanup/optimization
 * stage:  Unreviewed => Accepted


Comment:

 Yeah, as discussed at DutH Django should bail out loudly.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.341ab6f20553a5127be949e5b7c601f7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #25850: Migrations ignore inconsistent history silently

[Django]

#25850: Migrations ignore inconsistent history silently
--+
   Reporter:  shaib   |  Owner:  nobody
   Type:  Bug | Status:  new
  Component:  Migrations  |Version:  master
   Severity:  Normal  |   Keywords:
   Triage Stage:  Unreviewed  |  Has patch:  0
Needs documentation:  0   |Needs tests:  1
Patch needs improvement:  0   |  Easy pickings:  0
  UI/UX:  0   |
--+
 Doing some bad things, it is possible to get to a state where a migration
 is recorded as executed without all of its dependencies being executed.
 For example, if we have migrations for the same app developed on separate
 branches, and the person who merges them decides to resolve the conflict
 not by adding a "merge migration" as suggested by Django, but by editing
 the dependencies on migrations which were already run.

 One should not do that, of course, but if one does do that, Django should
 refuse to do anything with these migrations until the situation is
 resolved. Currently, it just happily ignores the unfulfilled dependencies,
 and will migrate forwards and even cheerfully create new migrations. We
 don't even have an `InconsistentMigrationHistory` exception.

 A failing test draft (add at the end of
 `tests/migrations/test_executor.py`):
 {{{
 def test_reject_holes_in_history(self):
 """
 If the history is inconsistent with the sources, cry foul
 a: 1 <--- 2 <--- 3
 If a2 is applied already and a1 is not, and we're asked to migrate
 to
 a3, then something is very wrong and we should not proceed
 """
 a1_impl = FakeMigration('a1')
 a1 = ('a', '1')
 a2_impl = FakeMigration('a2')
 a2 = ('a', '2')
 a3_impl = FakeMigration('a3')
 a3 = ('a', '3')
 graph = MigrationGraph()
 graph.add_node(a1, a1_impl)
 graph.add_node(a2, a2_impl)
 graph.add_node(a3, a3_impl)
 graph.add_dependency(None, a2, a1)
 graph.add_dependency(None, a3, a2)

 executor = MigrationExecutor(None)
 executor.loader = FakeLoader(graph, {a2})

 with self.assertRaises(Exception):
 plan = executor.migration_plan({a3})
  }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/048.39ccbfcec5ddd7e94a940b6bf57445dd%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.