Re: [Django] #25893: Custom Lookups & Transform example lhs/rhs swap

[Django]

#25893: Custom Lookups & Transform example lhs/rhs swap
-+-
 Reporter:  browniebroke |Owner:
 Type:   |  browniebroke
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"c0c2c7ecd6780b1207b18d96a60c807dbb98eb81" c0c2c7e]:
 {{{
 #!CommitTicketReference repository=""
 revision="c0c2c7ecd6780b1207b18d96a60c807dbb98eb81"
 [1.8.x] Fixed #25893 -- Corrected custom lookups example.

 Backport of ffcdb0b471d0afc72b42b0a2b0c0c4fb45d7b6b1 from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.18794b7d861c77c36d9c1a69237b7c74%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25893: Custom Lookups & Transform example lhs/rhs swap

[Django]

#25893: Custom Lookups & Transform example lhs/rhs swap
-+-
 Reporter:  browniebroke |Owner:
 Type:   |  browniebroke
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"740feb48017e92d1edc11e2d9eba5cf8b9eea3af" 740feb48]:
 {{{
 #!CommitTicketReference repository=""
 revision="740feb48017e92d1edc11e2d9eba5cf8b9eea3af"
 [1.9.x] Fixed #25893 -- Corrected custom lookups example.

 Backport of ffcdb0b471d0afc72b42b0a2b0c0c4fb45d7b6b1 from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.8a82b5a1a1d5ed588f22f3f5b042b6b1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25893: Custom Lookups & Transform example lhs/rhs swap

[Django]

#25893: Custom Lookups & Transform example lhs/rhs swap
-+-
 Reporter:  browniebroke |Owner:
 Type:   |  browniebroke
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"ffcdb0b471d0afc72b42b0a2b0c0c4fb45d7b6b1" ffcdb0b]:
 {{{
 #!CommitTicketReference repository=""
 revision="ffcdb0b471d0afc72b42b0a2b0c0c4fb45d7b6b1"
 Fixed #25893 -- Corrected custom lookups example.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.b2731bb180becbe8e7fdfee7e7e927f3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25893: Custom Lookups & Transform example lhs/rhs swap

[Django]

#25893: Custom Lookups & Transform example lhs/rhs swap
-+-
 Reporter:  browniebroke |Owner:
 Type:   |  browniebroke
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by timgraham):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/5791 PR]

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.8ccabdfe8da157466d24b99daf8ad205%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25893: Custom Lookups & Transform example lhs/rhs swap

[Django]

#25893: Custom Lookups & Transform example lhs/rhs swap
-+-
 Reporter:  browniebroke |Owner:
 Type:   |  browniebroke
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by browniebroke):

 * owner:  nobody => browniebroke
 * status:  new => assigned


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.75d7c9e56a246ddca8688140aaa9ed92%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25893: Custom Lookups & Transform example lhs/rhs swap

[Django]

#25893: Custom Lookups & Transform example lhs/rhs swap
--+
 Reporter:  browniebroke  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by MoritzS):

 * needs_better_patch:   => 0
 * needs_docs:   => 0
 * version:  1.8 => master
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.8c74befb17cc692db3cbbd85d9d364c1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #25893: Custom Lookups & Transform example lhs/rhs swap

[Django]

#25893: Custom Lookups & Transform example lhs/rhs swap
--+
 Reporter:  browniebroke  |  Owner:  nobody
 Type:  Cleanup/optimization  | Status:  new
Component:  Documentation |Version:  1.8
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  1 |  UI/UX:  0
--+
 In the doc for lookups and transform, in the example on optimizing
 lookups:
 https://docs.djangoproject.com/en/1.9/howto/custom-lookups/#writing-an-
 efficient-abs-lt-lookup

 The paragraph after the code snippets confused me:

   There are a couple of notable things going on. First,
 AbsoluteValueLessThan isn’t calling process_lhs(). Instead it skips the
 transformation of the lhs done by AbsoluteValue and uses the original lhs.
 That is, we want to get 27 not ABS(27)

 I initially though that lhs and rhs were swapped, but after asking on the
 #django IRC channel, I was advised that the confusion come from the last
 sentence, which should actually refer to the left of the SQL, rather than
 the right side:

   That is, we want to get "experiments"."change" not
 ABS("experiments"."change")

 Happy to submit a PR if suggested solution is accepted.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/055.0e030a86c9b3f20e70adc1e31b2c4306%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.