Re: [Django] #25989: sitemap view picks lastmod from last supplied sitemap only

[Django]

#25989: sitemap view picks lastmod from last supplied sitemap only
-+-
 Reporter:  allixx   |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  contrib.sitemaps |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  sitemap lastmod  | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"002a4f72c46458514d97f7e54d4fd9416d89899d" 002a4f72]:
 {{{
 #!CommitTicketReference repository=""
 revision="002a4f72c46458514d97f7e54d4fd9416d89899d"
 Fixed #25989 -- Corrected sitemap's Last-Modified header to use the latest
 lastmod of all sitemaps.

 Previously, the lastmod of the last sitemap was always used.
 All sitemaps are required to have a lastmod.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.e2d6e405eb57365f3734e49949ccc9da%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25989: sitemap view picks lastmod from last supplied sitemap only

[Django]

#25989: sitemap view picks lastmod from last supplied sitemap only
-+-
 Reporter:  allixx   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.sitemaps |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  sitemap lastmod  | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by timgraham):

 I think this isn't a critical bug to backport. The sitemap Last-Modified
 header functionality is new in Django 1.7 -- if it had been reported
 shortly after that release it would be easier to justify a backport.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.9de57d1dbcf00bcf556f65e044236524%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25989: sitemap view picks lastmod from last supplied sitemap only

[Django]

#25989: sitemap view picks lastmod from last supplied sitemap only
-+-
 Reporter:  allixx   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.sitemaps |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  sitemap lastmod  | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by xblitz):

 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.229c54e92759bf9fabd58bc10a4b754f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25989: sitemap view picks lastmod from last supplied sitemap only

[Django]

#25989: sitemap view picks lastmod from last supplied sitemap only
--+
 Reporter:  allixx|Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  contrib.sitemaps  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  sitemap lastmod   | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by allixx):

 * needs_tests:  1 => 0


Comment:

 Tests added to pull request.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.1920790c14cf9fc58b1f0a73db0b3515%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25989: sitemap view picks lastmod from last supplied sitemap only

[Django]

#25989: sitemap view picks lastmod from last supplied sitemap only
--+
 Reporter:  allixx|Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  contrib.sitemaps  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  sitemap lastmod   | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  1 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by allixx):

 I'm working on adding the tests.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.4d1d738a8c555ef1ff27f296fdb7219d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25989: sitemap view picks lastmod from last supplied sitemap only

[Django]

#25989: sitemap view picks lastmod from last supplied sitemap only
--+
 Reporter:  allixx|Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  contrib.sitemaps  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  sitemap lastmod   | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  1 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by allixx):

 * needs_tests:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.a1ddf5449a18ef9ad7f298d27c4a4613%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25989: sitemap view picks lastmod from last supplied sitemap only

[Django]

#25989: sitemap view picks lastmod from last supplied sitemap only
--+
 Reporter:  allixx|Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  contrib.sitemaps  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  sitemap lastmod   | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by allixx):

 * needs_tests:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.8be012c38363f438364e162d14670f8d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25989: sitemap view picks lastmod from last supplied sitemap only

[Django]

#25989: sitemap view picks lastmod from last supplied sitemap only
--+
 Reporter:  allixx|Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  contrib.sitemaps  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  sitemap lastmod   | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  1 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * needs_better_patch:   => 0
 * has_patch:  0 => 1
 * stage:  Unreviewed => Accepted
 * needs_tests:   => 1
 * needs_docs:   => 0


Comment:

 Please uncheck "Needs tests" if you can add them to the
 [https://github.com/django/django/pull/5877 pull request].

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.7c67c58c8fc6b53a2f67d9ad4aefbce0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #25989: sitemap view picks lastmod from last supplied sitemap only

[Django]

#25989: sitemap view picks lastmod from last supplied sitemap only
--+-
 Reporter:  allixx|  Owner:  nobody
 Type:  Bug   | Status:  new
Component:  contrib.sitemaps  |Version:  master
 Severity:  Normal|   Keywords:  sitemap lastmod
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  0 |  UI/UX:  0
--+-
 When passing several sitemaps as a parameter to sitemap view, only last
 sitemap's lastmod is used for 'Last-Modified' response header.

 Maximum lastmod should be picked from all passed sitemaps lasmods instead.

 The same problem exists in 1.8 and 1.9.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/049.f61713ae2d9319bd45098899f9e113af%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25989: sitemap view picks lastmod from last supplied sitemap only

[Django]

#25989: sitemap view picks lastmod from last supplied sitemap only
--+
 Reporter:  allixx|  Owner:  nobody
 Type:  Bug   | Status:  new
Component:  contrib.sitemaps  |Version:  master
 Severity:  Normal| Resolution:
 Keywords:  sitemap lastmod   |   Triage Stage:  Unreviewed
Has patch:  0 |  Easy pickings:  0
UI/UX:  0 |
--+
Changes (by allixx):

 * Attachment "views.py.diff" added.

 django/contrib/sitemaps/views.py

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.8f2d7a751c00eb76ad2ee07cb3a0136a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.