Re: [Django] #26005: uri_to_iri() perfoms percent decoding incorrectly

[Django]

#26005: uri_to_iri() perfoms percent decoding incorrectly
---+-
 Reporter:  Chronial   |Owner:  varun naganathan
 Type:  Bug|   Status:  closed
Component:  Utilities  |  Version:  1.8
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Ready for checkin
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"03281d8fe7a32f580a85235659d4fbb143eeb867" 03281d8]:
 {{{
 #!CommitTicketReference repository=""
 revision="03281d8fe7a32f580a85235659d4fbb143eeb867"
 Fixed #26005 -- Fixed some percent decoding cases in uri_to_iri().
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.0baea3dd79479d719e9fdd4a4e5dc22c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26005: uri_to_iri() perfoms percent decoding incorrectly

[Django]

#26005: uri_to_iri() perfoms percent decoding incorrectly
---+-
 Reporter:  Chronial   |Owner:  varun naganathan
 Type:  Bug|   Status:  assigned
Component:  Utilities  |  Version:  1.8
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Ready for checkin
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-
Changes (by Tim Graham):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.7d08a4387314946358612278d8e4c99c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26005: uri_to_iri() perfoms percent decoding incorrectly

[Django]

#26005: uri_to_iri() perfoms percent decoding incorrectly
---+---
 Reporter:  Chronial   |Owner:  varunnaganathan
 Type:  Bug|   Status:  assigned
Component:  Utilities  |  Version:  1.8
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+---

Comment (by Chronial):

 Replying to [comment:8 phildini]:
 > Setting the 'patch_needs_improvement' bit as there are failing checks
 and open questions on the PR.

 What are the open questions?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.31d10bcacdc635a5471ede687c96881e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26005: uri_to_iri() perfoms percent decoding incorrectly

[Django]

#26005: uri_to_iri() perfoms percent decoding incorrectly
---+---
 Reporter:  Chronial   |Owner:  varunnaganathan
 Type:  Bug|   Status:  assigned
Component:  Utilities  |  Version:  1.8
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+---
Changes (by phildini):

 * needs_better_patch:  0 => 1


Comment:

 Setting the 'patch_needs_improvement' bit as there are failing checks and
 open questions on the PR.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.dd8bb6ccfe29a412b65d077156e853a1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26005: uri_to_iri() perfoms percent decoding incorrectly

[Django]

#26005: uri_to_iri() perfoms percent decoding incorrectly
---+---
 Reporter:  Chronial   |Owner:  varunnaganathan
 Type:  Bug|   Status:  assigned
Component:  Utilities  |  Version:  1.8
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+---
Changes (by timgraham):

 * has_patch:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.c1e00aa46f0014b9dbeba4463492e23f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26005: uri_to_iri() perfoms percent decoding incorrectly

[Django]

#26005: uri_to_iri() perfoms percent decoding incorrectly
---+---
 Reporter:  Chronial   |Owner:  varunnaganathan
 Type:  Bug|   Status:  assigned
Component:  Utilities  |  Version:  1.8
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+---

Comment (by Chronial):

 New PR against master: https://github.com/django/django/pull/6428. I also
 didn't foresee what that this fix would affect the testing infrastructure
 so I didn't run the whole test suite last time. Now everything should
 work.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.ee0767c65cf0c4e35a551f88f052dc99%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26005: uri_to_iri() perfoms percent decoding incorrectly

[Django]

#26005: uri_to_iri() perfoms percent decoding incorrectly
---+---
 Reporter:  Chronial   |Owner:  varunnaganathan
 Type:  Bug|   Status:  assigned
Component:  Utilities  |  Version:  1.8
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+---

Comment (by Chronial):

 @timgraham I created A PR against 1.8.x:
 https://github.com/django/django/pull/6426

 This now correctly implements the algorithm from the RFC, except for step
 4: The implementation is supposed to re-encode some unicode characters
 “that are not appropriate” for IRIs. I added a note about that to the
 docstring.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.af7dfd1ce0269be132d0749ea169a63e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26005: uri_to_iri() perfoms percent decoding incorrectly

[Django]

#26005: uri_to_iri() perfoms percent decoding incorrectly
---+---
 Reporter:  Chronial   |Owner:  varunnaganathan
 Type:  Bug|   Status:  assigned
Component:  Utilities  |  Version:  1.8
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+---

Comment (by varunnaganathan):

 Created a trial Pull Request
 https://github.com/django/django/pull/6085
 Please review

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.eb83083c6e330547cc2eff5b7a5684f8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26005: uri_to_iri() perfoms percent decoding incorrectly

[Django]

#26005: uri_to_iri() perfoms percent decoding incorrectly
---+---
 Reporter:  Chronial   |Owner:  varunnaganathan
 Type:  Bug|   Status:  assigned
Component:  Utilities  |  Version:  1.8
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+---

Comment (by varunnaganathan):

 Also I have a doubt regarding the RFC guidelines.When RFC 3987 states that
 the percent  encoding corresponding to '%' i.e. '%25' must not be
 converted to its octet , does that mean that uri_to_iri("%2525") should
 return %2525 only as the result?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.36a686221ddc5ee940173c90739b2843%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26005: uri_to_iri() perfoms percent decoding incorrectly

[Django]

#26005: uri_to_iri() perfoms percent decoding incorrectly
---+---
 Reporter:  Chronial   |Owner:  varunnaganathan
 Type:  Bug|   Status:  assigned
Component:  Utilities  |  Version:  1.8
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+---
Changes (by varunnaganathan):

 * status:  new => assigned
 * owner:  nobody => varunnaganathan


Comment:

 Hi,i wanted to work on this.Added a small tweak to avoid converting the
 percent encoding for '%' i.e. '%25'.basically I'm replacing all instances
 of '%25' in the uri string with '%'.I tried a few tests and they seem to
 work.Do let me know if that's fine.I'll organize the code and post a PR.
 I'm pretty new to contributing to django so I'm sorry if I wasn't suppose
 to self assign this bug.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.707c31a9c16626c00e3b2cb3be8a9f6f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26005: uri_to_iri() perfoms percent decoding incorrectly (was: uri_to_iri() broken)

[Django]

#26005: uri_to_iri() perfoms percent decoding incorrectly
---+
 Reporter:  Chronial   |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Utilities  |  Version:  1.8
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by timgraham):

 * needs_better_patch:   => 0
 * component:  Core (URLs) => Utilities
 * needs_tests:   => 0
 * version:  1.9 => 1.8
 * needs_docs:   => 0
 * type:  Uncategorized => Bug
 * stage:  Unreviewed => Accepted


Comment:

 If you could provide a patch soon, we might backport it to 1.8 given this
 function was introduced there.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.4cab5ffab3876b159b2eb7a8313024ba%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.