Re: [Django] #26006: SingleObjectMixin.get_context_object_name refers to obj and self.object inconsistently

[Django]

#26006: SingleObjectMixin.get_context_object_name refers to obj and self.object
inconsistently
--+
 Reporter:  chmarr|Owner:  chmarr
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Generic views |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by chmarr):

 My first commit! I am so proud! 

 Also, I see you caught the extraneous dot in the release notes. Almost
 nothing gets by you!

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.e0140bfc2facaa9f6c4b1a2e5297%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26006: SingleObjectMixin.get_context_object_name refers to obj and self.object inconsistently

[Django]

#26006: SingleObjectMixin.get_context_object_name refers to obj and self.object
inconsistently
--+
 Reporter:  chmarr|Owner:  chmarr
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Generic views |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Tim Graham ):

 In [changeset:"4d9b98616f2d8b98946fdc752cc40f4283baf105" 4d9b986]:
 {{{
 #!CommitTicketReference repository=""
 revision="4d9b98616f2d8b98946fdc752cc40f4283baf105"
 [1.9.x] Fixed #26006 -- Fixed incorrect object reference in
 SingleObjectMixin.get_context_object_name().

 Backport of 4b2dcfe04f5d9938e40c569ffdd169f3a712145d from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.c81aa87042795af2bd223456fc8b9603%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26006: SingleObjectMixin.get_context_object_name refers to obj and self.object inconsistently

[Django]

#26006: SingleObjectMixin.get_context_object_name refers to obj and self.object
inconsistently
--+
 Reporter:  chmarr|Owner:  chmarr
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Generic views |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"4b2dcfe04f5d9938e40c569ffdd169f3a712145d" 4b2dcfe]:
 {{{
 #!CommitTicketReference repository=""
 revision="4b2dcfe04f5d9938e40c569ffdd169f3a712145d"
 Fixed #26006 -- Fixed incorrect object reference in
 SingleObjectMixin.get_context_object_name().
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.794274f924d4e745c525ddb2a67d1c43%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26006: SingleObjectMixin.get_context_object_name refers to obj and self.object inconsistently

[Django]

#26006: SingleObjectMixin.get_context_object_name refers to obj and self.object
inconsistently
--+
 Reporter:  chmarr|Owner:  chmarr
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Generic views |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by chmarr):

 * needs_better_patch:  1 => 0
 * needs_tests:  1 => 0


Comment:

 Pull request updated: https://github.com/django/django/pull/5890

 Unit test added. Release notes updated. Still passes all tests.
 Documentation compiles without error.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.8a00061ae5342dde15c4129e9e102cca%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26006: SingleObjectMixin.get_context_object_name refers to obj and self.object inconsistently

[Django]

#26006: SingleObjectMixin.get_context_object_name refers to obj and self.object
inconsistently
--+
 Reporter:  chmarr|Owner:  chmarr
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Generic views |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  1 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+

Comment (by chmarr):

 Thank you for the link to the changes. I'll set up a test case.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.ad3f3da605d5b43c4d7b9d6ad9b3d776%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26006: SingleObjectMixin.get_context_object_name refers to obj and self.object inconsistently

[Django]

#26006: SingleObjectMixin.get_context_object_name refers to obj and self.object
inconsistently
--+
 Reporter:  chmarr|Owner:  chmarr
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Generic views |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  1 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by charettes):

 * needs_better_patch:  0 => 1
 * version:  1.9 => master
 * needs_tests:  0 => 1


Comment:

 The change makes sense.

 This should be good to go once you add a regression test or adjust
 
[https://github.com/chmarr/django/commit/86aaffa5a3510c007167d116cf4ad72b79e93f31
 the ones added by this check].

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.5d310daf6b266b21b2816a44079d165c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26006: SingleObjectMixin.get_context_object_name refers to obj and self.object inconsistently

[Django]

#26006: SingleObjectMixin.get_context_object_name refers to obj and self.object
inconsistently
--+
 Reporter:  chmarr|Owner:  chmarr
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Generic views |  Version:  1.9
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by chmarr):

 * stage:  Unreviewed => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.cb7b5d185426ce5808f307a4194dc6b7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26006: SingleObjectMixin.get_context_object_name refers to obj and self.object inconsistently

[Django]

#26006: SingleObjectMixin.get_context_object_name refers to obj and self.object
inconsistently
-+-
 Reporter:  chmarr   |Owner:  chmarr
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Generic views|  Version:  1.9
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by chmarr):

 * owner:  nobody => chmarr
 * status:  new => assigned
 * has_patch:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.7a39b7d3afd2094412fbf98d090eb2a9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26006: SingleObjectMixin.get_context_object_name refers to obj and self.object inconsistently

[Django]

#26006: SingleObjectMixin.get_context_object_name refers to obj and self.object
inconsistently
-+-
 Reporter:  chmarr   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Generic views|  Version:  1.9
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by chmarr):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 Pull request: https://github.com/django/django/pull/5890

 All tests pass under SQLite.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.9dac2ab9d126ca5ef44cff2ae6d5d049%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #26006: SingleObjectMixin.get_context_object_name refers to obj and self.object inconsistently

[Django]

#26006: SingleObjectMixin.get_context_object_name refers to obj and self.object
inconsistently
--+
 Reporter:  chmarr|  Owner:  nobody
 Type:  Cleanup/optimization  | Status:  new
Component:  Generic views |Version:  1.9
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  0 |  UI/UX:  0
--+
 The method SingleObjectMixin.get_context_object_name refers to the 'obj'
 parameter several times, but in one instance refers to self.object in a
 seemingly inconsistent manner.

 This is probably not causing a problem, yet, since the descendant class,
 typically BaseDetailView, is setting self.object, and
 SingleObjectMixin.get_context_data simply calls
 self.get_context_object_name(self.object), so the two are _usually_ the
 same object.

 Trivial bug, and trivial fix. I'll create a pull request. Test suite
 passes both before and after the change.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/049.83db4480e3d2d0b33756dbd1bf178495%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.