Re: [Django] #26024: ConditionalGetMiddleware's ETag is broken

[Django]

#26024: ConditionalGetMiddleware's ETag is broken
-+-
 Reporter:  samifahed|Owner:  samifahed
 Type:  Bug  |   Status:  closed
Component:  Core (Cache system)  |  Version:  1.9
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  Etags| Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"ee2835e69c47d02e8bce5a496bf8bd9f93b04fb4" ee2835e6]:
 {{{
 #!CommitTicketReference repository=""
 revision="ee2835e69c47d02e8bce5a496bf8bd9f93b04fb4"
 [1.9.x] Fixed #26024 -- Fixed regression in ConditionalGetMiddleware ETag
 support.

 Backport of 186b6c61bfe85afa4d6bf213d04a28dd2853fed2 from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.67911148ef70e68b619224071e3dc204%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26024: ConditionalGetMiddleware's ETag is broken

[Django]

#26024: ConditionalGetMiddleware's ETag is broken
-+-
 Reporter:  samifahed|Owner:  samifahed
 Type:  Bug  |   Status:  closed
Component:  Core (Cache system)  |  Version:  1.9
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  Etags| Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"186b6c61bfe85afa4d6bf213d04a28dd2853fed2" 186b6c61]:
 {{{
 #!CommitTicketReference repository=""
 revision="186b6c61bfe85afa4d6bf213d04a28dd2853fed2"
 Fixed #26024 -- Fixed regression in ConditionalGetMiddleware ETag support.

 Thanks Denis Cornehl for help with the patch.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.70b038fb6a55b83251ef370f32203b97%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26024: ConditionalGetMiddleware's ETag is broken

[Django]

#26024: ConditionalGetMiddleware's ETag is broken
-+-
 Reporter:  samifahed|Owner:  samifahed
 Type:  Bug  |   Status:  new
Component:  Core (Cache system)  |  Version:  1.9
 Severity:  Release blocker  |   Resolution:
 Keywords:  Etags| Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * severity:  Normal => Release blocker
 * stage:  Unreviewed => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.ac27ba697e34af76148e8e4badaa9fde%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26024: ConditionalGetMiddleware's ETag is broken

[Django]

#26024: ConditionalGetMiddleware's ETag is broken
-+-
 Reporter:  samifahed|Owner:  samifahed
 Type:  Bug  |   Status:  new
Component:  Core (Cache system)  |  Version:  1.9
 Severity:  Normal   |   Resolution:
 Keywords:  Etags| Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by samifahed):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Old description:

> ETag support is broken in ConditionalGetMiddleware
>
> django.utils.cache.get_conditional_response's etag argument needs to be
> *unquoted*, however the etag passed by CommonMiddleware's make_response
> is quoted or the GZipMiddleware is modifying it while keeping it quoted.

New description:

 ETag support is broken in ConditionalGetMiddleware

 django.utils.cache.get_conditional_response's etag argument needs to be
 *unquoted*, however the etag passed by CommonMiddleware's make_response is
 quoted or the GZipMiddleware is modifying it while keeping it quoted.

 Pull request with Regression Test:
 https://github.com/django/django/pull/5919

--

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.07e43a07231f93c3d4d7f07521fffc28%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #26024: ConditionalGetMiddleware's ETag is broken

[Django]

#26024: ConditionalGetMiddleware's ETag is broken
-+---
 Reporter:  samifahed|  Owner:  samifahed
 Type:  Bug  | Status:  new
Component:  Core (Cache system)  |Version:  1.9
 Severity:  Normal   |   Keywords:  Etags
 Triage Stage:  Unreviewed   |  Has patch:  1
Easy pickings:  0|  UI/UX:  0
-+---
 ETag support is broken in ConditionalGetMiddleware

 django.utils.cache.get_conditional_response's etag argument needs to be
 *unquoted*, however the etag passed by CommonMiddleware's make_response is
 quoted or the GZipMiddleware is modifying it while keeping it quoted.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.63ee34431f542868d2ecfed53ed4c459%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.