Re: [Django] #26126: Transient failure of requests.tests.RequestsTests.test_max_age_expiration

[Django]

#26126: Transient failure of 
requests.tests.RequestsTests.test_max_age_expiration
-+-
 Reporter:  charettes|Owner:
 Type:   |  berkerpeksag
  Cleanup/optimization   |   Status:  closed
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"33b5bb79308c26615f55dc5eef85deb25f741ce2" 33b5bb79]:
 {{{
 #!CommitTicketReference repository=""
 revision="33b5bb79308c26615f55dc5eef85deb25f741ce2"
 [1.9.x] Fixed #26126 -- Fixed transient failure of test_max_age_expiration

 Backport of b17a9150a0c3a132e82b53755ede62a45f897875 from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.55a6f7901c937118dac2eed6876f4baa%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26126: Transient failure of requests.tests.RequestsTests.test_max_age_expiration

[Django]

#26126: Transient failure of 
requests.tests.RequestsTests.test_max_age_expiration
-+-
 Reporter:  charettes|Owner:
 Type:   |  berkerpeksag
  Cleanup/optimization   |   Status:  closed
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"927f43ea3add3cf92856c447bb021b59b22603df" 927f43ea]:
 {{{
 #!CommitTicketReference repository=""
 revision="927f43ea3add3cf92856c447bb021b59b22603df"
 [1.8.x] Fixed #26126 -- Fixed transient failure of test_max_age_expiration

 Backport of b17a9150a0c3a132e82b53755ede62a45f897875 from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.b5b5030821ad1267bcfe86650706bfcf%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26126: Transient failure of requests.tests.RequestsTests.test_max_age_expiration

[Django]

#26126: Transient failure of 
requests.tests.RequestsTests.test_max_age_expiration
-+-
 Reporter:  charettes|Owner:
 Type:   |  berkerpeksag
  Cleanup/optimization   |   Status:  closed
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"b17a9150a0c3a132e82b53755ede62a45f897875" b17a9150]:
 {{{
 #!CommitTicketReference repository=""
 revision="b17a9150a0c3a132e82b53755ede62a45f897875"
 Fixed #26126 -- Fixed transient failure of test_max_age_expiration
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.018e48fe1bd628cc2c9517af919a3ca7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26126: Transient failure of requests.tests.RequestsTests.test_max_age_expiration

[Django]

#26126: Transient failure of 
requests.tests.RequestsTests.test_max_age_expiration
-+-
 Reporter:  charettes|Owner:
 Type:   |  berkerpeksag
  Cleanup/optimization   |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.cc8bfa515b518579bbc6f634cf1c4254%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26126: Transient failure of requests.tests.RequestsTests.test_max_age_expiration

[Django]

#26126: Transient failure of 
requests.tests.RequestsTests.test_max_age_expiration
-+-
 Reporter:  charettes|Owner:
 Type:   |  berkerpeksag
  Cleanup/optimization   |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by berkerpeksag):

 * needs_better_patch:  1 => 0


Comment:

 Yes, `freeze_time()` is a better solution. I've updated the PR to use
 `freeze_time()`. Thanks!

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.496c62aa01ca6edd9dc58cae6e68ed7e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26126: Transient failure of requests.tests.RequestsTests.test_max_age_expiration

[Django]

#26126: Transient failure of 
requests.tests.RequestsTests.test_max_age_expiration
-+-
 Reporter:  charettes|Owner:
 Type:   |  berkerpeksag
  Cleanup/optimization   |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * needs_better_patch:  0 => 1


Comment:

 As noted on the PR, can `django.test.utils.freeze_time()` help?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.b549cba6a2683e00a241b5732a0228e7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26126: Transient failure of requests.tests.RequestsTests.test_max_age_expiration

[Django]

#26126: Transient failure of 
requests.tests.RequestsTests.test_max_age_expiration
-+-
 Reporter:  charettes|Owner:
 Type:   |  berkerpeksag
  Cleanup/optimization   |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by berkerpeksag):

 * cc: berker.peksag@… (added)
 * owner:  nobody => berkerpeksag
 * has_patch:  0 => 1
 * status:  new => assigned


Comment:

 Pull request: https://github.com/django/django/pull/6130

 Alternative solutions:

 * Make assertEqual check less strict: Don't check for the exact return
 value of `cookie_date()`.
 * Convert assertEqual to assertIn and check if the return value is
 `time.time() + 10 + 1` or `time.time() + 10 - 1`. This is simpler than the
 first solution.
 * Mock `cookie_date()` in `HttpResponseBase.set_cookie()`.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.416769a2c0653db1190914c8b0e6f9d6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #26126: Transient failure of requests.tests.RequestsTests.test_max_age_expiration

[Django]

#26126: Transient failure of 
requests.tests.RequestsTests.test_max_age_expiration
+
   Reporter:  charettes |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  Testing framework |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Accepted  |  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 {{{
 Traceback (most recent call last):
   File "/home/jenkins/workspace/pull-requests-
 trusty/database/postgis/label/trusty-
 pr/python/python2.7/tests/requests/tests.py", line 240, in
 test_max_age_expiration
 self.assertEqual(max_age_cookie['expires'], cookie_date(time.time() +
 10))
 AssertionError: u'Fri, 22-Jan-2016 19:44:54 GMT' != u'Fri, 22-Jan-2016
 19:44:55 GMT'
 - Fri, 22-Jan-2016 19:44:54 GMT
 ? ^
 + Fri, 22-Jan-2016 19:44:55 GMT
 ? ^
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.0ba385b8af1e83e637a69aab4240a4ad%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.