Re: [Django] #26175: Use create_user() managers in tests instead of hardcoding sha1 hashes

[Django]

#26175: Use create_user() managers in tests instead of hardcoding sha1 hashes
-+-
 Reporter:  timgraham|Owner:  timgraham
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"015fad9060a8a6fb273a33b8e8457e504ed26131" 015fad9]:
 {{{
 #!CommitTicketReference repository=""
 revision="015fad9060a8a6fb273a33b8e8457e504ed26131"
 Fixed #26175 -- Removed SHA1 password hashes in tests.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.93bf10be9c66090886aa0396a876ae38%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26175: Use create_user() managers in tests instead of hardcoding sha1 hashes

[Django]

#26175: Use create_user() managers in tests instead of hardcoding sha1 hashes
-+-
 Reporter:  timgraham|Owner:  timgraham
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by timgraham):

 * owner:  nobody => timgraham
 * status:  new => assigned


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.052d3e9f82cd690ef030c49a6e0dcac0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26175: Use create_user() managers in tests instead of hardcoding sha1 hashes

[Django]

#26175: Use create_user() managers in tests instead of hardcoding sha1 hashes
--+
 Reporter:  timgraham |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  contrib.admin |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by timgraham):

 * Attachment "26175.diff" added.


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.2fb5285434e1852ae0e194c0f795f1a1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #26175: Use create_user() managers in tests instead of hardcoding sha1 hashes

[Django]

#26175: Use create_user() managers in tests instead of hardcoding sha1 hashes
+
   Reporter:  timgraham |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  contrib.admin |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Accepted  |  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  1
  UI/UX:  0 |
+
 In 39a7eed1bbf12020a077e4bec3d82e08f171a021, some test fixtures were
 converted to use the ORM. This was a good step, but we still have
 hardcoded sha1 hashes which aren't friendly to reverse if you actually
 need the user's password.

 Also, the fixtures were converted programmatically and some fields from
 the fixtures aren't need in the ORM versions (such as `is_active=True`
 since that's the default).

 Most usage of `self.client.login(**credentials)` should be converted to
 `self.client.force_login(user)`.

 I attached a patch to get you started.

 Please check the selenium tests too.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.b836da487edd6851f5fe6737c54ba882%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.