subject:"\[Django\] #26179\: Remove null assignment check for non\-nullable foreign key fields"

Re: [Django] #26179: Remove null assignment check for non-nullable foreign key fields

2016-02-11 Thread Django

#26179: Remove null assignment check for non-nullable foreign key fields
-+-
 Reporter:  timgraham|Owner:
 Type:   |  ZachLiuGIS
  Cleanup/optimization   |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"04e13c89138d48c20e774a2b6bf06796f73ac0fe" 04e13c8]:
 {{{
 #!CommitTicketReference repository=""
 revision="04e13c89138d48c20e774a2b6bf06796f73ac0fe"
 Fixed #26179 -- Removed null assignment check for non-nullable foreign key
 fields.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.67d759bbcee5c4c5d72ded5265eb8d53%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26179: Remove null assignment check for non-nullable foreign key fields

2016-02-11 Thread Django

#26179: Remove null assignment check for non-nullable foreign key fields
-+-
 Reporter:  timgraham|Owner:
 Type:   |  ZachLiuGIS
  Cleanup/optimization   |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by timgraham):

 * needs_better_patch:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.370022099e3f623fc0037f1634813070%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26179: Remove null assignment check for non-nullable foreign key fields

2016-02-10 Thread Django

#26179: Remove null assignment check for non-nullable foreign key fields
-+-
 Reporter:  timgraham|Owner:
 Type:   |  ZachLiuGIS
  Cleanup/optimization   |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-

Comment (by ZachLiuGIS):

 Thanks for the help. I have updated the pull request (tests for None
 allowed) and also the backwards-incompatible changes in 1.10.txt.

 will remember to update the ticket going forward.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.a1972f0454b452989ddee4b15d857a00%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26179: Remove null assignment check for non-nullable foreign key fields

2016-02-10 Thread Django

#26179: Remove null assignment check for non-nullable foreign key fields
-+-
 Reporter:  timgraham|Owner:
 Type:   |  ZachLiuGIS
  Cleanup/optimization   |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-
Changes (by timgraham):

 * needs_better_patch:  0 => 1
 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/6115 PR] (please add a link like
 this in the future)

 You should also check "Has patch" on the ticket so it appears in the
 review queue. Since I left some comments for improvement on the pull
 request, I'll mark "Patch needs improvement." Please uncheck it after you
 update the pull request. Thanks!

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.3d93047179c678929dc4d061481acd36%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26179: Remove null assignment check for non-nullable foreign key fields

2016-02-10 Thread Django

#26179: Remove null assignment check for non-nullable foreign key fields
-+-
 Reporter:  timgraham|Owner:
 Type:   |  ZachLiuGIS
  Cleanup/optimization   |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by ZachLiuGIS):

 I have made the changes and created the pull request ticket_26179

 I removed both value=None check in `ForwardManyToOneDescriptor` and
 `ReverseOneToOneDescriptor`.

 Because of that, several tests failed because they have assertRaise for
 `ValueError`. So I removed those tests.

 This is my first time working on Django. So please let me know if there's
 anything I can do better:)

 Thanks.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.04146979404d603bb2c4eaf942a525bb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26179: Remove null assignment check for non-nullable foreign key fields

2016-02-09 Thread Django

#26179: Remove null assignment check for non-nullable foreign key fields
-+-
 Reporter:  timgraham|Owner:
 Type:   |  ZachLiuGIS
  Cleanup/optimization   |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by ZachLiuGIS):

 * owner:  nobody => ZachLiuGIS
 * status:  new => assigned


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.9dbf24b9138c1ab95c21c2ffebabeac8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26179: Remove null assignment check for non-nullable foreign key fields

2016-02-09 Thread Django

#26179: Remove null assignment check for non-nullable foreign key fields
-+-
 Reporter:  timgraham|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by timgraham):

 * easy:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.35f7c572eee7a36b21b3586ef50b0ec3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26179: Remove null assignment check for non-nullable foreign key fields

2016-02-05 Thread Django

#26179: Remove null assignment check for non-nullable foreign key fields
-+-
 Reporter:  timgraham|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by timgraham):

 A partial implementation of this is
 [https://github.com/django/django/pull/5658 on a pull request] for #25349.

 After this ticket is completed, we'll rebase that pull request and proceed
 with that fix.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.02ede20fc8fa4b8cbdc1ce4e8f9bd625%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #26179: Remove null assignment check for non-nullable foreign key fields

2016-02-05 Thread Django

#26179: Remove null assignment check for non-nullable foreign key fields
-+-
   Reporter:  timgraham  |  Owner:  nobody
   Type: | Status:  new
  Cleanup/optimization   |
  Component:  Database   |Version:  master
  layer (models, ORM)|
   Severity:  Normal |   Keywords:
   Triage Stage:  Accepted   |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 As raised in #25349 and [https://groups.google.com/d/topic/django-
 developers/4UL_FkDXX-w/discussion discussed on django-developers],  the
 following behavior should be removed:
 {{{
 >>> obj.fk = None
 ValueError('Cannot assign None: "Obj.fk" does not allow null values.)
 }}}
 (i.e. no more exception if you assign `None` to a non-nullable foreign
 key). It applies to `ForwardManyToOneDescriptor` and
 `ReverseOneToOneDescriptor`. The change should be documented in the
 "backwards-incompatible changes" section of the release notes.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.a026d1eeea3678e02200bd5e90f7346a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26179: Remove null assignment check for non-nullable foreign key fields

Re: [Django] #26179: Remove null assignment check for non-nullable foreign key fields

Re: [Django] #26179: Remove null assignment check for non-nullable foreign key fields

Re: [Django] #26179: Remove null assignment check for non-nullable foreign key fields

Re: [Django] #26179: Remove null assignment check for non-nullable foreign key fields

Re: [Django] #26179: Remove null assignment check for non-nullable foreign key fields

Re: [Django] #26179: Remove null assignment check for non-nullable foreign key fields

Re: [Django] #26179: Remove null assignment check for non-nullable foreign key fields

[Django] #26179: Remove null assignment check for non-nullable foreign key fields

9 matches

Site Navigation

Mail list logo

Footer information