Re: [Django] #26343: user_login_failed not fired on PermissionDenied

[Django]

#26343: user_login_failed not fired on PermissionDenied
--+---
 Reporter:  knbk  |Owner:  ieatkittens
 Type:  Bug   |   Status:  closed
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+---
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"ab8af342b1d5dbe40502f1adfe8c7a6b746c8004" ab8af342]:
 {{{
 #!CommitTicketReference repository=""
 revision="ab8af342b1d5dbe40502f1adfe8c7a6b746c8004"
 Fixed #26343 -- Sent user_login_failed signal if an auth backend raises
 PermissionDenied.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.81016e549f111336f093ffd9dbbb154b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26343: user_login_failed not fired on PermissionDenied

[Django]

#26343: user_login_failed not fired on PermissionDenied
--+---
 Reporter:  knbk  |Owner:  ieatkittens
 Type:  Bug   |   Status:  assigned
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+---
Changes (by ieatkittens):

 * needs_tests:  1 => 0


Comment:

 Regression test added!

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.3d23fb87341e0f212d06b7c3a7b0f840%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26343: user_login_failed not fired on PermissionDenied

[Django]

#26343: user_login_failed not fired on PermissionDenied
--+---
 Reporter:  knbk  |Owner:  ieatkittens
 Type:  Bug   |   Status:  assigned
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  1 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+---
Changes (by timgraham):

 * has_patch:  0 => 1
 * needs_tests:  0 => 1


Comment:

 When adding a link to the pull request, please check "Has patch". Please
 uncheck "Needs tests" when you update your pull request with one.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.3393ed0739acb8d07b43d545d87655e1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26343: user_login_failed not fired on PermissionDenied

[Django]

#26343: user_login_failed not fired on PermissionDenied
--+---
 Reporter:  knbk  |Owner:  ieatkittens
 Type:  Bug   |   Status:  assigned
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+---

Comment (by ieatkittens):

 Work is available at
 https://github.com/ieatkittens/django/tree/ticket_26343.  Docs build fine
 and tests pass under Postgresql.  First time contributing so please let me
 know if I am missing anything!

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.3ce1091e9f3b0eec23d658062828eda6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26343: user_login_failed not fired on PermissionDenied

[Django]

#26343: user_login_failed not fired on PermissionDenied
--+---
 Reporter:  knbk  |Owner:  ieatkittens
 Type:  Bug   |   Status:  assigned
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+---
Changes (by ieatkittens):

 * status:  new => assigned
 * owner:  nobody => ieatkittens


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.2c46b052634686233e33541915ac813b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26343: user_login_failed not fired on PermissionDenied

[Django]

#26343: user_login_failed not fired on PermissionDenied
--+
 Reporter:  knbk  |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by timgraham):

 * needs_docs:   => 0
 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.a74355268a279a793209bc30e23285a4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #26343: user_login_failed not fired on PermissionDenied

[Django]

#26343: user_login_failed not fired on PermissionDenied
--+
 Reporter:  knbk  |  Owner:  nobody
 Type:  Bug   | Status:  new
Component:  contrib.auth  |Version:  master
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  1 |  UI/UX:  0
--+
 If an authentication backend raises `PermissionDenied`, the
 `authenticate()` function will short-circuit, and fail to fire the
 `user_login_failed` signal.

 See
 
https://github.com/django/django/blob/34c56687ae4df2cff632447eddd7ef255ee74726/django/contrib/auth/__init__.py#L75

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/047.1599768aa7e51c9190955bc4b55cdb26%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.