Re: [Django] #26512: Add tests for the SpatialRefSysMixin.get_units() method

[Django]

#26512: Add tests for the SpatialRefSysMixin.get_units() method
--+
 Reporter:  timgraham |Owner:  niconoe
 Type:  Cleanup/optimization  |   Status:  closed
Component:  GIS   |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"23fbd3ff48a90b7e5d373b6fe50b65d1c48dabed" 23fbd3f]:
 {{{
 #!CommitTicketReference repository=""
 revision="23fbd3ff48a90b7e5d373b6fe50b65d1c48dabed"
 Fixed #26512 -- Added tests for SpatialRefSysMixin.get_units().
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.94448f6ab5d068e8958c1803e801c402%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26512: Add tests for the SpatialRefSysMixin.get_units() method

[Django]

#26512: Add tests for the SpatialRefSysMixin.get_units() method
--+
 Reporter:  timgraham |Owner:  niconoe
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  GIS   |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by niconoe):

 * has_patch:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.4942dc72a6288c4e1e829769e13ff432%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26512: Add tests for the SpatialRefSysMixin.get_units() method

[Django]

#26512: Add tests for the SpatialRefSysMixin.get_units() method
--+
 Reporter:  timgraham |Owner:  niconoe
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  GIS   |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by niconoe):

 Hi, I'm a new contributor and did my best here in my pull request.

 In addition to testing the class method, I updated the docstring since it
 was outdated and a bit vague IMHO and fixed a small issue with it: when
 GDAL was present, the unit was returned as a `float` (seems good), but as
 a string when GDAL was unavailable. It's now properly casted to a float in
 such cases.

 Cricticism is more than welcome!

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.d6db23a31387c4e908fe117dda4bd525%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26512: Add tests for the SpatialRefSysMixin.get_units() method

[Django]

#26512: Add tests for the SpatialRefSysMixin.get_units() method
--+
 Reporter:  timgraham |Owner:  niconoe
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  GIS   |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by niconoe):

 * owner:  nobody => niconoe
 * status:  new => assigned


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.5c73dec288e0556fdf10d7fa3a468dd7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #26512: Add tests for the SpatialRefSysMixin.get_units() method

[Django]

#26512: Add tests for the SpatialRefSysMixin.get_units() method
+
   Reporter:  timgraham |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  GIS   |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Accepted  |  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  1
  UI/UX:  0 |
+
 The method isn't covered by tests since it's unused since
 ae7cb577ddbea48aaed26cbbf69c77078a99e221. Claude said there's value in
 keeping the method around though.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.20d621ee974422b34093bc2b049bf18b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.