Re: [Django] #26640: class_prepared is not a ModelSignal and differs from documentation

[Django]

#26640: class_prepared is not a ModelSignal and differs from documentation
-+-
 Reporter:  AlexHill |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by AlexHill):

 I've added some comments in that ticket. I think deprecating the signal is
 probably a good idea.

 Would deprecating the `class_prepared` and fixing the issues in this
 ticket be mutually exclusive?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.3fbabdb86f5549cc71e48567ddfa5371%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26640: class_prepared is not a ModelSignal and differs from documentation

[Django]

#26640: class_prepared is not a ModelSignal and differs from documentation
-+-
 Reporter:  AlexHill |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * status:  new => closed
 * resolution:   => wontfix


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.f3857993d52f617c815ca25db248ac57%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26640: class_prepared is not a ModelSignal and differs from documentation

[Django]

#26640: class_prepared is not a ModelSignal and differs from documentation
-+-
 Reporter:  AlexHill |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 #24313 suggests to deprecated the `class_prepared` signal. Do you see a
 reason not to move forward with that instead?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.c3eb1677a364d327d7e7f132f5616032%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #26640: class_prepared is not a ModelSignal and differs from documentation

[Django]

#26640: class_prepared is not a ModelSignal and differs from documentation
--+
 Reporter:  AlexHill  |  Owner:  nobody
 Type:  Bug   | Status:  new
Component:  Database layer (models, ORM)  |Version:  master
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  1
Easy pickings:  0 |  UI/UX:  0
--+
 A few minor issues with class_prepared:

 1. it's documented as a model signal, and so able to be called with lazy
 references, but it isn't one and can't be.

 > Model signals sender model can be lazily referenced when connecting a
 receiver by specifying its full application label.

 2. it's documented as being sent after the model is registered, but it's
 actually sent just before

 > Sent whenever a model class has been “prepared” – that is, once model
 has been defined and registered with Django’s model system.

 In `ModelBase.__new__()`:

 {{{#!python
 ...
 new_class._prepare()  # class_prepared.send() is called at the end
 of this method
 new_class._meta.apps.register_model(new_class._meta.app_label,
 new_class)
 return new_class
 }}}

 3. it's instantiated with `providing_args=["class"]`, but it doesn't
 provide a `class` argument

 All three addressed in PR 6628.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.aa926fa04501ebc71917bca691908cf5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.