Re: [Django] #26656: Add timedelta support to DjangoJSONEncoder

[Django]

#26656: Add timedelta support to DjangoJSONEncoder
--+
 Reporter:  willhardy |Owner:  nobody
 Type:  New feature   |   Status:  closed
Component:  Core (Serialization)  |  Version:  1.9
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"8ef78b81654ebcf19a1fc241e2b1ede35100096b" 8ef78b8]:
 {{{
 #!CommitTicketReference repository=""
 revision="8ef78b81654ebcf19a1fc241e2b1ede35100096b"
 Fixed #26656 -- Added duration (timedelta) support to DjangoJSONEncoder.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.09517b60cfad539f32e4750be56fc1b5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26656: Add timedelta support to DjangoJSONEncoder

[Django]

#26656: Add timedelta support to DjangoJSONEncoder
--+
 Reporter:  willhardy |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  Core (Serialization)  |  Version:  1.9
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * needs_better_patch:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.d4551078a65070da2efdf7496d7b4092%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26656: Add timedelta support to DjangoJSONEncoder

[Django]

#26656: Add timedelta support to DjangoJSONEncoder
--+
 Reporter:  willhardy |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  Core (Serialization)  |  Version:  1.9
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * needs_better_patch:  0 => 1
 * stage:  Ready for checkin => Accepted


Comment:

 Now that #26704 is committed, we can update those docs for these changes.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.49dfd26a5f085a52cb34cdec03fc1347%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26656: Add timedelta support to DjangoJSONEncoder

[Django]

#26656: Add timedelta support to DjangoJSONEncoder
-+-
 Reporter:  willhardy|Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Core |  Version:  1.9
  (Serialization)|
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by willhardy):

 See https://code.djangoproject.com/ticket/26704 for the
 `DjangoJSONEncoder` documentation ticket.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.828c12e8bf169ef7062ca4fd1c49665b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26656: Add timedelta support to DjangoJSONEncoder

[Django]

#26656: Add timedelta support to DjangoJSONEncoder
-+-
 Reporter:  willhardy|Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Core |  Version:  1.9
  (Serialization)|
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by willhardy):

 `DjangoJSONEncoder` does not seem to be documented at all. I've added an
 entry to the release notes, and will open another ticket for the whole
 class to be documented.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.bd0eb1446568b02b3b681c64f8af56b2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26656: Add timedelta support to DjangoJSONEncoder

[Django]

#26656: Add timedelta support to DjangoJSONEncoder
-+-
 Reporter:  willhardy|Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Core |  Version:  1.9
  (Serialization)|
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by toffer):

 Looks good! Reviewed as part of the Django sprint at PyCon.

 `tests.serializers.test_json:test_timedelta` passes with the patch. It
 fails without the patch.

 The new `TestParseISODurationRoundtrip` tests look good.

 Does this need docs?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.574ca0542a3eba0040acc2d4a11fb20e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26656: Add timedelta support to DjangoJSONEncoder

[Django]

#26656: Add timedelta support to DjangoJSONEncoder
-+-
 Reporter:  willhardy|Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Core |  Version:  1.9
  (Serialization)|
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by chescales):

 * cc: chescales (added)
 * stage:  Accepted => Ready for checkin


Comment:

 I gave a look at the code, and seems to solve the problem. Adds support
 for ISO durations. Includes new tests which seem to cover most of the
 cases (replicates previous duration tests, with the new ISO format).

 Only thing is I am not able to tell if the format should be included
 anywhere in the official docs of the serializers or if it's not necessary.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.db23fdb519a9fb4dd2604601a18e3c82%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26656: Add timedelta support to DjangoJSONEncoder

[Django]

#26656: Add timedelta support to DjangoJSONEncoder
--+
 Reporter:  willhardy |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  Core (Serialization)  |  Version:  1.9
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * has_patch:  0 => 1
 * stage:  Unreviewed => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.c60cf3eb34b31b28de85c8894a79f293%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26656: Add timedelta support to DjangoJSONEncoder

[Django]

#26656: Add timedelta support to DjangoJSONEncoder
-+-
 Reporter:  willhardy|Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Core |  Version:  1.9
  (Serialization)|
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by willhardy):

 See [https://github.com/django/django/pull/6651 another PR], using a ISO
 8601 string instead of a float.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.7c0afda1f78acdc04ccd1ba441a076d5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26656: Add timedelta support to DjangoJSONEncoder

[Django]

#26656: Add timedelta support to DjangoJSONEncoder
-+-
 Reporter:  willhardy|Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Core |  Version:  1.9
  (Serialization)|
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * needs_better_patch:   => 0
 * type:  Uncategorized => New feature
 * component:  Uncategorized => Core (Serialization)
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 See [https://github.com/django/django/pull/6535 discussion on a PR].

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.00f5f78c570b5317e011dda9ab6098c9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #26656: Add timedelta support to DjangoJSONEncoder

[Django]

#26656: Add timedelta support to DjangoJSONEncoder
---+
 Reporter:  willhardy  |  Owner:  nobody
 Type:  Uncategorized  | Status:  new
Component:  Uncategorized  |Version:  1.9
 Severity:  Normal |   Keywords:
 Triage Stage:  Unreviewed |  Has patch:  0
Easy pickings:  0  |  UI/UX:  0
---+
 Currently `DjangoJSONEncoder` supports `datetime`, `date`, `time`,
 `Decimal` and `UUID` objects.

 But when the `DurationField` was added recently, no support for
 `timedelta` was added to the JSON encoder.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.14d834799cc077566fd03d08129c191e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.