Re: [Django] #26685: Implement Spatialite PtDistWithin() in GeoDjango

[Django]

#26685: Implement Spatialite PtDistWithin() in GeoDjango
-+-
 Reporter:  deed02392|Owner:
 |  kevswanberg
 Type:  New feature  |   Status:  closed
Component:  GIS  |  Version:  1.9
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  spatialite dwithin   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"35504f74a8c3b45d308969a77488d11443ce4348" 35504f74]:
 {{{
 #!CommitTicketReference repository=""
 revision="35504f74a8c3b45d308969a77488d11443ce4348"
 Fixed #26685 -- Added dwithin lookup support on SpatiaLite.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.03d52d568a4c444b1fe472d903b12a72%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26685: Implement Spatialite PtDistWithin() in GeoDjango

[Django]

#26685: Implement Spatialite PtDistWithin() in GeoDjango
-+-
 Reporter:  deed02392|Owner:
 |  kevswanberg
 Type:  New feature  |   Status:  assigned
Component:  GIS  |  Version:  1.9
 Severity:  Normal   |   Resolution:
 Keywords:  spatialite dwithin   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * needs_better_patch:  0 => 1
 * stage:  Ready for checkin => Accepted


Comment:

 Please bump back to RFC when those cleanups are addressed.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.76377ce8aef4723410d7bc2e38f715c3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26685: Implement Spatialite PtDistWithin() in GeoDjango

[Django]

#26685: Implement Spatialite PtDistWithin() in GeoDjango
-+-
 Reporter:  deed02392|Owner:
 |  kevswanberg
 Type:  New feature  |   Status:  assigned
Component:  GIS  |  Version:  1.9
 Severity:  Normal   |   Resolution:
 Keywords:  spatialite dwithin   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin


Comment:

 Looks good, pending a few cosmetic cleanups.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.1a3e67196426628b4dcd4b74d33af795%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26685: Implement Spatialite PtDistWithin() in GeoDjango

[Django]

#26685: Implement Spatialite PtDistWithin() in GeoDjango
-+-
 Reporter:  deed02392|Owner:
 |  kevswanberg
 Type:  New feature  |   Status:  assigned
Component:  GIS  |  Version:  1.9
 Severity:  Normal   |   Resolution:
 Keywords:  spatialite dwithin   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * needs_better_patch:  0 => 1


Comment:

 Comments for improvement are on the PR.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.d96cf0cd868f0bd2948a1af0b3526a63%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26685: Implement Spatialite PtDistWithin() in GeoDjango

[Django]

#26685: Implement Spatialite PtDistWithin() in GeoDjango
-+-
 Reporter:  deed02392|Owner:
 |  kevswanberg
 Type:  New feature  |   Status:  assigned
Component:  GIS  |  Version:  1.9
 Severity:  Normal   |   Resolution:
 Keywords:  spatialite dwithin   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by kevswanberg):

 * status:  new => assigned
 * owner:  nobody => kevswanberg
 * has_patch:  0 => 1
 * cc: kevswanberg@… (added)


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.3ae0f69e20e54ad10cb7dcc8341f9c20%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26685: Implement Spatialite PtDistWithin() in GeoDjango

[Django]

#26685: Implement Spatialite PtDistWithin() in GeoDjango
+
 Reporter:  deed02392   |Owner:  nobody
 Type:  New feature |   Status:  new
Component:  GIS |  Version:  1.9
 Severity:  Normal  |   Resolution:
 Keywords:  spatialite dwithin  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+
Changes (by timgraham):

 * needs_better_patch:   => 0
 * needs_docs:   => 0
 * needs_tests:   => 0
 * easy:  1 => 0
 * stage:  Unreviewed => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.8c3cf5d06b9870c2bff10d0e2a2a5de6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #26685: Implement Spatialite PtDistWithin() in GeoDjango

[Django]

#26685: Implement Spatialite PtDistWithin() in GeoDjango
-+
 Reporter:  deed02392|  Owner:  nobody
 Type:  New feature  | Status:  new
Component:  GIS  |Version:  1.9
 Severity:  Normal   |   Keywords:  spatialite dwithin
 Triage Stage:  Unreviewed   |  Has patch:  0
Easy pickings:  1|  UI/UX:  0
-+
 Spatialite has support for determining records which are within a
 specified distance of a specified point, in a geometry field, even with a
 geodetic coordinate system. This support is implemented using the
 PtDistWithin() function. To the contrary, GIS reports an error when
 attempting to perform this kind of lookup
 
(https://github.com/django/django/blob/master/django/contrib/gis/db/backends/spatialite/operations.py#L162).

 So GeoDjango does not implement it, instead requiring the user to use
 distance in degrees in these situations. Furthermore, the GeoDjango
 documentation states that Spatialite does not support 'dwithin', but that
 is simply because this function has not been mapped by the GIS project.
 https://docs.djangoproject.com/en/1.9/ref/contrib/gis/geoquerysets/#std
 :fieldlookup-dwithin

 Signed-off-by: George Hafiz 

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.197f21b3b88e6756558e264b307af747%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.