Re: [Django] #26909: UserAttributeSimilarityValidator has hardcoded reference to 'username' causing error in password reset built-in auth form when using a custom model

2016-07-22 Thread Django 
#26909: UserAttributeSimilarityValidator has hardcoded reference to 'username'
causing error in password reset built-in auth form when using a custom
model
--+
 Reporter:  kierenpitts   |Owner:  andrewnester
 Type:  Bug   |   Status:  assigned
Component:  contrib.auth  |  Version:  1.9
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * has_patch:  0 => 1
 * stage:  Unreviewed => Accepted


Comment:

 [https://github.com/django/django/pull/6962 PR]

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.ca04e8a5bf52d3b1d0cfbea25c22da09%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26909: UserAttributeSimilarityValidator has hardcoded reference to 'username' causing error in password reset built-in auth form when using a custom model

2016-07-22 Thread Django 
#26909: UserAttributeSimilarityValidator has hardcoded reference to 'username'
causing error in password reset built-in auth form when using a custom
model
--+
 Reporter:  kierenpitts   |Owner:  andrewnester
 Type:  Bug   |   Status:  assigned
Component:  contrib.auth  |  Version:  1.9
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Unreviewed
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by andrewnester):

 * status:  new => assigned
 * owner:  nobody => andrewnester


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.56f62b9c68bb671f4084ae0c23662078%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26909: UserAttributeSimilarityValidator has hardcoded reference to 'username' causing error in password reset built-in auth form when using a custom model

2016-07-19 Thread Django 
#26909: UserAttributeSimilarityValidator has hardcoded reference to 'username'
causing error in password reset built-in auth form when using a custom
model
--+--
 Reporter:  kierenpitts   |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  contrib.auth  |  Version:  1.9
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Unreviewed
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--

Comment (by timgraham):

 In your case, do you want the `username` property to be taken account for
 this validator? If so, then feel free to submit a patch to fix the crash.
 If not, then you should pass some custom `user_attributes` to the
 validator and I think we could close this and reopen if someone has the
 use case of validating similarity to properties.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.ef451369df6e54223999b031c16e29d6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26909: UserAttributeSimilarityValidator has hardcoded reference to 'username' causing error in password reset built-in auth form when using a custom model

2016-07-19 Thread Django 
#26909: UserAttributeSimilarityValidator has hardcoded reference to 'username'
causing error in password reset built-in auth form when using a custom
model
--+--
 Reporter:  kierenpitts   |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  contrib.auth  |  Version:  1.9
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Unreviewed
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--

Comment (by kierenpitts):

 Sorry, in our case the model has a 'username' property. So I guess the
 issue is that the initial check to see if User.username returns something
 is not consistent with the result of user._meta.get_field because the
 latter doesn't work with a @property set on the model. My apologies.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.e26bdbfa04973604a739c3048087c4a3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26909: UserAttributeSimilarityValidator has hardcoded reference to 'username' causing error in password reset built-in auth form when using a custom model

2016-07-19 Thread Django 
#26909: UserAttributeSimilarityValidator has hardcoded reference to 'username'
causing error in password reset built-in auth form when using a custom
model
--+--
 Reporter:  kierenpitts   |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  contrib.auth  |  Version:  1.9
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Unreviewed
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--

Comment (by timgraham):

 According to
 
[https://docs.djangoproject.com/en/1.9/topics/auth/passwords/#django.contrib.auth.password_validation.UserAttributeSimilarityValidator
 the UserAttributeSimilarityValidator documentation], "Attributes that
 don’t exist are ignored"
 
([https://github.com/django/django/blob/081fdaf110386db940d834ba51d93e23aa293fcd/django/contrib/auth/password_validation.py#L141-L143
 code]).

 Is `User.username` returning some non-empty value on your custom user
 model?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.4f97f1f45aa554e09113af8ee2975325%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26909: UserAttributeSimilarityValidator has hardcoded reference to 'username' causing error in password reset built-in auth form when using a custom model (was: UserAttributeSimilarityVa

2016-07-18 Thread Django 
#26909: UserAttributeSimilarityValidator has hardcoded reference to 'username'
causing error in password reset built-in auth form when using a custom
model
--+--
 Reporter:  kierenpitts   |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  contrib.auth  |  Version:  1.9
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Unreviewed
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by kierenpitts):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.47f1d2dea4272829d2df8235be0b8524%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.