Re: [Django] #26928: Change checkbox/radio checked attribute to HTML5 boolean style

[Django]

#26928: Change checkbox/radio checked attribute to HTML5 boolean style
--+
 Reporter:  jdufresne |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Forms |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"50e299dbfbbfd796e63e7e13b4566cf69d2c4acb" 50e299d]:
 {{{
 #!CommitTicketReference repository=""
 revision="50e299dbfbbfd796e63e7e13b4566cf69d2c4acb"
 Fixed #26928 -- Changed forms' checked attribute to HTML5 boolean style.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.b20233e7cc836cff3c9569f0b3f374b7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26928: Change checkbox/radio checked attribute to HTML5 boolean style

[Django]

#26928: Change checkbox/radio checked attribute to HTML5 boolean style
--+
 Reporter:  jdufresne |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Forms |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * stage:  Unreviewed => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.da313f3466c0797f2fcf7377316c6ef7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26928: Change checkbox/radio checked attribute to HTML5 boolean style

[Django]

#26928: Change checkbox/radio checked attribute to HTML5 boolean style
-+-
 Reporter:  jdufresne|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by jdufresne):

 [https://groups.google.com/forum/#!topic/django-developers/06FZAJooX6w
 Django developers thread]

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.333b715f5ffee97a4cef6c160772ba62%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26928: Change checkbox/radio checked attribute to HTML5 boolean style

[Django]

#26928: Change checkbox/radio checked attribute to HTML5 boolean style
-+-
 Reporter:  jdufresne|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by timgraham):

 I'd like to ask on the DevelopersMailingList if anyone has concerns about
 this change.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.9bdc8bc980663478430a66112b234ee8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26928: Change checkbox/radio checked attribute to HTML5 boolean style

[Django]

#26928: Change checkbox/radio checked attribute to HTML5 boolean style
-+-
 Reporter:  jdufresne|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by jdufresne):

 > Are there any backwards-compatibility concerns for projects not using an
 HTML5 doctype?

 I'm not aware of any for modern browsers. Just now, I tested the following
 HTML document:

 {{{
 
   
 Test
   
   
 
   
 
   
 
 }}}

 Against the doctypes listed on [https://www.w3.org/QA/2002/04/valid-dtd-
 list.html w3.org].

 All of these doctypes worked with recent versions of Firefox and Chrome --
 they rendered the checkbox as checked on page reload. I currently do not
 have easy access to IE for testing.

 If you think it would help, I could add a blurb to the "Backwards
 incompatible changes" section of the release notes.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.a82cb222712b9a4720923d58705667c7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26928: Change checkbox/radio checked attribute to HTML5 boolean style

[Django]

#26928: Change checkbox/radio checked attribute to HTML5 boolean style
-+-
 Reporter:  jdufresne|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by timgraham):

 `required` and `disabled` were added recently so I guess backwards-
 compatibility wasn't much of a concern. Are there any backwards-
 compatibility concerns for projects not using an HTML5 doctype?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.752ff54723f7653aef6d55f1a8e81f5b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #26928: Change checkbox/radio checked attribute to HTML5 boolean style

[Django]

#26928: Change checkbox/radio checked attribute to HTML5 boolean style
--+
 Reporter:  jdufresne |  Owner:  nobody
 Type:  Cleanup/optimization  | Status:  new
Component:  Forms |Version:  master
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  0 |  UI/UX:  0
--+
 As Django supports HTML5 boolean attributes and they are used for
 
[https://github.com/django/django/blob/bc1e9e823b7dd3fa68dc1678edeb09e2ae1a990c/django/forms/boundfield.py#L88-L91
 existing form attributes] internally, I think the checkbox/radio `checked`
 attribute should be converted to use HTML5 boolean style as well.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.ff4cde2e6f27160f2a1a805e6ed4eabd%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26928: Change checkbox/radio checked attribute to HTML5 boolean style

[Django]

#26928: Change checkbox/radio checked attribute to HTML5 boolean style
-+-
 Reporter:  jdufresne|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by jdufresne):

 * needs_docs:   => 0
 * has_patch:  0 => 1
 * needs_tests:   => 0
 * needs_better_patch:   => 0


Comment:

 [https://github.com/django/django/pull/6961 PR]

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.a7a07b0249fa230f7a3bdd7ccd29c570%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.