Re: [Django] #26936: Stale content type deletion stops working if all models in an app are deleted

[Django]

#26936: Stale content type deletion stops working if all models in an app are
deleted
-+-
 Reporter:  Baptiste Mispelon|Owner:  Pavel
 Type:  Bug  |   Status:  closed
Component:   |  Version:  1.9
  contrib.contenttypes   |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"874b1f2cac7b79597ce87cc244b7cefc5c5cd821" 874b1f2]:
 {{{
 #!CommitTicketReference repository=""
 revision="874b1f2cac7b79597ce87cc244b7cefc5c5cd821"
 Fixed #26936 -- Fixed stale ContentType deletion in apps without models.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.bb6d0bc33aede361bc208b1158dd810c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26936: Stale content type deletion stops working if all models in an app are deleted

[Django]

#26936: Stale content type deletion stops working if all models in an app are
deleted
-+-
 Reporter:  Baptiste Mispelon|Owner:  Pavel
 Type:  Bug  |   Status:  assigned
Component:   |  Version:  1.9
  contrib.contenttypes   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.0ef0f38f1a5c166545a31fe2d413a262%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26936: Stale content type deletion stops working if all models in an app are deleted

[Django]

#26936: Stale content type deletion stops working if all models in an app are
deleted
--+
 Reporter:  Baptiste Mispelon |Owner:  Pavel
 Type:  Bug   |   Status:  assigned
Component:  contrib.contenttypes  |  Version:  1.9
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Pavel):

 Updated the pull request according to code review remarks

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.12fef346784f10c1f79d95795c65e678%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26936: Stale content type deletion stops working if all models in an app are deleted

[Django]

#26936: Stale content type deletion stops working if all models in an app are
deleted
--+
 Reporter:  Baptiste Mispelon |Owner:  Pavel
 Type:  Bug   |   Status:  assigned
Component:  contrib.contenttypes  |  Version:  1.9
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Pavel):

 * needs_better_patch:  1 => 0


Comment:

 Fixed the isolation issues in [https://github.com/django/django/pull/8022
 PR]

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.53f03ae2ba6c32efb50e8fbcc44c7921%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26936: Stale content type deletion stops working if all models in an app are deleted

[Django]

#26936: Stale content type deletion stops working if all models in an app are
deleted
--+
 Reporter:  Baptiste Mispelon |Owner:  Pavel
 Type:  Bug   |   Status:  assigned
Component:  contrib.contenttypes  |  Version:  1.9
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham):

 * needs_better_patch:  0 => 1
 * has_patch:  0 => 1


Comment:

 The [https://github.com/django/django/pull/8022 PR] has some test
 isolation issues.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.7e4f66323d47a9ce2530a478bbcfde87%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26936: Stale content type deletion stops working if all models in an app are deleted

[Django]

#26936: Stale content type deletion stops working if all models in an app are
deleted
--+
 Reporter:  Baptiste Mispelon |Owner:  Pavel
 Type:  Bug   |   Status:  assigned
Component:  contrib.contenttypes  |  Version:  1.9
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Tim Graham):

 No, all pull requests should go to master. The committer will determine if
 it needs to be backported per our
 [https://docs.djangoproject.com/en/dev/internals/release-process
 /#supported-versions supported versions policy]. I don't think it would in
 this case.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.3bdfdb17261691805ab9f4e733a3aa15%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26936: Stale content type deletion stops working if all models in an app are deleted

[Django]

#26936: Stale content type deletion stops working if all models in an app are
deleted
--+
 Reporter:  Baptiste Mispelon |Owner:  Pavel
 Type:  Bug   |   Status:  assigned
Component:  contrib.contenttypes  |  Version:  1.9
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Pavel):

 * status:  new => assigned
 * owner:  nobody => Pavel


Comment:

 Hi,

 This issue is reported on version 1.9 but it also reproduces on later
 versions. Should I make the fix on every release starting with 1.9?

 Thanks

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.7d46599490f4cbfee86d41c02e472b15%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26936: Stale content type deletion stops working if all models in an app are deleted

[Django]

#26936: Stale content type deletion stops working if all models in an app are
deleted
--+
 Reporter:  bmispelon |Owner:
 Type:  Bug   |   Status:  new
Component:  contrib.contenttypes  |  Version:  1.9
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by bmispelon):

 * owner:  bmispelon =>
 * status:  assigned => new


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.cf2e8c610fe062377368663dcc06e3cc%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26936: Stale content type deletion stops working if all models in an app are deleted

[Django]

#26936: Stale content type deletion stops working if all models in an app are
deleted
-+-
 Reporter:  bmispelon|Owner:  bmispelon
 Type:  Bug  |   Status:  assigned
Component:   |  Version:  1.9
  contrib.contenttypes   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * stage:  Unreviewed => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.6f248cfb9cff5b415c148ccb30dbe287%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #26936: Stale content type deletion stops working if all models in an app are deleted

[Django]

#26936: Stale content type deletion stops working if all models in an app are
deleted
+
   Reporter:  bmispelon |  Owner:  nobody
   Type:  Bug   | Status:  new
  Component:  contrib.contenttypes  |Version:  1.9
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 Steps to reproduce:

 1) Create an app with one model in its `models.py`
 2) Add it to `settings.INSTALLED_APPS`, run `makemakigrations`, and
 `migrate`
 3) Delete the model from `models.py`, run `makemigrations`, then `migrate`



 At step 3), Django deletes the model from the database (as expected) but
 doesn't prompt the user to delete the now stale content type (as normally
 happens when you run `migrate`).


 I believe this is called by the `if not app_config.models_module: return`
 statement in `update_contenttypes()` [1]

 [1]
 
https://github.com/django/django/blob/master/django/contrib/contenttypes/management.py#L95-L96

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.0c07620e704028a773fa6d9b59fb99c0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26936: Stale content type deletion stops working if all models in an app are deleted

[Django]

#26936: Stale content type deletion stops working if all models in an app are
deleted
-+-
 Reporter:  bmispelon|Owner:  bmispelon
 Type:  Bug  |   Status:  assigned
Component:   |  Version:  1.9
  contrib.contenttypes   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by bmispelon):

 * owner:  nobody => bmispelon
 * status:  new => assigned


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.3eb02e721e9630c0f1981c0f2903578a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.