Re: [Django] #26940: django-admin makemessages vs. manage.py makemessages

[Django]

#26940: django-admin makemessages vs. manage.py makemessages
--+
 Reporter:  romeroqj  |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  Internationalization  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  translations  | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by claudep):

 * has_patch:  0 => 1
 * version:  1.9 => master


Comment:

 [https://github.com/django/django/pull/7040 PR]

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.7deffad7f281a86ed7e6f275707dd86c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26940: django-admin makemessages vs. manage.py makemessages

[Django]

#26940: django-admin makemessages vs. manage.py makemessages
--+
 Reporter:  romeroqj  |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  Internationalization  |  Version:  1.9
 Severity:  Normal|   Resolution:
 Keywords:  translations  | Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by claudep):

 * type:  Uncategorized => Bug
 * stage:  Unreviewed => Accepted


Comment:

 Currently, `makemessages` is explicitly whitelisted as not needing a
 configured settings file (see `no_settings_commands` in
 `django.core.management.__init__.py`.
 I wonder now if we should revert that, considering the dependency of that
 command on `settings.FILE_CHARSET`, `settings.LOCALE_PATHS`,
 `settings.MEDIA_ROOT`, and `settings.STATIC_ROOT`.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.b1a7407f7dc74ce7d8f22d08786b71c9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26940: django-admin makemessages vs. manage.py makemessages

[Django]

#26940: django-admin makemessages vs. manage.py makemessages
-+-
 Reporter:  romeroqj |Owner:  nobody
 Type:  Uncategorized|   Status:  new
Component:   |  Version:  1.9
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:  translations | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by charettes):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 Maybe the documentation should mention that `--settings` must be specified
 to `django-admin` and `python -m django` for them to be interchangeable
 with `manage.py`.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.4a77f39e6cb186e0f33029f170249d83%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #26940: django-admin makemessages vs. manage.py makemessages

[Django]

#26940: django-admin makemessages vs. manage.py makemessages
--+--
 Reporter:  romeroqj  |  Owner:  nobody
 Type:  Uncategorized | Status:  new
Component:  Internationalization  |Version:  1.9
 Severity:  Normal|   Keywords:  translations
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  0 |  UI/UX:  0
--+--
 '''django-admin''' and '''manage.py''' are supposed to be interchangeable.

 From the docs(https://docs.djangoproject.com/en/1.9/ref/django-admin/):

 ''The command-line examples throughout this document use django-admin to
 be consistent, but any example can use manage.py or python -m django just
 as well.''

 However, this doesn't seem to be true for ''makemessages''.

 If I run ''manage.py makemessages'' from the top level of the project
 MEDIA_ROOT and STATIC_ROOT are ignored. This isn't precisely a bug because
 that's what the code is intended to do
 
(https://github.com/django/django/blob/master/django/core/management/commands/makemessages.py#L448),
 but I find it strange specially  for ''--domain djangojs'' because is very
 common for Javascript files to be put in STATIC_ROOT.

 django-admin makemessages doesn't ignore MEDIA_ROOT or STATIC_ROOT and it
 traverses the entire source tree.

 At least this should be explained in the documentation. At best both
 commands should do the exact same. It's very easy to be bitten by this as
 we don't always review the resulting *.po file.

 Am I missing something here?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.815618bc7af495edf59162ff3de395ea%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.