Re: [Django] #27007: Handle non-UTF-8 bytes objects for text/* attachments

[Django]

#27007: Handle non-UTF-8 bytes objects for text/* attachments
-+-
 Reporter:  Feuermurmel  |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Core (Mail)  |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"72d541b61cd7b0a14f70242e2207fdb3f600c4d5" 72d541b]:
 {{{
 #!CommitTicketReference repository=""
 revision="72d541b61cd7b0a14f70242e2207fdb3f600c4d5"
 Fixed #27007 -- Handled non-UTF-8 bytes objects for text/* attachments.

 The fallback logic which allows non-UTF-8 encoded files to be passed to
 attach_file() even when a `text/*` mime type has been specified is
 moved to attach(). Both functions now fall back to a content type of
 `application/octet-stream`.

 A side effect is that a file's content is decoded in memory instead of
 opening it in text mode and reading it into a string.

 Some mimetype-related logic in _create_attachment() has become
 obsolete as the code moved from attach_file() to attach() already
 handles this.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.2d8268bfba9e2d05c0461f28c4de66ce%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27007: Handle non-UTF-8 bytes objects for text/* attachments

[Django]

#27007: Handle non-UTF-8 bytes objects for text/* attachments
-+-
 Reporter:  Feuermurmel  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Core (Mail)  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin


Comment:

 Pending some small documentation edits.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.6913143d56f22ea7ae4199f45bcb9ad0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27007: Handle non-UTF-8 bytes objects for text/* attachments

[Django]

#27007: Handle non-UTF-8 bytes objects for text/* attachments
--+
 Reporter:  Feuermurmel   |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Core (Mail)   |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Claude Paroz ):

 In [changeset:"6fe391d437cdf9866c34e30b2f3831e9d12e637b" 6fe391d4]:
 {{{
 #!CommitTicketReference repository=""
 revision="6fe391d437cdf9866c34e30b2f3831e9d12e637b"
 Refs #27007 -- Enhanced mail text attachment test

 The test now also checks whether the sent message's attachment has the
 expected
 name, content and mime type.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.bad320f73344159f7ed5f2e115ce6b07%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27007: Handle non-UTF-8 bytes objects for text/* attachments

[Django]

#27007: Handle non-UTF-8 bytes objects for text/* attachments
--+
 Reporter:  Feuermurmel   |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Core (Mail)   |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by claudep):

 * needs_better_patch:  0 => 1
 * has_patch:  0 => 1
 * stage:  Unreviewed => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.13f62fd423b4db43a45a5791f36cee4d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27007: Handle non-UTF-8 bytes objects for text/* attachments

[Django]

#27007: Handle non-UTF-8 bytes objects for text/* attachments
-+-
 Reporter:  Feuermurmel  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Core (Mail)  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Feuermurmel):

 Replying to [comment:3 timgraham]:

 Sorry for not mentioning #26802. That change did improve the situation,
 allowing `bytes` objects. But it tries to unconditionally decode it as
 UTF-8 (compared to the logic in `attach_file()`, which falls back to
 treating it as a binary file). This means that if a `bytes` object is
 passed which does not contain valid UTF-8, a `UnicodeDecodeError` will be
 thrown.

 With the changes in the pull request, the behavior is the same as when
 attaching a non-UTF-8 file.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.bccbd0e9bfb127a1418873f9cf4d5800%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27007: Handle non-UTF-8 bytes objects for text/* attachments

[Django]

#27007: Handle non-UTF-8 bytes objects for text/* attachments
-+-
 Reporter:  Feuermurmel  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Core (Mail)  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Feuermurmel):

 Pull request: https://github.com/django/django/pull/7014

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.66f0cf7de085b76c18afa0696d8a4db0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27007: Handle non-UTF-8 bytes objects for text/* attachments (was: Allow bytes objects as text/* attachments)

[Django]

#27007: Handle non-UTF-8 bytes objects for text/* attachments
-+-
 Reporter:  Feuermurmel  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Core (Mail)  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.d8540be90cfff72aa1006ca8c02fb37e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27007: Handle non-UTF-8 bytes objects for text/* attachments

[Django]

#27007: Handle non-UTF-8 bytes objects for text/* attachments
-+-
 Reporter:  Feuermurmel  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Core (Mail)  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by timgraham):

 Might be a duplicate of #26802 which was committed just a couple weeks
 ago.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.d397b7c41cb3a6260522e580920c85f8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.