Re: [Django] #27079: Refactor LiveServerPort tests to not make extra calls to setUpClass() and tearDownClass()

[Django]

#27079: Refactor LiveServerPort tests to not make extra calls to setUpClass() 
and
tearDownClass()
-+-
 Reporter:  Chris Jerdonek   |Owner:  Jacob
 Type:   |  Walls
  Cleanup/optimization   |   Status:  closed
Component:  Testing framework|  Version:  1.10
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by GitHub ):

 In [changeset:"d6e9ec40145b9edc65e8d0c65bd3f4ef8a7a27bb" d6e9ec4]:
 {{{
 #!CommitTicketReference repository=""
 revision="d6e9ec40145b9edc65e8d0c65bd3f4ef8a7a27bb"
 Refs #27079 -- Used addClassCleanup() in SeleniumTestCase.

 Regression in def09bf4126d4886413adf732eca8e32576b.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070188d4deb0f3-54188e16-ba5d-4ba8-8eeb-c629569fe467-00%40eu-central-1.amazonses.com.

Re: [Django] #27079: Refactor LiveServerPort tests to not make extra calls to setUpClass() and tearDownClass()

[Django]

#27079: Refactor LiveServerPort tests to not make extra calls to setUpClass() 
and
tearDownClass()
-+-
 Reporter:  Chris Jerdonek   |Owner:  Jacob
 Type:   |  Walls
  Cleanup/optimization   |   Status:  closed
Component:  Testing framework|  Version:  1.10
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"534895f1ace819053f28463fd62b833ba2ced829" 534895f]:
 {{{
 #!CommitTicketReference repository=""
 revision="534895f1ace819053f28463fd62b833ba2ced829"
 [4.0.x] Fixed thread termination in servers.tests.LiveServerPort on Python
 < 3.10.9.

 TestCase.doClassCleanups() cannot be called on Python < 3.10.9 because
 setUpClass()/tearDownClass() are called multiple times in
 LiveServerTestCase tests (refs #27079).
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070186120c4c99-b8ee5bb5-cef5-4800-97ac-8c3caf7de1f4-00%40eu-central-1.amazonses.com.

Re: [Django] #27079: Refactor LiveServerPort tests to not make extra calls to setUpClass() and tearDownClass()

[Django]

#27079: Refactor LiveServerPort tests to not make extra calls to setUpClass() 
and
tearDownClass()
-+-
 Reporter:  Chris Jerdonek   |Owner:  Jacob
 Type:   |  Walls
  Cleanup/optimization   |   Status:  closed
Component:  Testing framework|  Version:  1.10
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"def09bf4126d4886413adf732eca8e32576b" def09bf]:
 {{{
 #!CommitTicketReference repository=""
 revision="def09bf4126d4886413adf732eca8e32576b"
 Fixed #27079 -- Avoided multiple setUpClass()/tearDownClass() calls in
 LiveServerTestCase tests.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.c88112f7a31debf9fae78c53eae51d35%40djangoproject.com.

Re: [Django] #27079: Refactor LiveServerPort tests to not make extra calls to setUpClass() and tearDownClass()

[Django]

#27079: Refactor LiveServerPort tests to not make extra calls to setUpClass() 
and
tearDownClass()
-+-
 Reporter:  Chris Jerdonek   |Owner:  Jacob
 Type:   |  Walls
  Cleanup/optimization   |   Status:  assigned
Component:  Testing framework|  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.03458ebfaf57eeb7e722a06494791389%40djangoproject.com.

Re: [Django] #27079: Refactor LiveServerPort tests to not make extra calls to setUpClass() and tearDownClass()

[Django]

#27079: Refactor LiveServerPort tests to not make extra calls to setUpClass() 
and
tearDownClass()
-+-
 Reporter:  Chris Jerdonek   |Owner:  Jacob
 Type:   |  Walls
  Cleanup/optimization   |   Status:  assigned
Component:  Testing framework|  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jacob Walls):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.9f16d3617b339fabb3db938e33d92439%40djangoproject.com.

Re: [Django] #27079: Refactor LiveServerPort tests to not make extra calls to setUpClass() and tearDownClass()

[Django]

#27079: Refactor LiveServerPort tests to not make extra calls to setUpClass() 
and
tearDownClass()
-+-
 Reporter:  Chris Jerdonek   |Owner:  Jacob
 Type:   |  Walls
  Cleanup/optimization   |   Status:  assigned
Component:  Testing framework|  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jacob Walls):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.9dc9f99ac7e116470d94b69764d54e57%40djangoproject.com.

Re: [Django] #27079: Refactor LiveServerPort tests to not make extra calls to setUpClass() and tearDownClass()

[Django]

#27079: Refactor LiveServerPort tests to not make extra calls to setUpClass() 
and
tearDownClass()
-+-
 Reporter:  Chris Jerdonek   |Owner:  Jacob
 Type:   |  Walls
  Cleanup/optimization   |   Status:  assigned
Component:  Testing framework|  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jacob Walls):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/15007 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.f0996dc43f4bb9fe9e76def4c4f9149f%40djangoproject.com.

Re: [Django] #27079: Refactor LiveServerPort tests to not make extra calls to setUpClass() and tearDownClass() (was: LiveServerPort test methods set allow_thread_sharing to False before all server thr

[Django]

#27079: Refactor LiveServerPort tests to not make extra calls to setUpClass() 
and
tearDownClass()
-+-
 Reporter:  Chris Jerdonek   |Owner:  Jacob
 Type:   |  Walls
  Cleanup/optimization   |   Status:  assigned
Component:  Testing framework|  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jacob Walls):

 * owner:  (none) => Jacob Walls
 * status:  new => assigned
 * type:  Bug => Cleanup/optimization


Comment:

 > Back to the original state of play after changes in #28478.

 Actually, not quite the original state of play. `allow_thread_sharing` was
 removed in #30171 in favor of a counter pattern which obviates the
 reported bug here. I still think Chris's suggestion has value, but it's
 more of a cleanup opportunity, if I'm not mistaken.

 Having touched this a couple times I ought to just finish it off.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.47bc605491afa277bd70d3f91a630350%40djangoproject.com.