Re: [Django] #27180: Check for sql_mode fails during migration with special database connections

[Django]

#27180: Check for sql_mode fails during migration with special database 
connections
-+-
 Reporter:  gerricom |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"baa1790b4ddd5e7836170743aa058c834b7b2040" baa1790b]:
 {{{
 #!CommitTicketReference repository=""
 revision="baa1790b4ddd5e7836170743aa058c834b7b2040"
 [1.10.x] Fixed #27180 -- Fixed a crash in MySQL checks where SELECT
 @@sql_mode doesn't return a result.

 Backport of 2b64ff68cc375b5688174b4087bf44be9edd2558 from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.3a0564cee6df843b5c09015056e6707d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27180: Check for sql_mode fails during migration with special database connections

[Django]

#27180: Check for sql_mode fails during migration with special database 
connections
-+-
 Reporter:  gerricom |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"2b64ff68cc375b5688174b4087bf44be9edd2558" 2b64ff68]:
 {{{
 #!CommitTicketReference repository=""
 revision="2b64ff68cc375b5688174b4087bf44be9edd2558"
 Fixed #27180 -- Fixed a crash in MySQL checks where SELECT @@sql_mode
 doesn't return a result.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.165d3b0b2068e3ae87143284b9c3d545%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27180: Check for sql_mode fails during migration with special database connections

[Django]

#27180: Check for sql_mode fails during migration with special database 
connections
-+-
 Reporter:  gerricom |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by gerricom):

 [https://github.com/django/django/pull/7216 Done]

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.e94cb42cfe8e586d4caf0f1d0ccd3805%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27180: Check for sql_mode fails during migration with special database connections

[Django]

#27180: Check for sql_mode fails during migration with special database 
connections
-+-
 Reporter:  gerricom |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by claudep):

 @gerricom: thanks for the patch, could you provide it as a pull request on
 Github?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.f243a619037b4c6f96d86070cb44c483%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27180: Check for sql_mode fails during migration with special database connections

[Django]

#27180: Check for sql_mode fails during migration with special database 
connections
-+-
 Reporter:  gerricom |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by gerricom):

 Replying to [comment:4 claudep]:
 > I'm wondering if we should continue this way with this special usage.
 Wouldn't the right solution to subclass the MySQL backend and adapt the
 checks?

 This is for sure no problem for us if we run into another problems in
 future. But in this specific case I believe there can be other cases where
 this error could occur. I've attached a little patch, that works for us.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.4b6172a51f1feb0f4872fa136fe9d7b0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27180: Check for sql_mode fails during migration with special database connections

[Django]

#27180: Check for sql_mode fails during migration with special database 
connections
-+-
 Reporter:  gerricom |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by gerricom):

 * Attachment "27180.diff" added.


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.f30c3d9a7901b90d7405d22daae3f616%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27180: Check for sql_mode fails during migration with special database connections

[Django]

#27180: Check for sql_mode fails during migration with special database 
connections
-+-
 Reporter:  gerricom |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by timgraham):

 I'm not sure how much ongoing work it would add to support this but if the
 backend has otherwise been usable since some old version of Django, then
 it seem reasonable to try to continue that as long as only minor changes
 are needed. We could also demote such issues from release blockers and
 require people using these special connections to submit patches
 themselves.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.3924c01253371c03b7589539b153dbda%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27180: Check for sql_mode fails during migration with special database connections

[Django]

#27180: Check for sql_mode fails during migration with special database 
connections
-+-
 Reporter:  gerricom |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by claudep):

 I'm wondering if we should continue this way with this special usage.
 Wouldn't the right solution to subclass the MySQL backend and adapt the
 checks?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.80071d965bb830ffc752b464b306f809%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27180: Check for sql_mode fails during migration with special database connections

[Django]

#27180: Check for sql_mode fails during migration with special database 
connections
-+-
 Reporter:  gerricom |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by timgraham):

 From #26991, "I'm connecting via MySQL to an sphinxsearch database. It
 basically uses the MySQL query language but has some special features."

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.f18ddb81a878bdfb7bd01e52b0fe331d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27180: Check for sql_mode fails during migration with special database connections

[Django]

#27180: Check for sql_mode fails during migration with special database 
connections
-+-
 Reporter:  gerricom |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by claudep):

 Could we know a bit more about that `special database connection`, please?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.c10106a84f0abcaa726e07eb6c154a25%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27180: Check for sql_mode fails during migration with special database connections

[Django]

#27180: Check for sql_mode fails during migration with special database 
connections
-+-
 Reporter:  gerricom |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * severity:  Normal => Release blocker
 * needs_better_patch:   => 0
 * component:  Migrations => Database layer (models, ORM)
 * needs_tests:   => 0
 * needs_docs:   => 0
 * stage:  Unreviewed => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.80f797fddce2efe2ee2b0752c83f8ef9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #27180: Check for sql_mode fails during migration with special database connections

[Django]

#27180: Check for sql_mode fails during migration with special database 
connections
+
 Reporter:  gerricom|  Owner:  nobody
 Type:  Bug | Status:  new
Component:  Migrations  |Version:  1.10
 Severity:  Normal  |   Keywords:
 Triage Stage:  Unreviewed  |  Has patch:  0
Easy pickings:  0   |  UI/UX:  0
+
 I believe I found again a bug regarding some special database connections
 (like #26991):

 Running `migrate` raises this error:


 {{{
 Traceback (most recent call last):
   File "manage.py", line 10, in 
 execute_from_command_line(sys.argv)
   File "/usr/local/lib/python2.7/site-
 packages/django/core/management/__init__.py", line 367, in
 execute_from_command_line
 utility.execute()
   File "/usr/local/lib/python2.7/site-
 packages/django/core/management/__init__.py", line 359, in execute
 self.fetch_command(subcommand).run_from_argv(self.argv)
   File "/usr/local/lib/python2.7/site-
 packages/django/core/management/base.py", line 294, in run_from_argv
 self.execute(*args, **cmd_options)
   File "/usr/local/lib/python2.7/site-
 packages/django/core/management/base.py", line 342, in execute
 self.check()
   File "/usr/local/lib/python2.7/site-
 packages/django/core/management/base.py", line 374, in check
 include_deployment_checks=include_deployment_checks,
   File "/usr/local/lib/python2.7/site-
 packages/django/core/management/commands/migrate.py", line 61, in
 _run_checks
 issues = run_checks(tags=[Tags.database])
   File "/usr/local/lib/python2.7/site-
 packages/django/core/checks/registry.py", line 81, in run_checks
 new_errors = check(app_configs=app_configs)
   File "/usr/local/lib/python2.7/site-
 packages/django/core/checks/database.py", line 10, in
 check_database_backends
 issues.extend(conn.validation.check(**kwargs))
   File "/usr/local/lib/python2.7/site-
 packages/django/db/backends/mysql/validation.py", line 9, in check
 issues.extend(self._check_sql_mode(**kwargs))
   File "/usr/local/lib/python2.7/site-
 packages/django/db/backends/mysql/validation.py", line 16, in
 _check_sql_mode
 modes = set(sql_mode[0].split(','))
 TypeError: 'NoneType' object has no attribute '__getitem__'
 }}}

 The reason is, that `SELECT @@sql_mode` returns no results in my special
 case.

 Just a little side note: `migrate` runs database checks against all
 database connections, no matter if a database is selected via the
 `--database` parameter or if migrations are not allowed because of a
 database router. I'm not quite sure if this works as intended.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.8492dc590a5f2e8fd99116168f1959b7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.