Re: [Django] #27467: UserAttributeSimilarityValidator max_similarity=0/1 doesn't work as documented

[Django]

#27467: UserAttributeSimilarityValidator max_similarity=0/1 doesn't work as
documented
-+-
 Reporter:  goblinJoel   |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  contrib.auth |  Version:  1.9
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  password management  | Triage Stage:  Accepted
  validation validator   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham):

 If we had discovered the issue before the release of Django 1.10, it may
 have qualified for a backport as a bug in a new feature, but at this
 point, the fix will go to 1.11. See the
 [https://docs.djangoproject.com/en/dev/internals/release-process
 /#supported-versions supported versions policy] for details.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.500dcf954c564dbfd7cacf8183e5f353%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27467: UserAttributeSimilarityValidator max_similarity=0/1 doesn't work as documented

[Django]

#27467: UserAttributeSimilarityValidator max_similarity=0/1 doesn't work as
documented
-+-
 Reporter:  goblinJoel   |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  contrib.auth |  Version:  1.9
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  password management  | Triage Stage:  Accepted
  validation validator   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by goblinJoel):

 No problem. Thanks for fixing it!

 I'm not familiar with how fixes make their way to releases. Is this
 something for the next minor version, or will it be in a bugfix for prior
 versions (e.g., 1.9.x)? No big deal for me either way; workaround was
 trivial in my case.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.78e160aff5bb40ecd80656779c5109da%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27467: UserAttributeSimilarityValidator max_similarity=0/1 doesn't work as documented

[Django]

#27467: UserAttributeSimilarityValidator max_similarity=0/1 doesn't work as
documented
-+-
 Reporter:  goblinJoel   |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  contrib.auth |  Version:  1.9
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  password management  | Triage Stage:  Accepted
  validation validator   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"0d9ff873d9f93efbba875efbf582db88bb0e30ce" 0d9ff873]:
 {{{
 #!CommitTicketReference repository=""
 revision="0d9ff873d9f93efbba875efbf582db88bb0e30ce"
 Fixed #27467 -- Made UserAttributeSimilarityValidator max_similarity=0/1
 work as documented.

 Thanks goblinJoel for the report and feedback.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.d8a5768f4a9fa40bb95020ce6e3d1fcf%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27467: UserAttributeSimilarityValidator max_similarity=0/1 doesn't work as documented

[Django]

#27467: UserAttributeSimilarityValidator max_similarity=0/1 doesn't work as
documented
-+-
 Reporter:  goblinJoel   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.auth |  Version:  1.9
 Severity:  Normal   |   Resolution:
 Keywords:  password management  | Triage Stage:  Accepted
  validation validator   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham):

 Good point, I updated the docs in the PR.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.81784bc48c889006b436f0ec858b398c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27467: UserAttributeSimilarityValidator max_similarity=0/1 doesn't work as documented

[Django]

#27467: UserAttributeSimilarityValidator max_similarity=0/1 doesn't work as
documented
-+-
 Reporter:  goblinJoel   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.auth |  Version:  1.9
 Severity:  Normal   |   Resolution:
 Keywords:  password management  | Triage Stage:  Accepted
  validation validator   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by goblinJoel):

 Replying to [comment:2 Erik Romijn]:
 > Fixing the code seems like the right approach to me too. This was an
 oversight when I originally wrote the code.
 Makes sense to me. In fact, now that I think about it, that would make a
 max_similarity of 0 behave as described, as well. As-is, using '''>''',
 assuming a computed similarity of 0 is possible, a password with no
 similarity must get accepted, because 0 is not greater than 0. Using
 '''>=''', it would be rejected, because 0 is greater than or equal to 0. I
 think the [https://github.com/django/django/pull/7534 PR] noticed the same
 thing.

 However, the documentation may need to be updated that way, too:

   The maximum similarity the password can have, '''before it is
 rejected''', can be set with the '''max_similarity''' parameter, on a
 scale of 0 to 1. A setting of 0 will cause all passwords to be rejected,
 whereas a setting of 1 will cause it to only reject passwords that are
 identical to an attribute’s value.

 If the code switches to '''>=''', max_similarity no longer represents the
 maximum similarity ''before'' rejection. It will instead be the minimum
 similarity ''for'' rejection. I assume this isn't worth renaming the
 parameter over, and maybe the 0 and 1 examples make it clear, but it
 seemed worth noting.

 PS: Wow! Did not expect to get a response this quickly!

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.e733da98c35d3541de1b5e0bc072a0b9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27467: UserAttributeSimilarityValidator max_similarity=0/1 doesn't work as documented

[Django]

#27467: UserAttributeSimilarityValidator max_similarity=0/1 doesn't work as
documented
-+-
 Reporter:  goblinJoel   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.auth |  Version:  1.9
 Severity:  Normal   |   Resolution:
 Keywords:  password management  | Triage Stage:  Accepted
  validation validator   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Erik Romijn):

 Fixing the code seems like the right approach to me too. This was an
 oversight when I originally wrote the code.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.5fa460d40752360db333ed733b666332%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27467: UserAttributeSimilarityValidator max_similarity=0/1 doesn't work as documented (was: Documentation inaccurate for password validator UserAttributeSimilarityValidator)

[Django]

#27467: UserAttributeSimilarityValidator max_similarity=0/1 doesn't work as
documented
-+-
 Reporter:  goblinJoel   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.auth |  Version:  1.9
 Severity:  Normal   |   Resolution:
 Keywords:  password management  | Triage Stage:  Accepted
  validation validator   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * cc: Erik Romijn (added)
 * component:  Documentation => contrib.auth
 * easy:  1 => 0
 * has_patch:  0 => 1
 * type:  Uncategorized => Bug
 * stage:  Unreviewed => Accepted


Comment:

 Is there a reason not to fix the code to match the documentation?
 [https://github.com/django/django/pull/7534 PR]

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.f56c206beb330f5558664d60786e75b3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.