Re: [Django] #27652: Humanize docs should clarify: Floats OK too!

[Django]

#27652: Humanize docs should clarify: Floats OK too!
--+
 Reporter:  Mike Lissner  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  1 |UI/UX:  0
--+

Comment (by Tim Graham ):

 In [changeset:"4a6dc71cae8e83445e87c6fccbc58702a05fbd47" 4a6dc71]:
 {{{
 #!CommitTicketReference repository=""
 revision="4a6dc71cae8e83445e87c6fccbc58702a05fbd47"
 [1.10.x] Fixed #27652 -- Doc'd that intcomma works with floats.

 Backport of 398a859642636a2de0ab920befa320cd9954b49a from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.e0e8e78c1485742d415441270fc4f78c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27652: Humanize docs should clarify: Floats OK too!

[Django]

#27652: Humanize docs should clarify: Floats OK too!
--+
 Reporter:  Mike Lissner  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  1 |UI/UX:  0
--+
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"398a859642636a2de0ab920befa320cd9954b49a" 398a859]:
 {{{
 #!CommitTicketReference repository=""
 revision="398a859642636a2de0ab920befa320cd9954b49a"
 Fixed #27652 -- Doc'd that intcomma works with floats.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.bf62389075dc85a4e3264a2f851fc52b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27652: Humanize docs should clarify: Floats OK too!

[Django]

#27652: Humanize docs should clarify: Floats OK too!
--+
 Reporter:  Mike Lissner  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  1 |UI/UX:  0
--+
Changes (by Tim Graham):

 * needs_better_patch:  0 => 1


Comment:

 I forgot to say there are only tests for floats for `intcomma`. In my
 testing, `intword` doesn't support floats. '100.1' gives the same
 value back rather than "1 million". This seems fine to me but the PR must
 be corrected.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.24fb34461e730ef35b2a06ebc889267b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27652: Humanize docs should clarify: Floats OK too!

[Django]

#27652: Humanize docs should clarify: Floats OK too!
--+
 Reporter:  Mike Lissner  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by Mads Jensen):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/7762 PR]

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.29bdbf8cde1f0f886f50476d2252dcb1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27652: Humanize docs should clarify: Floats OK too!

[Django]

#27652: Humanize docs should clarify: Floats OK too!
--+
 Reporter:  Mike Lissner  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by Tim Graham):

 * type:  Uncategorized => Cleanup/optimization
 * stage:  Unreviewed => Accepted


Comment:

 There are already tests for floats, see `tests/humanize_tests/tests.py`.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.63115bf16fad1c564f3ec252c9aa71bf%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #27652: Humanize docs should clarify: Floats OK too!

[Django]

#27652: Humanize docs should clarify: Floats OK too!
-+
   Reporter:  Mike Lissner   |  Owner:  nobody
   Type:  Uncategorized  | Status:  new
  Component:  Documentation  |Version:  master
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  1
  UI/UX:  0  |
-+
 In the humanize documentation
 (https://docs.djangoproject.com/en/1.9/ref/contrib/humanize/), it says
 things like:

 intcomma: Converts an ''integer'' to a string containing commas every
 three digits.

 intword: Converts a large ''integer'' to a friendly text representation.

 Etc.

 I took a look at the code, and it looks like it's written in such a way
 that floats would work too without a hitch. Should we update the docs to
 say as such?

 Also: If we do this, do we need tests that include floats?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.406fa914cc629ea330438bf98c95364a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.