Re: [Django] #27655: Styleguide missing - Use single quotes instead of double quotes in string

[Django]

#27655: Styleguide missing - Use single quotes instead of double quotes in 
string
-+-
 Reporter:  Anton Samarchyan |Owner:  Tim
 Type:   |  Graham
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"7fb148a638044e96fea9996115deb334992ec072" 7fb148a]:
 {{{
 #!CommitTicketReference repository=""
 revision="7fb148a638044e96fea9996115deb334992ec072"
 [1.11.x] Fixed #27655 -- Added some guidelines to the coding style docs.

 Backport of c68f5d83c0a4ea4ccf87c7d1d5dd1e9f7b2907a3 from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.f7ad4038ee7c08c5e513685a8acf35e2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27655: Styleguide missing - Use single quotes instead of double quotes in string

[Django]

#27655: Styleguide missing - Use single quotes instead of double quotes in 
string
-+-
 Reporter:  Anton Samarchyan |Owner:  Tim
 Type:   |  Graham
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by GitHub ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"c68f5d83c0a4ea4ccf87c7d1d5dd1e9f7b2907a3" c68f5d83]:
 {{{
 #!CommitTicketReference repository=""
 revision="c68f5d83c0a4ea4ccf87c7d1d5dd1e9f7b2907a3"
 Fixed #27655 -- Added some guidelines to the coding style docs.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.c92f5d90f674dd07177d1f7360f2de1b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27655: Styleguide missing - Use single quotes instead of double quotes in string

[Django]

#27655: Styleguide missing - Use single quotes instead of double quotes in 
string
-+-
 Reporter:  Anton Samarchyan |Owner:  Tim
 Type:   |  Graham
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * needs_better_patch:  0 => 1
 * has_patch:  0 => 1


Comment:

 WIP [https://github.com/django/django/pull/8284 PR]. I might add more
 guidelines as I think of them.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.eda205cfd1bbe2ba4b2773da113a494c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27655: Styleguide missing - Use single quotes instead of double quotes in string

[Django]

#27655: Styleguide missing - Use single quotes instead of double quotes in 
string
-+-
 Reporter:  Anton Samarchyan |Owner:  Tim
 Type:   |  Graham
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * owner:  ChillarAnand => Tim Graham
 * easy:  1 => 0
 * stage:  Ready for checkin => Accepted


Comment:

 I'm going to add some other guidelines with common review comments that I
 make.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.db085e2a4ceeacfba88021dc2c741595%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27655: Styleguide missing - Use single quotes instead of double quotes in string

[Django]

#27655: Styleguide missing - Use single quotes instead of double quotes in 
string
-+-
 Reporter:  Anton Samarchyan |Owner:  Anand
 Type:   |  Reddy Pandikunta
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Anand Reddy Pandikunta):

 * status:  new => assigned
 * owner:  nobody => Anand Reddy Pandikunta


Comment:

 PR - https://github.com/django/django/pull/7888

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.74dcbbfc2b54bef9b5ac985347765ec1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27655: Styleguide missing - Use single quotes instead of double quotes in string

[Django]

#27655: Styleguide missing - Use single quotes instead of double quotes in 
string
-+-
 Reporter:  Anton Samarchyan |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Tim Graham):

 * type:  New feature => Cleanup/optimization
 * stage:  Unreviewed => Ready for checkin


Comment:

 The advice I've been giving is:

 * Use single quotes for strings, or a double quote if the the string
 contains a single quote. Don't bother refactoring existing code to confirm
 to this style.

 I'll commit that if there's no other feedback.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.6d520db17696fb28eb0fb118706c8af5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #27655: Styleguide missing - Use single quotes instead of double quotes in string

[Django]

#27655: Styleguide missing - Use single quotes instead of double quotes in 
string
+
   Reporter:  Anton Samarchyan  |  Owner:  nobody
   Type:  New feature   | Status:  new
  Component:  Documentation |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  1
  UI/UX:  0 |
+
 Use single quotes instead of double quotes in string if the string itself
 doesn't contain them.
 (https://github.com/django/django/pull/7470#discussion_r90120125)
 I haven't found this code style standard here
 https://docs.djangoproject.com/en/dev/internals/contributing/writing-code
 /coding-style/
 We should probably add it?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/050.d3e7b128583fb7faf55f2aa29bf48a32%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.