Re: [Django] #27664: Manager.contribute_to_class() is called with abstract model rather than concrete model

[Django]

#27664: Manager.contribute_to_class() is called with abstract model rather than
concrete model
-+-
 Reporter:  Johannes Hoppe   |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * status:  new => closed
 * resolution:   => needsinfo


Comment:

 Absent a patch or explanation of why the change is needed, I don't know
 what to do here. Feel free to investigate and offer a patch. I have a
 feeling that "fixing" this requires reintroducing the complexity that
 Loic's patch removed.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.a87f583e497a24f92a78cf6e248ba3b0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27664: Manager.contribute_to_class() is called with abstract model rather than concrete model

[Django]

#27664: Manager.contribute_to_class() is called with abstract model rather than
concrete model
-+-
 Reporter:  Johannes Hoppe   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Johannes Hoppe):

 Hi Tim,

 I agree, it is not documented, but I guess it's not to uncommon for third
 party libraries to make use of `contribute_to_class` be it on `Managers`
 or `Fields`.

 Regardless, the documentation says, that the manager will be inherited. So
 I would presume the having the attribute on a super class is the same than
 having the attribute on the sub class.

 This is not the case.

 I'm not sure if this is just a matter of documentation or if it should be
 changed. My first guess would be to change it. It seems more intuitive to
 me. But I really like the that the new Manager design is less complex. If
 there isn't an easy solution. This shouldn't be changed.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.7279e5f55f171744c8ba672f5f8bad63%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27664: Manager.contribute_to_class() is called with abstract model rather than concrete model (was: contribute_to_class is called with wrong model class)

[Django]

#27664: Manager.contribute_to_class() is called with abstract model rather than
concrete model
-+-
 Reporter:  Johannes Hoppe   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.f13808d4a1a7a73abb992a194642be81%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.