Re: [Django] #27866: Make ChoiceWidget.format_value() return a list

[Django]

#27866: Make ChoiceWidget.format_value() return a list
-+-
 Reporter:  Claude Paroz |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Forms|  Version:  1.11
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Claude Paroz ):

 In [changeset:"523a8032c8fe3d962552249f8ba4f7c91830c9e3" 523a803]:
 {{{
 #!CommitTicketReference repository=""
 revision="523a8032c8fe3d962552249f8ba4f7c91830c9e3"
 [1.11.x] Refs #27866 -- Adapted backport for Python 2 compatibility
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.19e64dd8d08609b09014c92405990ebb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27866: Make ChoiceWidget.format_value() return a list

[Django]

#27866: Make ChoiceWidget.format_value() return a list
-+-
 Reporter:  Claude Paroz |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Forms|  Version:  1.11
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Claude Paroz ):

 In [changeset:"06d32f689eb218bee633125dd0afa68400311885" 06d32f68]:
 {{{
 #!CommitTicketReference repository=""
 revision="06d32f689eb218bee633125dd0afa68400311885"
 [1.11.x] Fixed #27866 -- Made ChoiceWidget.format_value() return a list

 Thanks Tim Graham for the review.
 Backport of e487ffd3f0f9931e7c18bfbd47cf1e6b059ddc41 from master.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.9f64cb63b7d4badc3a704f19b4a21f82%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27866: Make ChoiceWidget.format_value() return a list

[Django]

#27866: Make ChoiceWidget.format_value() return a list
-+-
 Reporter:  Claude Paroz |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Forms|  Version:  1.11
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Claude Paroz ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"e487ffd3f0f9931e7c18bfbd47cf1e6b059ddc41" e487ffd]:
 {{{
 #!CommitTicketReference repository=""
 revision="e487ffd3f0f9931e7c18bfbd47cf1e6b059ddc41"
 Fixed #27866 -- Made ChoiceWidget.format_value() return a list

 Thanks Tim Graham for the review.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.47b682b555041a8690280c093d975109%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27866: Make ChoiceWidget.format_value() return a list

[Django]

#27866: Make ChoiceWidget.format_value() return a list
-+-
 Reporter:  Claude Paroz |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Forms|  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.a00fc121f2e9d90283e8ed274637351c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27866: Make ChoiceWidget.format_value() return a list

[Django]

#27866: Make ChoiceWidget.format_value() return a list
--+
 Reporter:  Claude Paroz  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Forms |  Version:  1.11
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Claude Paroz):

 * needs_tests:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.1a46ef8f4b88dbf0df7779e437665eaf%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27866: Make ChoiceWidget.format_value() return a list

[Django]

#27866: Make ChoiceWidget.format_value() return a list
--+
 Reporter:  Claude Paroz  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Forms |  Version:  1.11
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  1 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham):

 * needs_tests:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.04b9996d4f93c175490c675967da9ed3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27866: Make ChoiceWidget.format_value() return a list

[Django]

#27866: Make ChoiceWidget.format_value() return a list
--+
 Reporter:  Claude Paroz  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Forms |  Version:  1.11
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Claude Paroz):

 The method is new, but the behavior with the `set()` is not new. We could
 backport, but that's not mandatory.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.9356ecc2d7836e696f56a4bdf88a664e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27866: Make ChoiceWidget.format_value() return a list (was: Make ChoiceWidget.format_value return a list)

[Django]

#27866: Make ChoiceWidget.format_value() return a list
--+
 Reporter:  Claude Paroz  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Forms |  Version:  1.11
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham):

 * version:  master => 1.11
 * stage:  Unreviewed => Accepted


Comment:

 That method is new in 1.11 for template-based widget rendering
 (b52c73008a9d67e9ddbb841872dc15cdd3d6ee01) so I think the change should be
 backported, probably without the `force_text(v)` removal. How about tests
 for the method?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.a4dea64d9abbb07ef9a941935e5aced5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27866: Make ChoiceWidget.format_value return a list

[Django]

#27866: Make ChoiceWidget.format_value return a list
-+-
 Reporter:  Claude Paroz |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Claude Paroz):

 * has_patch:  0 => 1


Comment:

 https://github.com/django/django/pull/8090

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.2be8cbfb4c78cb5ecfde525859e70adc%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #27866: Make ChoiceWidget.format_value return a list

[Django]

#27866: Make ChoiceWidget.format_value return a list
+
   Reporter:  Claude Paroz  |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  Forms |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 Currently, `ChoiceWidget.format_value` returns a set. I have a use case
 with a custom widget where selected value ordering matters. I can subclass
 `format_value` in my widget subclass, but I wonder if the transformation
 to a set, losing value ordering, is there on purpose. It seems the test
 suite does not fail when keeping a list. I'll suggest a patch.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/050.3fb058183898fab6f611ed2e615d3a2d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.