Re: [Django] #28011: Correct Field.hidden docs regarding what fields are hidden

[Django]

#28011: Correct Field.hidden docs regarding what fields are hidden
-+-
 Reporter:  Tim Graham   |Owner:  Adam
 |  Johnson
 Type:  Bug  |   Status:  closed
Component:  Documentation|  Version:  1.10
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Mariusz Felisiak ):

 In [changeset:"f65f8ab84ebd2fc9772d23a159e6178e1335bd8b" f65f8ab]:
 {{{#!CommitTicketReference repository=""
 revision="f65f8ab84ebd2fc9772d23a159e6178e1335bd8b"
 Refs #28011 -- Removed ForeignObjectRel.is_hidden().
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dc16d1186-897459a8-b02d-4098-a11f-6df78738a5a3-00%40eu-central-1.amazonses.com.

Re: [Django] #28011: Correct Field.hidden docs regarding what fields are hidden

[Django]

#28011: Correct Field.hidden docs regarding what fields are hidden
-+-
 Reporter:  Tim Graham   |Owner:  Adam
 |  Johnson
 Type:  Bug  |   Status:  closed
Component:  Documentation|  Version:  1.10
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Mariusz Felisiak ):

 In [changeset:"23c7cbfd241bb4287d042e8634a9c27ed3b7490e" 23c7cbf]:
 {{{#!CommitTicketReference repository=""
 revision="23c7cbfd241bb4287d042e8634a9c27ed3b7490e"
 [5.0.x] Fixed #28011 -- Corrected Field.hidden docs.

 Backport of 7ba6c9edc50dc989fc5c306b541636249b952f93 from main
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018db84e5785-4bf7618b-fb6f-4332-9905-4c5c803fed46-00%40eu-central-1.amazonses.com.

Re: [Django] #28011: Correct Field.hidden docs regarding what fields are hidden

[Django]

#28011: Correct Field.hidden docs regarding what fields are hidden
-+-
 Reporter:  Tim Graham   |Owner:  Adam
 |  Johnson
 Type:  Bug  |   Status:  closed
Component:  Documentation|  Version:  1.10
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * resolution:   => fixed
 * status:  assigned => closed

Comment:

 In [changeset:"7ba6c9edc50dc989fc5c306b541636249b952f93" 7ba6c9ed]:
 {{{#!CommitTicketReference repository=""
 revision="7ba6c9edc50dc989fc5c306b541636249b952f93"
 Fixed #28011 -- Corrected Field.hidden docs.
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018db84df703-cf189eea-d994-401b-8ae2-049c58cbfafd-00%40eu-central-1.amazonses.com.

Re: [Django] #28011: Correct Field.hidden docs regarding what fields are hidden

[Django]

#28011: Correct Field.hidden docs regarding what fields are hidden
-+-
 Reporter:  Tim Graham   |Owner:  Adam
 |  Johnson
 Type:  Bug  |   Status:  assigned
Component:  Documentation|  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Accepted => Ready for checkin

Comment:

 [https://github.com/django/django/pull/17861 PR]
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018db7dca559-1f6195d2-d414-428b-be02-2bfb2152ff60-00%40eu-central-1.amazonses.com.

Re: [Django] #28011: Correct Field.hidden docs regarding what fields are hidden

[Django]

#28011: Correct Field.hidden docs regarding what fields are hidden
---+
 Reporter:  Tim Graham |Owner:  Adam Johnson
 Type:  Bug|   Status:  assigned
Component:  Documentation  |  Version:  1.10
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by Adam Johnson):

 * has_patch:  0 => 1
 * owner:  nobody => Adam Johnson
 * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018db3f35047-b34dab93-2ee5-4e7e-a165-23d42219b3c6-00%40eu-central-1.amazonses.com.

Re: [Django] #28011: Correct Field.hidden docs regarding what fields are hidden

[Django]

#28011: Correct Field.hidden docs regarding what fields are hidden
---+
 Reporter:  Tim Graham |Owner:  Akshat verma
 Type:  Bug|   Status:  assigned
Component:  Documentation  |  Version:  1.10
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by Mariusz Felisiak):

 Akshat, are you going to work on any of these tickets? you've already
 assigned many of them to yourself. I'd recommend to focus on a single one.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701874692b4e6-c7be5039-dfff-4dc2-b666-e92b871826d2-00%40eu-central-1.amazonses.com.

Re: [Django] #28011: Correct Field.hidden docs regarding what fields are hidden

[Django]

#28011: Correct Field.hidden docs regarding what fields are hidden
---+
 Reporter:  Tim Graham |Owner:  Akshat verma
 Type:  Bug|   Status:  assigned
Component:  Documentation  |  Version:  1.10
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by Akshat verma):

 * owner:  nobody => Akshat verma
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070187468f7d18-cbc7972a-36fd-4b0e-9d28-2da68fa62bd9-00%40eu-central-1.amazonses.com.

Re: [Django] #28011: Correct Field.hidden docs regarding what fields are hidden

[Django]

#28011: Correct Field.hidden docs regarding what fields are hidden
---+
 Reporter:  Tim Graham |Owner:  (none)
 Type:  Bug|   Status:  new
Component:  Documentation  |  Version:  1.10
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by Modestas Jakuska):

 * owner:  Modestas Jakuska => (none)
 * status:  assigned => new


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.19a510935bea660f1062466b642f26d7%40djangoproject.com.

Re: [Django] #28011: Correct Field.hidden docs regarding what fields are hidden

[Django]

#28011: Correct Field.hidden docs regarding what fields are hidden
-+-
 Reporter:  Tim Graham   |Owner:  Modestas
 |  Jakuska
 Type:  Bug  |   Status:  assigned
Component:  Documentation|  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Modestas Jakuska):

 * owner:  nobody => Modestas Jakuska
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.29adf3964da2b53d485ec74f1574ecde%40djangoproject.com.

Re: [Django] #28011: Correct Field.hidden docs regarding what fields are hidden

[Django]

#28011: Correct Field.hidden docs regarding what fields are hidden
-+-
 Reporter:  Tim Graham   |Owner:  cleopatra
 |  douglas
 Type:  Bug  |   Status:  assigned
Component:  Documentation|  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by cleopatra douglas):

 * owner:  nobody => cleopatra douglas
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.e29fd6ee7f1059d5b4f7f2f7cf0c3d87%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #28011: Correct Field.hidden docs regarding what fields are hidden

[Django]

#28011: Correct Field.hidden docs regarding what fields are hidden
-+
   Reporter:  Tim Graham |  Owner:  nobody
   Type:  Bug| Status:  new
  Component:  Documentation  |Version:  1.10
   Severity:  Normal |   Keywords:
   Triage Stage:  Accepted   |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 The
 
[https://github.com/django/django/blob/d4d79d0f200357b28419203557cc61c8168316ab/docs/ref/models/fields.txt#L1912-L1918
 Field.hidden] docs say, "Boolean flag that indicates if a field is used to
 back another non-hidden field’s functionality (e.g. the content_type and
 object_id fields that make up a GenericForeignKey)." This seems
 inaccurate:
 {{{#!python
 from django.contrib.contenttypes.fields import GenericForeignKey,
 GenericRelation
 from django.contrib.contenttypes.models import ContentType
 from django.db import models

 class TaggedItem(models.Model):
 tag = models.SlugField()
 content_type = models.ForeignKey(ContentType,
 on_delete=models.CASCADE, related_name='tagged_items')
 object_id = models.PositiveIntegerField()
 content_object = GenericForeignKey('content_type', 'object_id')

 >>> TaggedItem._meta.get_field('object_id')
 
 >>> TaggedItem._meta.get_field('content_type')
 
 }}}
 (`object_id` and `content_type` aren't hidden).

 There's a related discussion in the
 
[https://github.com/django/django/blob/d4d79d0f200357b28419203557cc61c8168316ab/docs/ref/models/meta.txt#L79-L84
 Options.get_fields() docs] that also needs some correction.

 Another thing I noticed is that `Field.hidden` is
 
[https://github.com/django/django/blob/d4d79d0f200357b28419203557cc61c8168316ab/django/db/models/options.py#L792-L793
 only consulted for relational fields]. Removing `Field.hidden` and
 `GenericForeignKey.hidden` doesn't result in any crash of `get_fields()`
 because those attributes are never consulted.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.26701ec88fda882a419f8885bc86560f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.