Re: [Django] #28154: Infinite loop in collectstatic with broken symlinks

[Django]

#28154: Infinite loop in collectstatic with broken symlinks
-+-
 Reporter:  Matthew Somerville   |Owner:  Jacob
 |  Walls
 Type:  Bug  |   Status:  closed
Component:  File |  Version:  dev
  uploads/storage|
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"ec2727efef605437eb572d51ca9afbb3a60eda40" ec2727ef]:
 {{{
 #!CommitTicketReference repository=""
 revision="ec2727efef605437eb572d51ca9afbb3a60eda40"
 Fixed #28154 -- Prevented infinite loop in FileSystemStorage.save() when a
 broken symlink with the same name exists.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.5473d3fca61b6fb6857ea65b33ef349a%40djangoproject.com.

Re: [Django] #28154: Infinite loop in collectstatic with broken symlinks

[Django]

#28154: Infinite loop in collectstatic with broken symlinks
-+-
 Reporter:  Matthew Somerville   |Owner:  Jacob
 |  Walls
 Type:  Bug  |   Status:  assigned
Component:  File |  Version:  dev
  uploads/storage|
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.09ab18295f71fa8c2179bb99aef1586c%40djangoproject.com.

Re: [Django] #28154: Infinite loop in collectstatic with broken symlinks

[Django]

#28154: Infinite loop in collectstatic with broken symlinks
-+-
 Reporter:  Matthew Somerville   |Owner:  Jacob
 |  Walls
 Type:  Bug  |   Status:  assigned
Component:  File |  Version:  dev
  uploads/storage|
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jacob Walls):

 * has_patch:  0 => 1
 * component:  contrib.staticfiles => File uploads/storage


Comment:

 I reproduced this outside of contrib.staticfiles by just providing a
 broken symlink to `FileSystemStorage.save()` and never exiting a `while`
 loop. I'm hoping this is a welcome root cause to look at.

 [https://github.com/django/django/pull/14474 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.2f446d1fba47dfc9f5441a29278115ee%40djangoproject.com.

Re: [Django] #28154: Infinite loop in collectstatic with broken symlinks

[Django]

#28154: Infinite loop in collectstatic with broken symlinks
-+-
 Reporter:  Matthew Somerville   |Owner:  Jacob
 |  Walls
 Type:  Bug  |   Status:  assigned
Component:  contrib.staticfiles  |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jacob Walls):

 * owner:  ChillarAnand => Jacob Walls
 * version:  1.11 => dev


Comment:

 Decided to reproduce this on main. Still can.

 I'm preparing a tiny patch using the second possibility from the ticket
 description: using `os.path.lexists()` in `FileSystemStorage.exists()`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.29e46ae00d42dad9913f87abfafcd259%40djangoproject.com.

Re: [Django] #28154: Infinite loop in collectstatic with broken symlinks

[Django]

#28154: Infinite loop in collectstatic with broken symlinks
-+-
 Reporter:  Matthew Somerville   |Owner:
 |  ChillarAnand
 Type:  Bug  |   Status:  assigned
Component:  contrib.staticfiles  |  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by ChillarAnand):

 * status:  new => assigned
 * owner:  nobody => ChillarAnand


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.83643841777a91b6860eec5527402722%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28154: Infinite loop in collectstatic with broken symlinks

[Django]

#28154: Infinite loop in collectstatic with broken symlinks
-+
 Reporter:  Matthew Somerville   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.staticfiles  |  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by Tim Graham):

 Which commit fixed it? Most likely a fix wouldn't qualify for a backport
 based on our [https://docs.djangoproject.com/en/dev/internals/release-
 process/#supported-versions supported versions policy].

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.7b2f12ac50471a7469e2c21f39897d70%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28154: Infinite loop in collectstatic with broken symlinks

[Django]

#28154: Infinite loop in collectstatic with broken symlinks
-+
 Reporter:  Matthew Somerville   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.staticfiles  |  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by KwonHan Bae):

 I think its fixed in master branch.
 should we backport to 11.x ?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.c2ec3ab0c240ebebea62ec569b22d95f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28154: Infinite loop in collectstatic with broken symlinks (was: Infinite loop in collectstatic)

[Django]

#28154: Infinite loop in collectstatic with broken symlinks
-+
 Reporter:  Matthew Somerville   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.staticfiles  |  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by Tim Graham):

 * stage:  Unreviewed => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.3b2ea3092b175ac5d4135c3a298a3993%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.