#28159: Fix issues with InlineFormset.save_as_new in Django 1.11
-------------------------------------+-------------------------------------
Reporter: Alexander | Owner: nobody
Kavanaugh |
Type: Bug | Status: new
Component: Forms | Version: 1.11
Severity: Normal | Keywords:
Triage Stage: | inlineformset,save_as_new
Unreviewed | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Django 1.11 now marks multipart POST data as immutable [(Release notes
section)](https://docs.djangoproject.com/en/1.11/releases/1.11/#miscellaneous).
This causes an issue with the private ``save_as_new`` feature in
InlineFormsets: the set code in the conditional block
[here](https://github.com/django/django/blob/master/django/forms/models.py#L886)
now throws an AttributeError because the data it's attempting to change is
marked as immutable.
To restore previous behavior, this pull request turns off the immutability
flag on the form data while the save_as_new functionality runs and turns
immutability back on when the mutation code is complete.
Note that the mutable flag isn't set if there is no data, hence the
``hasattr`` code.
PR: https://github.com/django/django/pull/8448
--
Ticket URL: <https://code.djangoproject.com/ticket/28159>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/049.27828fd0d7fd5794f0a7a5614f88c960%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
